You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/10/10 12:14:26 UTC
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Hello Will Berkeley, Alex Rodoni, Alexey Serbin, Mike Percy, Dan Burkert, Jean-Daniel Cryans, Andrew Wong, Adar Dembo, Greg Solovyev, Sailesh Mukil, Grant Henke, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11647
to review the following change.
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 217 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/1
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Ferenc Szabo, Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Attila Piros, Mitch Barnett, Adar Dembo, Sailesh Mukil, Greg Solovyev, Will Berkeley, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11647
to look at the new patch set (#5).
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 214 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/5
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Ferenc Szabo, Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Attila Piros, Adar Dembo, Sailesh Mukil, Greg Solovyev, Will Berkeley, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11647
to look at the new patch set (#2).
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 217 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/2
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11647/4/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/4/docs/release_notes.adoc@67
PS4, Line 67: ]
> The slash looks misplaced
Done
http://gerrit.cloudera.org:8080/#/c/11647/4/docs/release_notes.adoc@72
PS4, Line 72: (see link:https://issues.apache.org/jira/browse/KUDU-2287[KUDU-2287]).
> looks like the parens aren't balanced here
Done
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 23:09:59 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 14:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11647/12/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/12/docs/release_notes.adoc@40
PS12, Line 40: Kudu Flume Sink release
> Incomplete though?
Done
http://gerrit.cloudera.org:8080/#/c/11647/12/docs/release_notes.adoc@41
PS12, Line 41: res Java 1.8
> of the Kudu Flume Sink
Done
http://gerrit.cloudera.org:8080/#/c/11647/12/docs/release_notes.adoc@42
PS12, Line 42: higher.
> Remove
Done
http://gerrit.cloudera.org:8080/#/c/11647/12/docs/release_notes.adoc@167
PS12, Line 167: l
> nit: to the
Done
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 14
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 19:43:23 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Ferenc Szabo (Code Review)" <ge...@cloudera.org>.
Ferenc Szabo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 2: Code-Review+1
Flume related changes look good.
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 13:27:14 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Ferenc Szabo, Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Attila Piros, Mitch Barnett, Adar Dembo, Sailesh Mukil, Greg Solovyev, Will Berkeley, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11647
to look at the new patch set (#14).
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 250 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/14
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 14
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 14: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 14
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 20:05:17 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@43
PS5, Line 43:
: - Hadoop 3.0+ requires Java 8 at runtime even though the Kudu Hadoop integra
> What is hadoop used for? Isn't it needed only for the backup feature? Shoul
I added a note that should clear it up a bit
- Hadoop 3.0+ requires Java 8 at runtime even though the Kudu Hadoop integration is Java 7
compatible. Hadoop 3.1 is the default dependency version as of Kudu 1.8.0, used by
certain features in the Java client.
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 06:05:52 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11647/7/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/7/docs/release_notes.adoc@112
PS7, Line 112: - Replica selection in master honors placement policy. The way how the master places
: replicas of new tablets has changed. In essence (for details see
: https://s.apache.org/location-awareness-design), the placement policy accomplishes the
: following:
:
: ** in case of N locations, N > 2, not placing the majority of replicas in one location;
:
: ** spreading replicas evenly among available locations;
:
: ** within a location, spreading replicas evenly among tablet servers.
As Todd mentioned in PS5, that's something which is part of the not-yet-complete location awareness feature. Probably, we don't want to mention it like that.
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 01:19:20 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 15: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc@301
PS14, Line 301: Kudu 1.7 client library will run without
: modification against the Kudu 1.8 client library
> thanks for bringing it to my attention, discussed with Dan and as it's a no
SGTM
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 15
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 00:00:53 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Ferenc Szabo, Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Attila Piros, Mitch Barnett, Adar Dembo, Sailesh Mukil, Greg Solovyev, Will Berkeley, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11647
to look at the new patch set (#13).
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 214 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/13
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 13
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@40
PS5, Line 40: - Flume 1.8+ requires Java 8 at runtime even though the Kudu Flume integration is Java 7
: compatible. Flume 1.8 is the default dependency version as of Kudu 1.8.0.
> @Grant do you know if the "will not function" part is correct?
The dependency is marked as provided scope, so technically you can provide any compatible Flume version you would like.
It's hard to say. It might function with older versions but we don't test them.
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@43
PS5, Line 43: - Hadoop 3.0+ requires Java 8 at runtime even though the Kudu Hadoop integration is Java 7
: compatible. Hadoop 3.1 is the default dependency version as of Kudu 1.8.0.
> @Grant, do you have any extra context here?
These are marked as provided scope. Technically you could provide any compatible Hadoop jar. But given we don't test anything else, we don't list what is compatible.
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 00:47:42 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Ferenc Szabo, Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Attila Piros, Mitch Barnett, Adar Dembo, Sailesh Mukil, Greg Solovyev, Will Berkeley, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11647
to look at the new patch set (#6).
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 217 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/6
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Reviewed-on: http://gerrit.cloudera.org:8080/11647
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M docs/release_notes.adoc
1 file changed, 250 insertions(+), 27 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 16
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Ferenc Szabo, Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Attila Piros, Mitch Barnett, Adar Dembo, Sailesh Mukil, Greg Solovyev, Will Berkeley, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11647
to look at the new patch set (#11).
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 207 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/11
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#8) to the change originally created by Attila Bukor. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 206 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/8
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Ferenc Szabo, Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Attila Piros, Mitch Barnett, Adar Dembo, Sailesh Mukil, Greg Solovyev, Will Berkeley, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11647
to look at the new patch set (#12).
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 211 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/12
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 12
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Ferenc Szabo, Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Attila Piros, Mitch Barnett, Adar Dembo, Sailesh Mukil, Greg Solovyev, Will Berkeley, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11647
to look at the new patch set (#9).
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 207 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/9
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/11647/4/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/4/docs/release_notes.adoc@67
PS4, Line 67: /
The slash looks misplaced
http://gerrit.cloudera.org:8080/#/c/11647/4/docs/release_notes.adoc@72
PS4, Line 72: (see link:https://issues.apache.org/jira/browse/KUDU-2287)[KUDU-2287)])
looks like the parens aren't balanced here
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 22:59:39 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 14: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 14
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 20:53:58 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11647/11/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/11/docs/release_notes.adoc@165
PS11, Line 165:
may be worth mentioning a couple of Spark connector improvements:
* eee82d90a - spark: Expose socketReadTimeoutMs to Spark connector
* 5a91629e5 - spark: Add support for scanRequestTimeout to DefaultSource
These additional configuration parameters make it possible to better tune the Spark connector to avoid scan timeouts when the system is under increased load.
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 06:52:23 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 2:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@36
PS2, Line 36: Kudu, it is recommended to first shut down all Kudu processes across the cluster, then
Here and elsewhere the indenting is lost.
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@52
PS2, Line 52: - The `-table_num_buckets` configuration is now deprecated in favor of
This should clarify that it applies to the loadgen tool, otherwise it can be misinterpreted to be a much larger change.
edit: see comment on line 144 below
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@66
PS2, Line 66: `examples/`
perhaps this should link to github?
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@94
PS2, Line 94: - Clients now support setting a limit on the number of returned rows (see
I'd add 'in a scan' to clarify the context
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@144
PS2, Line 144: - The `kudu perf loadgen` tool now supports generating range-partitioned tables. The
This is a better description of the change I pointed out above, perhaps that one should just be removed.
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@173
PS2, Line 173: When a tablet server was wiped and recreated with the same RPC address
pretty sure this sentence is a fragment, it should include a description of what failed.
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@235
PS2, Line 235: - Rolling upgrade between Kudu 1.7 and Kudu 1.8 servers is believed to be possible though
This is largely repeating what was said above, should it be consolidated?
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 17:32:09 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 5:
(13 comments)
Mostly just a bunch of backtick nits. Might be worth rendering it in Github or Jekyll to make sure it looks alright.
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@41
PS5, Line 41:
nit: extra space
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@106
PS5, Line 106:
nit: extra space
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@111
PS5, Line 111: is about
nit: "accomplishes the following:"?
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@138
PS5, Line 138: getpwuid_r()
nit: add backticks
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@161
PS5, Line 161: )
looks like an extra parens
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@174
PS5, Line 174: ksck
nit: backticks?
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@182
PS5, Line 182: /mem-trackers
nit: backticks
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@197
PS5, Line 197: KuduTableInputFormat
nit: backticks
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@208
PS5, Line 208: FATAL
nit: backticks? or just remove
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@212
PS5, Line 212: `use-after-free`
maybe no backticks?
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@224
PS5, Line 224: tabllets
tablets
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@227
PS5, Line 227: Fixed logging init if linking kudu client library: prior to this fix, the kudu CLI tool
: would unexpectedly exit on SIGPIPE when master/tserver abruptly closed connection.
Maybe reword: "Fixed an error that would cause the Kudu CLI tool to unexpectedly exit when the connection to the master or tserver was abruptly closed." At first I thought this was just a logging error, but I don't think it was?
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@228
PS5, Line 228: SIGPIPE
nit: backticks
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 23:32:45 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: Add release notes for 1.8.0
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 14
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 13: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11647/12/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/12/docs/release_notes.adoc@167
PS12, Line 167: to
nit: to the
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 13
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:52:35 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11647/7/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/7/docs/release_notes.adoc@112
PS7, Line 112: - Replica selection in master honors placement policy. The way how the master places
: replicas of new tablets has changed. In essence (for details see
: https://s.apache.org/location-awareness-design), the placement policy accomplishes the
: following:
:
: ** in case of N locations, N > 2, not placing the majority of replicas in one location;
:
: ** spreading replicas evenly among available locations;
:
: ** within a location, spreading replicas evenly among tablet servers.
> As Todd mentioned in PS5, that's something which is part of the not-yet-com
OK, I removed this and posted PS8 for review.
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 01:59:00 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@125
PS5, Line 125: 15 minutes
> 15 minutes, really? isn't our server side scanner timeout one minute?
Ha, my bad. Supposed to say seconds.
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 00:02:30 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Ferenc Szabo, Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Attila Piros, Mitch Barnett, Adar Dembo, Sailesh Mukil, Greg Solovyev, Will Berkeley, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11647
to look at the new patch set (#7).
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 217 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/7
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 14: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 14
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 20:54:02 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 4:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@36
PS2, Line 36: Kudu, it is recommended to first shut down all Kudu processes across the cluster, then
> Here and elsewhere the indenting is lost.
Done
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@52
PS2, Line 52: - The `-table_num_buckets` configuration option of the `kudu perf loadgen` tool is now
> This should clarify that it applies to the loadgen tool, otherwise it can b
I think it's still a good idea to list it in deprecations too, reworded it to make sure it's clear it's only for `kudu perf loadgen`
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@66
PS2, Line 66:
> perhaps this should link to github?
Done
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@94
PS2, Line 94:
> I'd add 'in a scan' to clarify the context
Done
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@144
PS2, Line 144:
> This is a better description of the change I pointed out above, perhaps tha
Done
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@173
PS2, Line 173:
> pretty sure this sentence is a fragment, it should include a description of
Done
http://gerrit.cloudera.org:8080/#/c/11647/2/docs/release_notes.adoc@235
PS2, Line 235: - Kudu 1.8 clients may connect to servers running Kudu 1.0 or later. If the client uses
> This is largely repeating what was said above, should it be consolidated?
I removed this and left the one at the top
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 18:15:30 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@125
PS5, Line 125: (see
> I'll ask Grant about this
thanks Grant
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 00:17:20 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 14:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc@136
PS14, Line 136: .
nit: move this period after the (see link:https://...) parentheses.
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc@256
PS14, Line 256: Kudu CLI tool
nit: kudu CLI tool (i.e. the tool's binary named 'kudu', not 'Kudu').
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc@259
PS14, Line 259: d
nit: drop
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc@260
PS14, Line 260: .
nit: drop
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc@301
PS14, Line 301: Kudu 1.7 client library will run without
: modification against the Kudu 1.8 client library
There might be some caveat due to the issue with KUDU_NO_EXPORT attribute addressed in ed60c11a3e2fa78e32edbb4f5d3cf844d23d8f00. It seems if the Kudu client library of 1.7 or earlier version was compiled with affected compiler and an application used GetTablet() method, it might break to link with Kudu client library of 1.8
version.
I'm not sure whether it's worth mentioning this, though.
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 14
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 22:31:09 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 9:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/11647/4/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/4/docs/release_notes.adoc@221
PS4, Line 221:
> reporting
Done
http://gerrit.cloudera.org:8080/#/c/11647/4/docs/release_notes.adoc@224
PS4, Line 224:
> tablets
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@40
PS5, Line 40: - Kudu Flume Sink is test Flume 1.8+ requires Java 8 at runtime even though the Kudu Flume
: integration is Java 7 compatible. Flume 1.8 is the default dependency of F
> The dependency is marked as provided scope, so technically you can provide
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@43
PS5, Line 43:
: - Hadoop 3.0+ requires Java 8 at runtime even though the Kudu Hadoop integra
> These are marked as provided scope. Technically you could provide any compa
What is hadoop used for? Isn't it needed only for the backup feature? Should we even list it here if we don't advertise it yet?
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@58
PS5, Line 58: major rele
> yep, seems like these are really deprecated only
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@63
PS5, Line 63: and `producer.unmatchedRowPolicy` respectively (see
> I would argue that a lot of these new features are more "improvements". Can
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@109
PS5, Line 109:
: - Added Pandas support to the Python client (see
: link:https://issues.apache.org/jira/browse/KUDU-1276[KUDU-1276]).
:
: - Enabled configuration of mutation buffer in the Python client (see
: link:https://issues.apache.org/jira/browse/KUDU-2441[KUDU-2441]).
:
: - Added a `keepAlive` API call to the `KuduScanner` and `AsyncKuduScanner` in the Java
: client. This API can be used to keep the scanners alive on the ser
> I think that's correct for the state-of-the-project: right now (October 10)
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@125
PS5, Line 125:
> thanks Grant
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@142
PS5, Line 142: link:https://issues.apache.org/jira/browse/KUDU-1861[KUDU-1861]).
> looking into this
Done
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 06:01:32 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 15:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc@136
PS14, Line 136:
> nit: move this period after the (see link:https://...) parentheses.
Done
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc@256
PS14, Line 256: kudu CLI tool
> nit: kudu CLI tool (i.e. the tool's binary named 'kudu', not 'Kudu').
Done
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc@259
PS14, Line 259:
> nit: drop
Done
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc@260
PS14, Line 260:
> nit: drop
Done
http://gerrit.cloudera.org:8080/#/c/11647/14/docs/release_notes.adoc@301
PS14, Line 301: Kudu 1.7 client library will run without
: modification against the Kudu 1.8 client library
> There might be some caveat due to the issue with KUDU_NO_EXPORT attribute a
thanks for bringing it to my attention, discussed with Dan and as it's a non-public API call and it would happen only if compiled with very old GCC, I'm not adding this.
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 15
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 23:33:11 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Ferenc Szabo, Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Attila Piros, Mitch Barnett, Adar Dembo, Sailesh Mukil, Greg Solovyev, Will Berkeley, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11647
to look at the new patch set (#10).
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 208 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/10
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Ferenc Szabo, Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Attila Piros, Mitch Barnett, Adar Dembo, Sailesh Mukil, Greg Solovyev, Will Berkeley, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11647
to look at the new patch set (#15).
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 250 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/15
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 15
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 2:
This should also be against master and cherry picked back. Otherwise if we update docs in the future these notes will only exist on the 1.8 branch.
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 14:15:10 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.
Change subject: Add release notes for 1.8.0
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 12
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Ferenc Szabo, Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Attila Piros, Mitch Barnett, Adar Dembo, Sailesh Mukil, Greg Solovyev, Will Berkeley, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11647
to look at the new patch set (#4).
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 214 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/4
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11647/4/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/4/docs/release_notes.adoc@221
PS4, Line 221: reperting
reporting
http://gerrit.cloudera.org:8080/#/c/11647/4/docs/release_notes.adoc@224
PS4, Line 224: tabllets
tablets
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@104
PS5, Line 104: - Introduced rebalancer into the kudu CLI tool. The rebalancer can be used to redistribute
> would say something like "a manual data rebalancer" instead of just "rebala
Yes, that's just 'manual data rebalancer'. There is a section in docs/administration.adoc for that: https://github.com/apache/kudu/blob/branch-1.8.x/docs/administration.adoc#running-the-tablet-rebalancing-tool
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@109
PS5, Line 109: - Replica selection in master honors placement policy. The way how the master places
: replicas of new tablets has changed. In essence (for details see
: https://s.apache.org/location-awareness-design), the placement policy is about:
:
: ** in case of N locations, N > 2, not placing the majority of replicas in one location;
:
: ** spreading replicas evenly among available locations;
:
: ** within a location, spreading replicas evenly among tablet servers.
> is the placement policy work actually complete for this release? I thought
I think that's correct for the state-of-the-project: right now (October 10), I'm still working on the LA rebalancer, so probably it will be safer to not mention it.
There are some parts of the LA features in the 1.8 branch already, but some not yet there yet.
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 00:38:23 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 2:
> Patch Set 2:
>
> This should also be against master and cherry picked back. Otherwise if we update docs in the future these notes will only exist on the 1.8 branch.
I'm planning to copy it to prior_release_notes.adoc in master once it's merged in to branch-1.8.x, making sure we don't 'lose' this from master that way.
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 14:30:49 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 15: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 15
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 23:36:30 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 12:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11647/12/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/12/docs/release_notes.adoc@40
PS12, Line 40: Kudu Flume Sink is test
Incomplete though?
http://gerrit.cloudera.org:8080/#/c/11647/12/docs/release_notes.adoc@41
PS12, Line 41: of Flume Sink
of the Kudu Flume Sink
http://gerrit.cloudera.org:8080/#/c/11647/12/docs/release_notes.adoc@42
PS12, Line 42: version
Remove
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 12
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:41:45 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 5:
(14 comments)
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@40
PS5, Line 40: - Flume 1.8+ requires Java 8 at runtime even though the Kudu Flume integration is Java 7
: compatible. Flume 1.8 is the default dependency version as of Kudu 1.8.0.
this is a little confusing to me, since Kudu itself doesn't have Flume as a dependency.
Maybe we should say something like "The Flume sink released with Kudu 1.8.0 is now compiled to build against Flume 1.8 and will not function with earlier versions of Flume. Note that Flume 1.8 requires Java 8 or higher."
(I assume the "will not function" part is correct?)
That way it's clearer that this only affects people using Flume.
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@43
PS5, Line 43: - Hadoop 3.0+ requires Java 8 at runtime even though the Kudu Hadoop integration is Java 7
: compatible. Hadoop 3.1 is the default dependency version as of Kudu 1.8.0.
similar feedback here, I'm not sure what exactly this means. If I'm using Hadoop 2.x can I no longer use Kudu?
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@53
PS5, Line 53: deprecated
it appears that this configuration was removed, not deprecated. Deprecated means that it will still work but is being phased out, but I can't find it in the source anymore.
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@58
PS5, Line 58: deprecated
it seems these ones really are deprecated and not removed, right?
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@63
PS5, Line 63: == New features
I would argue that a lot of these new features are more "improvements". Can we move all of the smaller ones here into the improvements section and keep it to 2-3 headline features?
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@65
PS5, Line 65: - A great deal of work went into providing examples that showcase Kudu client
style nit: i dont think the amount of work spent is relevant in the context of release notes. Better to just state the facts that we imported and improved a set of examples that were previously hosted in a separate repository on github
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@101
PS5, Line 101: Enable
nit: Enabled
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@104
PS5, Line 104: - Introduced rebalancer into the kudu CLI tool. The rebalancer can be used to redistribute
would say something like "a manual data rebalancer" instead of just "rebalancer" to be more specific. Is there documentation on this that can be linked to?
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@109
PS5, Line 109: - Replica selection in master honors placement policy. The way how the master places
: replicas of new tablets has changed. In essence (for details see
: https://s.apache.org/location-awareness-design), the placement policy is about:
:
: ** in case of N locations, N > 2, not placing the majority of replicas in one location;
:
: ** spreading replicas evenly among available locations;
:
: ** within a location, spreading replicas evenly among tablet servers.
is the placement policy work actually complete for this release? I thought it was still work-in-progress in terms of making the balancer, ksck, etc aware. I would suggest not including it here if it's not ready for primetime including docs and tool support.
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@125
PS5, Line 125: 15 minutes
15 minutes, really? isn't our server side scanner timeout one minute?
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@142
PS5, Line 142: - Improved rowset tree pruning (see
can this be expanded to indicate what kind of operations might be faster? iirc it improved scans where one endpoint was specified and the other was not or something?
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@146
PS5, Line 146: deprecated
removed
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@190
PS5, Line 190: deleted
nit: comma after 'deletd'
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@224
PS5, Line 224: tabllets
typo
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Oct 2018 23:33:33 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 5:
(25 comments)
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@40
PS5, Line 40: - Flume 1.8+ requires Java 8 at runtime even though the Kudu Flume integration is Java 7
: compatible. Flume 1.8 is the default dependency version as of Kudu 1.8.0.
> this is a little confusing to me, since Kudu itself doesn't have Flume as a
@Grant do you know if the "will not function" part is correct?
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@41
PS5, Line 41:
> nit: extra space
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@43
PS5, Line 43: - Hadoop 3.0+ requires Java 8 at runtime even though the Kudu Hadoop integration is Java 7
: compatible. Hadoop 3.1 is the default dependency version as of Kudu 1.8.0.
> similar feedback here, I'm not sure what exactly this means. If I'm using H
@Grant, do you have any extra context here?
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@53
PS5, Line 53: deprecated
> it appears that this configuration was removed, not deprecated. Deprecated
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@58
PS5, Line 58: deprecated
> it seems these ones really are deprecated and not removed, right?
yep, seems like these are really deprecated only
@Deprecated
public static final String SKIP_MISSING_COLUMN_PROP = "skipMissingColumn";
@Deprecated
public static final boolean DEFAULT_SKIP_MISSING_COLUMN = false;
@Deprecated
public static final String SKIP_BAD_COLUMN_VALUE_PROP = "skipBadColumnValue";
@Deprecated
public static final boolean DEFAULT_SKIP_BAD_COLUMN_VALUE = false;
@Deprecated
public static final String WARN_UNMATCHED_ROWS_PROP = "skipUnmatchedRows";
@Deprecated
public static final boolean DEFAULT_WARN_UNMATCHED_ROWS = true;
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@65
PS5, Line 65: - A great deal of work went into providing examples that showcase Kudu client
> style nit: i dont think the amount of work spent is relevant in the context
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@101
PS5, Line 101: Enable
> nit: Enabled
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@104
PS5, Line 104: - Introduced rebalancer into the kudu CLI tool. The rebalancer can be used to redistribute
> would say something like "a manual data rebalancer" instead of just "rebala
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@106
PS5, Line 106:
> nit: extra space
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@111
PS5, Line 111: is about
> nit: "accomplishes the following:"?
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@109
PS5, Line 109: - Replica selection in master honors placement policy. The way how the master places
: replicas of new tablets has changed. In essence (for details see
: https://s.apache.org/location-awareness-design), the placement policy is about:
:
: ** in case of N locations, N > 2, not placing the majority of replicas in one location;
:
: ** spreading replicas evenly among available locations;
:
: ** within a location, spreading replicas evenly among tablet servers.
> is the placement policy work actually complete for this release? I thought
I'll ask Alexey about this
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@125
PS5, Line 125: 15 minutes
> 15 minutes, really? isn't our server side scanner timeout one minute?
I'll ask Grant about this
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@138
PS5, Line 138: getpwuid_r()
> nit: add backticks
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@142
PS5, Line 142: - Improved rowset tree pruning (see
> can this be expanded to indicate what kind of operations might be faster? i
looking into this
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@146
PS5, Line 146: deprecated
> removed
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@161
PS5, Line 161: )
> looks like an extra parens
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@174
PS5, Line 174: ksck
> nit: backticks?
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@182
PS5, Line 182: /mem-trackers
> nit: backticks
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@190
PS5, Line 190: deleted
> nit: comma after 'deletd'
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@197
PS5, Line 197: KuduTableInputFormat
> nit: backticks
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@208
PS5, Line 208: FATAL
> nit: backticks? or just remove
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@212
PS5, Line 212: `use-after-free`
> maybe no backticks?
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@224
PS5, Line 224: tabllets
> typo
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@228
PS5, Line 228: SIGPIPE
> nit: backticks
Done
http://gerrit.cloudera.org:8080/#/c/11647/5/docs/release_notes.adoc@227
PS5, Line 227: Fixed logging init if linking kudu client library: prior to this fix, the kudu CLI tool
: would unexpectedly exit on SIGPIPE when master/tserver abruptly closed connection.
> Maybe reword: "Fixed an error that would cause the Kudu CLI tool to unexpec
Done
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 00:09:27 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alex Rodoni, Ferenc Szabo, Mike Percy, Alexey Serbin, Dan Burkert, Jean-Daniel Cryans, Attila Piros, Mitch Barnett, Adar Dembo, Sailesh Mukil, Greg Solovyev, Will Berkeley, Kudu Jenkins, Andrew Wong, Grant Henke, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11647
to look at the new patch set (#3).
Change subject: Add release notes for 1.8.0
......................................................................
Add release notes for 1.8.0
Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
---
M docs/release_notes.adoc
1 file changed, 218 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/11647/3
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.8.x) Add release notes for 1.8.0
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11647 )
Change subject: Add release notes for 1.8.0
......................................................................
Patch Set 12: Verified+1
(1 comment)
Jenkins failure is obviously unrelated
http://gerrit.cloudera.org:8080/#/c/11647/11/docs/release_notes.adoc
File docs/release_notes.adoc:
http://gerrit.cloudera.org:8080/#/c/11647/11/docs/release_notes.adoc@165
PS11, Line 165:
> may be worth mentioning a couple of Spark connector improvements:
Done
--
To view, visit http://gerrit.cloudera.org:8080/11647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I15b0ce686c5e69648fe09a18ca82b9bf54cab837
Gerrit-Change-Number: 11647
Gerrit-PatchSet: 12
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Piros <pi...@gmail.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Ferenc Szabo <fs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Mitch Barnett
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Oct 2018 09:40:12 +0000
Gerrit-HasComments: Yes