[jira] [Commented] (CB-5847) Setting "strict-ssl" of npm is ignored

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-5847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966317#comment-13966317 ] 

ASF GitHub Bot commented on CB-5847:
------------------------------------

GitHub user lbunschoten opened a pull request:

    https://github.com/apache/cordova-cli/pull/163

    CB-5847 strictSSL is no longer ignored

    The strictSSL setting of npm was being ignored. I added a bit of code to make sure the strictSSL setting is added to the request.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lbunschoten/cordova-cli master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-cli/pull/163.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #163
    
----
commit 0570308aaa471ee15b23f02cf9576717d2c96de5
Author: lbunschoten <le...@leonbunschoten.nl>
Date:   2014-04-11T07:57:01Z

    CB-5847 strictSSL is no longer ignored

----


> Setting "strict-ssl" of npm is ignored
> --------------------------------------
>
>                 Key: CB-5847
>                 URL: https://issues.apache.org/jira/browse/CB-5847
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI
>    Affects Versions: Master
>         Environment: All
>            Reporter: Maximilian Walter
>            Priority: Minor
>              Labels: cli, patch, proxy, ssl
>         Attachments: lazy_load_strict_ssl.patch
>
>
> The file "lazy_load.js" uses the proxy-server configured for npm, but ignores the setting "strict-ssl". This can prevent a download if a https-proxy with an self-sigend certificate is used.



--
This message was sent by Atlassian JIRA
(v6.2#6252)