You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/08 11:33:25 UTC
[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #5726: Extended some deprecation comments in API folder
ajantha-bhat commented on code in PR #5726:
URL: https://github.com/apache/iceberg/pull/5726#discussion_r965841940
##########
api/src/main/java/org/apache/iceberg/metrics/DefaultMetricsContext.java:
##########
@@ -24,6 +24,9 @@
public class DefaultMetricsContext implements MetricsContext {
private static final int DEFAULT_HISTOGRAM_RESERVOIR_SIZE = 10_000;
+ /**
+ * @deprecated will be removed in 2.0.0, use {@link org.apache.iceberg.metrics.Counter} instead.
Review Comment:
Isn't 2.0.0 too far? Should we mention it as "will be removed after 1.0.0"?
Let's wait for @danielcweeks's response on this before addressing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org