[GitHub] [arrow] hermanschaaf commented on a diff in pull request #35303: GH-35302: [Go] Improve unsupported type error message in pqarrow

["hermanschaaf (via GitHub)" <gi...@apache.org>]

hermanschaaf commented on code in PR #35303:
URL: https://github.com/apache/arrow/pull/35303#discussion_r1175425448


##########
go/parquet/pqarrow/schema.go:
##########
@@ -388,7 +388,7 @@ func fieldToNode(name string, field arrow.Field, props *parquet.WriterProperties
 		}
 		return schema.MapOf(field.Name, keyNode, valueNode, repFromNullable(field.Nullable), -1)
 	default:
-		return nil, xerrors.New("not implemented yet")
+		return nil, xerrors.Errorf("support for %v not implemented yet", field.Type.ID())

Review Comment:
   The `switch` that this is the default for is on `field.Type.ID()`, which is why I thought it makes more sense to use `field.Type.ID()` in the error as well. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org