You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/07 03:28:41 UTC
[GitHub] [rocketmq-connect] Oliverwqcwrw opened a new issue, #244: There are many unreadable methods
Oliverwqcwrw opened a new issue, #244:
URL: https://github.com/apache/rocketmq-connect/issues/244
**BUG REPORT**
1. Please describe the issue you observed:
- What did you do (The steps to reproduce)?
In `org.apache.rocketmq.connect.runtime.errors.ProcessingContext`
There are many methods to get parameters without get, and many methods to set parameters without set
>
/**
* Set the record consumed from Kafka in a sink connector.
*
* @param consumedMessage the record
*/
public void consumerRecord(MessageExt consumedMessage) {
this.consumedMessage = consumedMessage;
reset();
}
/**
* @return the record consumed from Kafka. could be null
*/
public MessageExt consumerRecord() {
return consumedMessage;
}
/**
* @return the source record being processed.
*/
public ConnectRecord sourceRecord() {
return sourceRecord;
}
/**
* Set the source record being processed in the connect pipeline.
*
* @param record the source record
*/
public void sourceRecord(ConnectRecord record) {
this.sourceRecord = record;
reset();
}
/**
* Set the stage in the connector pipeline which is currently executing.
*
* @param stage the stage
*/
public void stage(ErrorReporter.Stage stage) {
this.stage = stage;
}
/**
* @return the stage in the connector pipeline which is currently executing.
*/
public ErrorReporter.Stage stage() {
return stage;
}
/**
* @return the class which is going to execute the current operation.
*/
public Class<?> executingClass() {
return klass;
}
/**
* @param klass set the class which is currently executing.
*/
public void executingClass(Class<?> klass) {
this.klass = klass;
}
- What is expected to see?
Get is added to the method of getting parameters, and set is added to the method of setting parameters
- What did you see instead?
There are many unreadable methods
2. Please tell us about your environment:
master
4. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):
What do you think ? @sunxiaojian
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] Oliverwqcwrw commented on issue #244: There are many unreadable methods
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw commented on issue #244:
URL: https://github.com/apache/rocketmq-connect/issues/244#issuecomment-1217405028
Get it, thanks for your reply
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] Oliverwqcwrw closed issue #244: There are many unreadable methods
Posted by GitBox <gi...@apache.org>.
Oliverwqcwrw closed issue #244: There are many unreadable methods
URL: https://github.com/apache/rocketmq-connect/issues/244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] sunxiaojian commented on issue #244: There are many unreadable methods
Posted by GitBox <gi...@apache.org>.
sunxiaojian commented on issue #244:
URL: https://github.com/apache/rocketmq-connect/issues/244#issuecomment-1209366781
> There are many methods to get parameters without get, and many methods to set parameters without set
>
> >
If you do not use JSON for serialization, you should not impose restrictions on the declaration of methods; However, the same project will consider declaring in the same way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org