You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/30 08:43:39 UTC
[GitHub] [flink] lirui-apache opened a new pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
lirui-apache opened a new pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721
…le null values
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Fix NPEs when writing nulls to a Hive table
## Brief change log
- Add null check to HiveObjectConversion implementations
- Add test
## Verifying this change
New test case
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? NA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569622936
<!--
Meta data
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142626733 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142641843 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:57bd2165744e96791981981cbdffddd4587fc461 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142740143 TriggerType:PUSH TriggerID:57bd2165744e96791981981cbdffddd4587fc461
Hash:57bd2165744e96791981981cbdffddd4587fc461 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4017 TriggerType:PUSH TriggerID:57bd2165744e96791981981cbdffddd4587fc461
Hash:b1a5f580d3427b510c94572d79b42ba231492a59 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142845329 TriggerType:PUSH TriggerID:b1a5f580d3427b510c94572d79b42ba231492a59
Hash:b1a5f580d3427b510c94572d79b42ba231492a59 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4037 TriggerType:PUSH TriggerID:b1a5f580d3427b510c94572d79b42ba231492a59
-->
## CI report:
* 62027bf514e75e43953585ade0ed57453b9df2f5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142626733) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980)
* 44d60e2a99f9e63e32294e231f405cfcaef2f698 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142641843) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985)
* 57bd2165744e96791981981cbdffddd4587fc461 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142740143) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4017)
* b1a5f580d3427b510c94572d79b42ba231492a59 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142845329) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569622936
<!--
Meta data
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142626733 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142641843 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:57bd2165744e96791981981cbdffddd4587fc461 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:57bd2165744e96791981981cbdffddd4587fc461
-->
## CI report:
* 62027bf514e75e43953585ade0ed57453b9df2f5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142626733) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980)
* 44d60e2a99f9e63e32294e231f405cfcaef2f698 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142641843) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985)
* 57bd2165744e96791981981cbdffddd4587fc461 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xuefuz commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
xuefuz commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#discussion_r362148281
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV100.java
##########
@@ -354,6 +354,9 @@ public CatalogColumnStatisticsDataDate toFlinkDateColStats(ColumnStatisticsData
@Override
public Object toHiveTimestamp(Object flinkTimestamp) {
+ if (flinkTimestamp == null) {
Review comment:
Sounds reasonable to me to do the check here..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569622936
<!--
Meta data
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142626733 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
-->
## CI report:
* 62027bf514e75e43953585ade0ed57453b9df2f5 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142626733) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569622936
<!--
Meta data
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142626733 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142641843 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:57bd2165744e96791981981cbdffddd4587fc461 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142740143 TriggerType:PUSH TriggerID:57bd2165744e96791981981cbdffddd4587fc461
Hash:57bd2165744e96791981981cbdffddd4587fc461 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4017 TriggerType:PUSH TriggerID:57bd2165744e96791981981cbdffddd4587fc461
-->
## CI report:
* 62027bf514e75e43953585ade0ed57453b9df2f5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142626733) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980)
* 44d60e2a99f9e63e32294e231f405cfcaef2f698 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142641843) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985)
* 57bd2165744e96791981981cbdffddd4587fc461 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142740143) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4017)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569622936
<!--
Meta data
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142626733 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142641843 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:57bd2165744e96791981981cbdffddd4587fc461 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142740143 TriggerType:PUSH TriggerID:57bd2165744e96791981981cbdffddd4587fc461
Hash:57bd2165744e96791981981cbdffddd4587fc461 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4017 TriggerType:PUSH TriggerID:57bd2165744e96791981981cbdffddd4587fc461
-->
## CI report:
* 62027bf514e75e43953585ade0ed57453b9df2f5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142626733) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980)
* 44d60e2a99f9e63e32294e231f405cfcaef2f698 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142641843) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985)
* 57bd2165744e96791981981cbdffddd4587fc461 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142740143) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4017)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569622936
<!--
Meta data
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142626733 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
-->
## CI report:
* 62027bf514e75e43953585ade0ed57453b9df2f5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142626733) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#discussion_r361930252
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV100.java
##########
@@ -354,6 +354,9 @@ public CatalogColumnStatisticsDataDate toFlinkDateColStats(ColumnStatisticsData
@Override
public Object toHiveTimestamp(Object flinkTimestamp) {
+ if (flinkTimestamp == null) {
Review comment:
Should solve null in `HiveInspectors` instead of here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569616440
Ping @zjuwangg @JingsongLi @bowenli86 @xuefuz
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#discussion_r361964151
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java
##########
@@ -146,9 +146,9 @@ public static HiveObjectConversion getConversion(ObjectInspector inspector, Logi
} else if (inspector instanceof TimestampObjectInspector) {
conversion = hiveShim::toHiveTimestamp;
} else if (inspector instanceof HiveCharObjectInspector) {
- conversion = o -> new HiveChar((String) o, ((CharType) dataType).getLength());
+ conversion = o -> o == null ? null : new HiveChar((String) o, ((CharType) dataType).getLength());
} else if (inspector instanceof HiveVarcharObjectInspector) {
- conversion = o -> new HiveVarchar((String) o, ((VarCharType) dataType).getLength());
+ conversion = o -> o == null ? null : new HiveVarchar((String) o, ((VarCharType) dataType).getLength());
} else if (inspector instanceof HiveDecimalObjectInspector) {
conversion = o -> o == null ? null : HiveDecimal.create((BigDecimal) o);
} else {
Review comment:
And we should deal with `null` in `WritableHiveObjectConversion` too.
Because this is a common util, not just for constant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#discussion_r361930638
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java
##########
@@ -146,9 +146,9 @@ public static HiveObjectConversion getConversion(ObjectInspector inspector, Logi
} else if (inspector instanceof TimestampObjectInspector) {
conversion = hiveShim::toHiveTimestamp;
} else if (inspector instanceof HiveCharObjectInspector) {
- conversion = o -> new HiveChar((String) o, ((CharType) dataType).getLength());
+ conversion = o -> o == null ? null : new HiveChar((String) o, ((CharType) dataType).getLength());
} else if (inspector instanceof HiveVarcharObjectInspector) {
- conversion = o -> new HiveVarchar((String) o, ((VarCharType) dataType).getLength());
+ conversion = o -> o == null ? null : new HiveVarchar((String) o, ((VarCharType) dataType).getLength());
} else if (inspector instanceof HiveDecimalObjectInspector) {
conversion = o -> o == null ? null : HiveDecimal.create((BigDecimal) o);
} else {
Review comment:
Is any cases cover `WritableHiveObjectConversion`? Is it a dead code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569622936
<!--
Meta data
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
-->
## CI report:
* 62027bf514e75e43953585ade0ed57453b9df2f5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 closed pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
bowenli86 closed pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#discussion_r361930479
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java
##########
@@ -146,9 +146,9 @@ public static HiveObjectConversion getConversion(ObjectInspector inspector, Logi
} else if (inspector instanceof TimestampObjectInspector) {
Review comment:
Should mark `HiveObjectConversion`:
`@Nullable Object toHiveObject(@Nullable Object o);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-570127766
@lirui-apache LGTM. Can you rebase to latest master? seems there's some conflicts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#discussion_r361970059
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java
##########
@@ -146,9 +146,9 @@ public static HiveObjectConversion getConversion(ObjectInspector inspector, Logi
} else if (inspector instanceof TimestampObjectInspector) {
conversion = hiveShim::toHiveTimestamp;
} else if (inspector instanceof HiveCharObjectInspector) {
- conversion = o -> new HiveChar((String) o, ((CharType) dataType).getLength());
+ conversion = o -> o == null ? null : new HiveChar((String) o, ((CharType) dataType).getLength());
} else if (inspector instanceof HiveVarcharObjectInspector) {
- conversion = o -> new HiveVarchar((String) o, ((VarCharType) dataType).getLength());
+ conversion = o -> o == null ? null : new HiveVarchar((String) o, ((VarCharType) dataType).getLength());
} else if (inspector instanceof HiveDecimalObjectInspector) {
conversion = o -> o == null ? null : HiveDecimal.create((BigDecimal) o);
} else {
Review comment:
> this is because we change "getObjectInspectorForConstant" to writable hive type
Do you mean the change in #10625? Actually even w/o #10625, this is not dead code because 1.1.x versions having been using writable OIs for constants.
> Cna you add comments to explain?
What do you think we should explain here? Please note that we may want to use writable OIs for both constant and non-constant in the future, as suggested in #10625.
> And we should deal with null in WritableHiveObjectConversion too
Let's leave that to #10625, since we're doing a bigger refactor there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#discussion_r361963995
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java
##########
@@ -146,9 +146,9 @@ public static HiveObjectConversion getConversion(ObjectInspector inspector, Logi
} else if (inspector instanceof TimestampObjectInspector) {
conversion = hiveShim::toHiveTimestamp;
} else if (inspector instanceof HiveCharObjectInspector) {
- conversion = o -> new HiveChar((String) o, ((CharType) dataType).getLength());
+ conversion = o -> o == null ? null : new HiveChar((String) o, ((CharType) dataType).getLength());
} else if (inspector instanceof HiveVarcharObjectInspector) {
- conversion = o -> new HiveVarchar((String) o, ((VarCharType) dataType).getLength());
+ conversion = o -> o == null ? null : new HiveVarchar((String) o, ((VarCharType) dataType).getLength());
} else if (inspector instanceof HiveDecimalObjectInspector) {
conversion = o -> o == null ? null : HiveDecimal.create((BigDecimal) o);
} else {
Review comment:
I see, this is because we change "getObjectInspectorForConstant" to writable hive type. Cna you add comments to explain?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569616602
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 62027bf514e75e43953585ade0ed57453b9df2f5 (Mon Dec 30 08:45:50 UTC 2019)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15429).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569622936
<!--
Meta data
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142626733 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
-->
## CI report:
* 62027bf514e75e43953585ade0ed57453b9df2f5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142626733) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980)
* 44d60e2a99f9e63e32294e231f405cfcaef2f698 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569622936
<!--
Meta data
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142626733 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142641843 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:57bd2165744e96791981981cbdffddd4587fc461 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142740143 TriggerType:PUSH TriggerID:57bd2165744e96791981981cbdffddd4587fc461
Hash:57bd2165744e96791981981cbdffddd4587fc461 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4017 TriggerType:PUSH TriggerID:57bd2165744e96791981981cbdffddd4587fc461
Hash:b1a5f580d3427b510c94572d79b42ba231492a59 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b1a5f580d3427b510c94572d79b42ba231492a59
-->
## CI report:
* 62027bf514e75e43953585ade0ed57453b9df2f5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142626733) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980)
* 44d60e2a99f9e63e32294e231f405cfcaef2f698 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142641843) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985)
* 57bd2165744e96791981981cbdffddd4587fc461 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142740143) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4017)
* b1a5f580d3427b510c94572d79b42ba231492a59 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569622936
<!--
Meta data
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142626733 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142641843 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
-->
## CI report:
* 62027bf514e75e43953585ade0ed57453b9df2f5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142626733) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980)
* 44d60e2a99f9e63e32294e231f405cfcaef2f698 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142641843) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-570136160
@bowenli86 Just rebased and fixed conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#discussion_r361971286
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV100.java
##########
@@ -354,6 +354,9 @@ public CatalogColumnStatisticsDataDate toFlinkDateColStats(ColumnStatisticsData
@Override
public Object toHiveTimestamp(Object flinkTimestamp) {
+ if (flinkTimestamp == null) {
Review comment:
I think we can let `HiveObjectConversion` rely on `HiveShim` to handle nulls. So we don't need the null check in both of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569622936
<!--
Meta data
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142626733 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142641843 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
-->
## CI report:
* 62027bf514e75e43953585ade0ed57453b9df2f5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142626733) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980)
* 44d60e2a99f9e63e32294e231f405cfcaef2f698 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142641843) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#issuecomment-569622936
<!--
Meta data
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:62027bf514e75e43953585ade0ed57453b9df2f5 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142626733 TriggerType:PUSH TriggerID:62027bf514e75e43953585ade0ed57453b9df2f5
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:44d60e2a99f9e63e32294e231f405cfcaef2f698 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142641843 TriggerType:PUSH TriggerID:44d60e2a99f9e63e32294e231f405cfcaef2f698
Hash:57bd2165744e96791981981cbdffddd4587fc461 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142740143 TriggerType:PUSH TriggerID:57bd2165744e96791981981cbdffddd4587fc461
Hash:57bd2165744e96791981981cbdffddd4587fc461 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4017 TriggerType:PUSH TriggerID:57bd2165744e96791981981cbdffddd4587fc461
Hash:b1a5f580d3427b510c94572d79b42ba231492a59 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142845329 TriggerType:PUSH TriggerID:b1a5f580d3427b510c94572d79b42ba231492a59
Hash:b1a5f580d3427b510c94572d79b42ba231492a59 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4037 TriggerType:PUSH TriggerID:b1a5f580d3427b510c94572d79b42ba231492a59
-->
## CI report:
* 62027bf514e75e43953585ade0ed57453b9df2f5 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142626733) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3980)
* 44d60e2a99f9e63e32294e231f405cfcaef2f698 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142641843) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3985)
* 57bd2165744e96791981981cbdffddd4587fc461 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142740143) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4017)
* b1a5f580d3427b510c94572d79b42ba231492a59 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142845329) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4037)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10721: [FLINK-15429][hive] HiveObjectConversion implementations need to hand…
URL: https://github.com/apache/flink/pull/10721#discussion_r361949109
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java
##########
@@ -146,9 +146,9 @@ public static HiveObjectConversion getConversion(ObjectInspector inspector, Logi
} else if (inspector instanceof TimestampObjectInspector) {
conversion = hiveShim::toHiveTimestamp;
} else if (inspector instanceof HiveCharObjectInspector) {
- conversion = o -> new HiveChar((String) o, ((CharType) dataType).getLength());
+ conversion = o -> o == null ? null : new HiveChar((String) o, ((CharType) dataType).getLength());
} else if (inspector instanceof HiveVarcharObjectInspector) {
- conversion = o -> new HiveVarchar((String) o, ((VarCharType) dataType).getLength());
+ conversion = o -> o == null ? null : new HiveVarchar((String) o, ((VarCharType) dataType).getLength());
} else if (inspector instanceof HiveDecimalObjectInspector) {
conversion = o -> o == null ? null : HiveDecimal.create((BigDecimal) o);
} else {
Review comment:
It's not dead code but WritableHiveObjectConversion is currently only used for constant arguments of UDFs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services