You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/04 14:15:27 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #535: feat: refactor apis for existing check and other apis
nic-chen opened a new pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
___
### New feature or improvement
- Describe the details and related test reports.
feat: refactor apis for existing check and other apis
such as:
`/apisix/admin/notexist/upstreams`
`/apisix/admin/names/upstreams`
`/apisix/admin/notexist/routes`
`/apisix/admin/check_ssl_exists`
and so on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-703966592
Please add codecov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-705931099
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-706033238
I will merge this pr.
so that we could move forward.
we could fix other issues later.
@moonming @membphis @juzhiyuan @ShiningRush
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#discussion_r502209694
##########
File path: api/internal/handler/ssl/ssl.go
##########
@@ -54,14 +57,16 @@ func (h *Handler) ApplyRoute(r *gin.Engine) {
wrapper.InputType(reflect.TypeOf(ListInput{}))))
r.POST("/apisix/admin/ssl", wgin.Wraps(h.Create,
wrapper.InputType(reflect.TypeOf(entity.SSL{}))))
- r.POST("/apisix/admin/check_ssl_cert", wgin.Wraps(h.Validate,
- wrapper.InputType(reflect.TypeOf(entity.SSL{}))))
r.PUT("/apisix/admin/ssl/:id", wgin.Wraps(h.Update,
wrapper.InputType(reflect.TypeOf(UpdateInput{}))))
r.PATCH("/apisix/admin/ssl/:id", wgin.Wraps(h.Patch,
wrapper.InputType(reflect.TypeOf(UpdateInput{}))))
- r.DELETE("/apisix/admin/ssl", wgin.Wraps(h.BatchDelete,
+ r.DELETE("/apisix/admin/ssl/:ids", wgin.Wraps(h.BatchDelete,
Review comment:
why we use `ids` here? I think it should be `id`, the singular should be used here.
##########
File path: api/internal/core/entity/query.go
##########
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
Review comment:
ping @nic-chen
##########
File path: api/internal/core/store/query.go
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+// Copyright 2017 The Kubernetes Authors.
Review comment:
ping @moonming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-706032588
@membphis we leave the license issues and fix it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-703636101
This method is not right. What is the license of the original code?
nic-chen <no...@github.com>于2020年10月5日 周一下午9:31写道：
>
>
> *@nic-chen* commented on this pull request.
>
>
>
>
> ------------------------------
>
>
>
>
> In api/internal/core/store/query.go
> <https://github.com/apache/apisix-dashboard/pull/535#discussion_r499599913>
> :
>
>
> > + * Licensed to the Apache Software Foundation (ASF) under one or more
>
> + * contributor license agreements. See the NOTICE file distributed with
>
> + * this work for additional information regarding copyright ownership.
>
> + * The ASF licenses this file to You under the Apache License, Version 2.0
>
> + * (the "License"); you may not use this file except in compliance with
>
> + * the License. You may obtain a copy of the License at
>
> + *
>
> + * http://www.apache.org/licenses/LICENSE-2.0
>
> + *
>
> + * Unless required by applicable law or agreed to in writing, software
>
> + * distributed under the License is distributed on an "AS IS" BASIS,
>
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>
> + * See the License for the specific language governing permissions and
>
> + * limitations under the License.
>
> + */
>
> +// Copyright 2017 The Kubernetes Authors.
>
>
>
> some code copy from Kubernetes dashboard , so i think it's better to keep
> their license. what do you think ? @moonming <https://github.com/moonming>
>
>
>
>
> —
> You are receiving this because you were mentioned.
>
>
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/apisix-dashboard/pull/535#discussion_r499599913>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AGJZBKYXWZRPE5RE5STNBV3SJHDBRANCNFSM4SDXIAEQ>
> .
>
>
> --
Thanks,
Ming Wen
Twitter: _WenMing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-703637526
> This method is not right. What is the license of the original code?
the Apache License, Version 2.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-705999617
@nic-chen what's the code coverage?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-706034228
> I will merge this pr.
> so that we could move forward.
> we could fix other issues later.
>
> @moonming @membphis @juzhiyuan @ShiningRush
please create issues for them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-705999345
we can leave the lincense issues when merge to master. @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#discussion_r502209694
##########
File path: api/internal/handler/ssl/ssl.go
##########
@@ -54,14 +57,16 @@ func (h *Handler) ApplyRoute(r *gin.Engine) {
wrapper.InputType(reflect.TypeOf(ListInput{}))))
r.POST("/apisix/admin/ssl", wgin.Wraps(h.Create,
wrapper.InputType(reflect.TypeOf(entity.SSL{}))))
- r.POST("/apisix/admin/check_ssl_cert", wgin.Wraps(h.Validate,
- wrapper.InputType(reflect.TypeOf(entity.SSL{}))))
r.PUT("/apisix/admin/ssl/:id", wgin.Wraps(h.Update,
wrapper.InputType(reflect.TypeOf(UpdateInput{}))))
r.PATCH("/apisix/admin/ssl/:id", wgin.Wraps(h.Patch,
wrapper.InputType(reflect.TypeOf(UpdateInput{}))))
- r.DELETE("/apisix/admin/ssl", wgin.Wraps(h.BatchDelete,
+ r.DELETE("/apisix/admin/ssl/:ids", wgin.Wraps(h.BatchDelete,
Review comment:
why we use `ids` here? I think it should be `id`, the singular should be used here.
##########
File path: api/internal/core/entity/query.go
##########
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
Review comment:
ping @nic-chen
##########
File path: api/internal/core/store/query.go
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+// Copyright 2017 The Kubernetes Authors.
Review comment:
ping @moonming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-705931099
ping @moonming @ShiningRush @gxthrj @juzhiyuan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] gxthrj commented on a change in pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#discussion_r499469879
##########
File path: api/internal/core/store/query.go
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+// Copyright 2017 The Kubernetes Authors.
Review comment:
are these headers must to be kept ?
##########
File path: api/internal/core/entity/query.go
##########
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
Review comment:
Duplicate header
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-706037507
> > I will merge this pr.
> > so that we could move forward.
> > we could fix other issues later.
> > @moonming @membphis @juzhiyuan @ShiningRush
>
> please create issues for them
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-706039192
Please link this PR in those issues :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen merged pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
nic-chen merged pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-705999345
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-706032151
> @nic-chen what's the code coverage?
you could see in my repo:
https://github.com/nic-chen/incubator-apisix-dashboard/pull/7/checks?check_run_id=1212879646
main code of refactoring:
coverage: 81.3% of statements
github.com/apisix/manager-api/internal/core/store
coverage: 63.3% of statements
github.com/apisix/manager-api/internal/utils
the handlers using api test, so it couldn't calculate coverage correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on a change in pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#discussion_r499509595
##########
File path: api/internal/core/store/selector.go
##########
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+// Copyright 2017 The Kubernetes Authors.
Review comment:
ditto
##########
File path: api/internal/core/store/selector_test.go
##########
@@ -0,0 +1,238 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+// Copyright 2017 The Kubernetes Authors.
Review comment:
ditto
##########
File path: api/internal/core/store/query.go
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+// Copyright 2017 The Kubernetes Authors.
Review comment:
Is this file from Kubernetes repo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#discussion_r499599913
##########
File path: api/internal/core/store/query.go
##########
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+// Copyright 2017 The Kubernetes Authors.
Review comment:
some code copy from Kubernetes dashboard , so i think it's better to keep their license. what do you think ? @moonming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-706039192
Please link this PR in those issues :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535#issuecomment-706044477
> Please link this PR in those issues :D
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen merged pull request #535: feat: refactor apis for existing check and other apis
Posted by GitBox <gi...@apache.org>.
nic-chen merged pull request #535:
URL: https://github.com/apache/apisix-dashboard/pull/535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org