You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/08 03:59:38 UTC
[GitHub] [ozone] kaijchen opened a new pull request, #3491: HDDS-6827. Need proper error message when "RATIS" replication-type is passed with EC codec
kaijchen opened a new pull request, #3491:
URL: https://github.com/apache/ozone/pull/3491
## What changes were proposed in this pull request?
See https://issues.apache.org/jira/browse/HDDS-6827
## How was this patch tested?
Integration test and acceptance test.
Manual test:
```console
$ ./ozone sh bucket create /vol/bkt --type=RATIS --replication=rs-3-2-1024k
rs-3-2-1024k is not supported for RATIS replication type
$ ./ozone sh key put /vol/bkt/key ~/.bashrc --type=RATIS --replication=rs-3-2-1024k
rs-3-2-1024k is not supported for RATIS replication type
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3491: HDDS-6827. Need proper error message when "RATIS" replication-type is passed with EC codec
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3491:
URL: https://github.com/apache/ozone/pull/3491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3491: HDDS-6827. Need proper error message when "RATIS" replication-type is passed with EC codec
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3491:
URL: https://github.com/apache/ozone/pull/3491#discussion_r891954311
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/client/ReplicationConfig.java:
##########
@@ -182,7 +182,12 @@ static ReplicationConfig parseWithoutFallback(ReplicationType type,
try {
factor = ReplicationFactor.valueOf(Integer.parseInt(replication));
} catch (NumberFormatException ex) {
- factor = ReplicationFactor.valueOf(replication);
+ try {
+ factor = ReplicationFactor.valueOf(replication);
+ } catch (IllegalArgumentException e) {
+ throw new IllegalArgumentException(replication +
+ " is not supported for RATIS replication type", e);
Review Comment:
`type` could be `STAND_ALONE`, too.
```suggestion
" is not supported for " + type + " replication type", e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on pull request #3491: HDDS-6827. Need proper error message when "RATIS" replication-type is passed with EC codec
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #3491:
URL: https://github.com/apache/ozone/pull/3491#issuecomment-1149509053
Thanks @adoroszlai for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org