You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/14 01:06:42 UTC
[GitHub] [netbeans] pepness opened a new pull request #3776: Upgrade Commons-Lang3 from 3.8.1 to 3.12.0
pepness opened a new pull request #3776:
URL: https://github.com/apache/netbeans/pull/3776
Library Notes:
- Require Java 8
- Supports Java 17 (in compare methods)
- 53 Bug fixes
- 60 New Features
- 84 Improvements
Testing:
- Full build done
- Verify successful execution of libraries and licenses Ant test
- Verify successful execution of unit tests for module `java/java.lsp.server` (the one that use this library)
- Checked the file is in `{nb_all}/platform/modules/org-apache-commons-lang3.jar`
[Web Page](https://commons.apache.org/proper/commons-lang/)
[Release Notes](https://commons.apache.org/proper/commons-lang/changes-report.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #3776: Upgrade Commons-Lang3 from 3.8.1 to 3.12.0
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #3776:
URL: https://github.com/apache/netbeans/pull/3776#issuecomment-1080965357
The "Export-Packages" are still broken (there are stray commas). I had a look at the generated and source jar and noticed, that the source already holds OSGI manifest entries, so we could apply the same principal to commons-lang3 as was done for bouncy castle and other modules. I.e. we use them verbatim:
```diff
--- a/platform/o.apache.commons.lang3/nbproject/project.properties
+++ b/platform/o.apache.commons.lang3/nbproject/project.properties
@@ -14,4 +14,5 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+release.external/commons-lang3-3.12.0.jar=modules/org-apache-commons-lang3.jar
is.autoload=true
--- a/platform/o.apache.commons.lang3/build.xml
+++ b/platform/o.apache.commons.lang3/build.xml
@@ -21,16 +21,5 @@
-->
<project name="platform/o.apache.commons.lang3" default="build" basedir=".">
<import file="../../nbbuild/templates/projectized.xml"/>
- <target name="jar" depends="-define-FileCRC32Calculator">
- <FileCRC32Calculator file="external/commons-lang3-3.12.0.jar" property="o.apache.commons.lang3.crc32" />
- <jar jarfile="${cluster}/${module.jar}">
- <zipfileset src="external/commons-lang3-3.12.0.jar"/>
- <manifest>
- <attribute name="Bundle-SymbolicName" value="org.apache.commons.lang3"/>
- <attribute name="Bundle-Version" value="3.12.0"/>
- <attribute name="Export-Package" value="Export-Package: org.apache.commons.lang3;version="3.12.0",org.apache.commons.lang3.arch;version="3.12.0",org.apache.commons.lang3.builder;v ersion="3.12.0",org.apache.commons.lang3.compare;version="3.12.0",org.apache.commons.lang3.concurrent;version="3.12.0",org.apache.commons. lang3.concurrent.locks;version="3.12.0",org.apache.commons.lang3.event;version="3.12.0",org.apache.commons.lang3.exception;version="3.12.0 ",org.apache.commons.lang3.function;version="3.12.0",org.apache.commons.lang3.math;version="3.12.0",org.apache.commons.lang3.mutable;version="3.12.0",org.apache.commons.lang3.reflect;version="3.12.0",org.apa che.commons.lang3.stream;version="3.12.0",org.apache.commons.lang3.text;version="3.12.0",org.apache.commons.lang3.text.translate;version="3.12.0",org.apache.commo
ns.lang3.time;version="3.12.0",org.apache.commons.lang3.tuple;version="3.12.0""/>
- <attribute name="NB-Original-CRC" value="${o.apache.commons.lang3.crc32}"/>
- </manifest>
- </jar>
- </target>
+ <target name="jar"/>
</project>
```
This simplifies the build, removes magic and is more in line with the rest of the codebase. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists