You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/15 09:21:18 UTC
[GitHub] [airflow] dstandish opened a new pull request #9303: Focus upstream / downstream task dependencies on mouseover
dstandish opened a new pull request #9303:
URL: https://github.com/apache/airflow/pull/9303
**note:** assumes #9297 will be merged
**Summary**
We currently support focusing on upstream / downstream task dependencies in a mild way, namely by changing the color.
When you have a big messy dag, though, more aggressive focusing is desirable.
In this PR we implement an approach similar to the approach used when focusing on a task state or when using the search function --- namely, we set opacity=0.2 on tasks and paths which are not directly upstream or downstream.
Here's a screenshot when the mouse is over dummy 3:
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #9303: Focus upstream / downstream task dependencies on mouseover
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #9303:
URL: https://github.com/apache/airflow/pull/9303#issuecomment-647068976
@feluelle what do you think about expanding this a bit, so that we highlight not just immediate upstream / downstream, but everything in the chain.
so, highlight the immediate upstream tasks, but also the upstream of those upstream tasks. and same with downstream.
i think this might be better, so that for any task, you can see everything it depends on, and everything that depends on it. and then everything else is de-focused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #9303: Focus upstream / downstream task dependencies on mouseover
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #9303:
URL: https://github.com/apache/airflow/pull/9303#issuecomment-644013993
Can you also include a before screenshot for comparison?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish removed a comment on pull request #9303: Focus upstream / downstream task dependencies on mouseover
Posted by GitBox <gi...@apache.org>.
dstandish removed a comment on pull request #9303:
URL: https://github.com/apache/airflow/pull/9303#issuecomment-647068976
@feluelle what do you think about expanding this a bit, so that we highlight not just immediate upstream / downstream, but everything in the chain.
so, highlight the immediate upstream tasks, but also the upstream of those upstream tasks. and same with downstream.
i think this might be better, so that for any task, you can see everything it depends on, and everything that depends on it. and then everything else is de-focused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #9303: Focus upstream / downstream task dependencies on mouseover
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #9303:
URL: https://github.com/apache/airflow/pull/9303#issuecomment-644029392
@ashb i updated it to remove one line that did not need to be there
also, i fixed the colors in the screenshot. unrelated to this change i had the upstream downstream colors changed locally and that could have caused confusion (and probably did).
thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #9303: Focus upstream / downstream task dependencies on mouseover
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #9303:
URL: https://github.com/apache/airflow/pull/9303#issuecomment-644021559
> Can you also include a before screenshot for comparison?
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #9303: Focus upstream / downstream task dependencies on mouseover
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #9303:
URL: https://github.com/apache/airflow/pull/9303#issuecomment-666645785
thanks @feluelle
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle merged pull request #9303: Focus upstream / downstream task dependencies on mouseover
Posted by GitBox <gi...@apache.org>.
feluelle merged pull request #9303:
URL: https://github.com/apache/airflow/pull/9303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org