[jira] Commented: (HIVE-86) drop table should not delete data for external tables

["Joydeep Sen Sarma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652660#action_12652660 ] 

Joydeep Sen Sarma commented on HIVE-86:
---------------------------------------

thx! Patch looks pretty good.

Couple of concerns:
- i think we can just have one version of the isExternal command. The ql/.../Table.java has a metastore.api.Table object - and we can have an isExternal definition over that which can be shared in both places.
- other concern is that the isExternal setting is being checked by the client side code. it seems to me that the server side should be enforcing this setting (otherwise any thrift client can come and delete data based on the thrift api regardless of the external setting). So we should (as a safety measure) be enforcing this check in HiveMetaStore.java:drop_table as well (regardless of the delete_data setting.)

regarding RWTable versus HiveMetaStoreClient - sorry for all the confusion. The thing is that there are two implementations of the MetaStore available - one db backed which is the new one that we use normally. There is an old one that's file based and RWTable is used by that one (AFAIK).

> drop table should not delete data for external tables
> -----------------------------------------------------
>
>                 Key: HIVE-86
>                 URL: https://issues.apache.org/jira/browse/HIVE-86
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Joydeep Sen Sarma
>            Priority: Critical
>         Attachments: HIVE-86.patch
>
>
> We should not delete data for external tables.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.