You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/28 04:45:33 UTC

[GitHub] [pulsar] nodece opened a new pull request, #16834: [fix][proxy] Fix client service url

nodece opened a new pull request, #16834:
URL: https://github.com/apache/pulsar/pull/16834

   Signed-off-by: Zixuan Liu <no...@gmail.com>
   
   ### Motivation
   
   When the TLS is enabled, the client always uses the non-TLS URL.
   
   ### Modifications
   
   - Add check whether using the TLS URL
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16834: [fix][proxy] Fix client service url

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #16834:
URL: https://github.com/apache/pulsar/pull/16834#issuecomment-1199654510

   @nodece Please provide a correct documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- merged pull request #16834: [fix][proxy] Fix client service url

Posted by GitBox <gi...@apache.org>.

Technoboy- merged PR #16834:
URL: https://github.com/apache/pulsar/pull/16834


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Technoboy- commented on pull request #16834: [fix][proxy] Fix client service url

Posted by GitBox <gi...@apache.org>.

Technoboy- commented on PR #16834:
URL: https://github.com/apache/pulsar/pull/16834#issuecomment-1198952363

   > @nodece Please add unit test to avoid any changes to break here.
   
   Added since your last review, so merged. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #16834: [fix][proxy] Fix client service url

Posted by GitBox <gi...@apache.org>.

nodece commented on PR #16834:
URL: https://github.com/apache/pulsar/pull/16834#issuecomment-1197979501

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16834: [fix][proxy] Fix client service url

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #16834:
URL: https://github.com/apache/pulsar/pull/16834#issuecomment-1198799532

   @nodece Please provide a correct documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16834: [fix][proxy] Fix client service url

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #16834:
URL: https://github.com/apache/pulsar/pull/16834#issuecomment-1198807020

   @nodece Please provide a correct documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #16834: [fix][proxy] Fix client service url

Posted by GitBox <gi...@apache.org>.

nodece commented on PR #16834:
URL: https://github.com/apache/pulsar/pull/16834#issuecomment-1198994802

   > @nodece Please add unit test to avoid any changes to break here.
   
   Thanks! Done.
   
   
   > Added after your comment, so merged.
   
   Thank @Technoboy- for merging this PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nodece commented on pull request #16834: [fix][proxy] Fix client service url

Posted by GitBox <gi...@apache.org>.

nodece commented on PR #16834:
URL: https://github.com/apache/pulsar/pull/16834#issuecomment-1200663478

   Remove `release/2.7.5` label by #16894.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org