You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2017/12/15 11:41:12 UTC
Review Request 64647: Updated tests related to containerizer
refactoring.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64647/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
Repository: mesos
Description
-------
This patch is needed due to changes in Containerizer interface,
where `wait()`, `destroy()` and `kill()` methods return the same
ContainerTermination type.
Diffs
-----
src/tests/containerizer.hpp d6a69d6327018065453f8a6cb275d921d10c9198
src/tests/containerizer.cpp 13a290ff60e359ceced95b20cb9db8c25cd59dbc
src/tests/containerizer/composing_containerizer_tests.cpp 7c22f162b128c3fdf8d4b20cac73fdf442449d79
src/tests/containerizer/docker_containerizer_tests.cpp 630bb2e352dd55ecb401730c84f823e0a1f2d310
src/tests/containerizer/io_switchboard_tests.cpp f217d02bba2d1372392ad4da521940d27e4f69d4
src/tests/containerizer/mesos_containerizer_tests.cpp 0729464a7a9b290c8634536e58909f9b38b58a9c
src/tests/containerizer/mock_containerizer.hpp 01c617a55899a7125ca1dc80091aef5603419ee8
Diff: https://reviews.apache.org/r/64647/diff/1/
Testing
-------
make check (fedora 25)
internal CI
Thanks,
Andrei Budnik
Re: Review Request 64647: Updated tests related to containerizer
refactoring.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64647/#review194186
-----------------------------------------------------------
PASS: Mesos patch 64647 was successfully built and tested.
Reviews applied: `['64646', '64647']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64647
- Mesos Reviewbot Windows
On Dec. 15, 2017, 11:41 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64647/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2017, 11:41 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch is needed due to changes in Containerizer interface,
> where `wait()`, `destroy()` and `kill()` methods return the same
> ContainerTermination type.
>
>
> Diffs
> -----
>
> src/tests/containerizer.hpp d6a69d6327018065453f8a6cb275d921d10c9198
> src/tests/containerizer.cpp 13a290ff60e359ceced95b20cb9db8c25cd59dbc
> src/tests/containerizer/composing_containerizer_tests.cpp 7c22f162b128c3fdf8d4b20cac73fdf442449d79
> src/tests/containerizer/docker_containerizer_tests.cpp 630bb2e352dd55ecb401730c84f823e0a1f2d310
> src/tests/containerizer/io_switchboard_tests.cpp f217d02bba2d1372392ad4da521940d27e4f69d4
> src/tests/containerizer/mesos_containerizer_tests.cpp 0729464a7a9b290c8634536e58909f9b38b58a9c
> src/tests/containerizer/mock_containerizer.hpp 01c617a55899a7125ca1dc80091aef5603419ee8
>
>
> Diff: https://reviews.apache.org/r/64647/diff/2/
>
>
> Testing
> -------
>
> make check (fedora 25)
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 64647: Updated tests related to containerizer
refactoring.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64647/#review193908
-----------------------------------------------------------
FAIL: Some Mesos tests failed.
Reviews applied: `['64646', '64647']`
Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64647
Relevant logs:
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64647/logs/mesos-tests-stdout.log):
```
[----------] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2347 ms)
[----------] 1 test from IsolationFlag/CpuIsolatorTest (2371 ms total)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2387 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (2412 ms total)
[----------] Global test environment tear-down
[==========] 835 tests from 85 test cases ran. (310277 ms total)
[ PASSED ] 825 tests.
[ FAILED ] 10 tests, listed below:
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[ FAILED ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[ FAILED ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[ FAILED ] OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[ FAILED ] OfferOperationStatusUpdateManagerTest.UpdateLatestWhenResending
10 FAILED TESTS
YOU HAVE 205 DISABLED TESTS
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64647/logs/mesos-tests-stderr.log):
```
I1215 12:39:59.617643 932 master.cpp:10160] Updating the state of task 53c795f0-ad32-4dd4-909f-455fe21f5a56 of framework e01de3d2-6354-424f-8488-41321d48a48b-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1215 12:39:59.617643 2500 slave.cpp:3401] Shutting down framework e01de3d2-6354-424f-8488-41321d48a48b-0000
I1215 12:39:59.617643 2500 slave.cpp:6109] Shutting down executor '53c795f0-ad32-4dd4-909f-455fe21f5a56' of framework e01de3d2-6354-424f-8488-41321d48a48b-0000 at executor(1)@10.3.1.11:63008
I1215 12:39I1215 12:39:58.958652 3876 exec.cpp:162] Version: 1.5.0
I1215 12:39:58.982682 6908 exec.cpp:237] Executor registered on agent e01de3d2-6354-424f-8488-41321d48a48b-S0
I1215 12:39:58.985682 4776 executor.cpp:171] Received SUBSCRIBED event
I1215 12:39:58.990675 4776 executor.cpp:175] Subscribed executor on build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1215 12:39:58.990675 4776 executor.cpp:171] Received LAUNCH event
I1215 12:39:58.994653 4776 executor.cpp:638] Starting task 53c795f0-ad32-4dd4-909f-455fe21f5a56
I1215 12:39:59.069672 4776 executor.cpp:478] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>'
I1215 12:39:59.592644 4776 executor.cpp:651] Forked command at 5760
I1215 12:39:59.619763 3808 exec.cpp:435] Executor asked to shutdown
I1215 12:39:59.620645 2768 executor.cpp:171] Received SHUTDOWN event
I1215 12:39:59.620645 2768 executor.cpp:748] Shutting down
I1215 12:39:59.620645 2768 executor.cpp:855] Sending SIGTERM to process tree at pid 5:59.618643 2500 slave.cpp:909] Agent terminating
W1215 12:39:59.618643 2500 slave.cpp:3397] Ignoring shutdown framework e01de3d2-6354-424f-8488-41321d48a48b-0000 because it is terminating
I1215 12:39:59.619763 932 master.cpp:10266] Removing task 53c795f0-ad32-4dd4-909f-455fe21f5a56 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework e01de3d2-6354-424f-8488-41321d48a48b-0000 on agent e01de3d2-6354-424f-8488-41321d48a48b-S0 at slave(327)@10.3.1.11:62987 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 12:39:59.621644 2980 containerizer.cpp:2338] Destroying container 0dcb73de-50b5-487e-9549-f61ee34010f8 in RUNNING state
I1215 12:39:59.622643 2980 containerizer.cpp:2945] Transitioning the state of container 0dcb73de-50b5-487e-9549-f61ee34010f8 from RUNNING to DESTROYING
I1215 12:39:59.622643 932 master.cpp:1305] Agent e01de3d2-6354-424f-8488-41321d48a48b-S0 at slave(327)@10.3.1.11:62987 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1215 12:39:59.622643 932 master.cpp:3364] Disconnecting agent e01de3d2-6354-424f-8488-41321d48a48b-S0 at slave(327)@10.3.1.11:62987 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 12:39:59.622643 2980 launcher.cpp:156] Asked to destroy container 0dcb73de-50b5-487e-9549-f61ee34010f8
I1215 12:39:59.622643 932 master.cpp:3383] Deactivating agent e01de3d2-6354-424f-8488-41321d48a48b-S0 at slave(327)@10.3.1.11:62987 (build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1215 12:39:59.623643 1932 hierarchical.cpp:344] Removed framework e01de3d2-6354-424f-8488-41321d48a48b-0000
I1215 12:39:59.623643 1932 hierarchical.cpp:766] Agent e01de3d2-6354-424f-8488-41321d48a48b-S0 deactivated
I1215 12:39:59.724721 2980 containerizer.cpp:2794] Container 0dcb73de-50b5-487e-9549-f61ee34010f8 has exited
I1215 12:39:59.753743 792 master.cpp:1147] Master terminating
I1215 12:39:59.756752 7924 hierarchical.cpp:609] Removed agent e01de3d2-6354-424f-8488-41321d48a48b-S0
I1215 12:40:00.063761 8204 process.cpp:887] Failed to accept socket: future discarded
```
- Mesos Reviewbot Windows
On Dec. 15, 2017, 11:41 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64647/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2017, 11:41 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch is needed due to changes in Containerizer interface,
> where `wait()`, `destroy()` and `kill()` methods return the same
> ContainerTermination type.
>
>
> Diffs
> -----
>
> src/tests/containerizer.hpp d6a69d6327018065453f8a6cb275d921d10c9198
> src/tests/containerizer.cpp 13a290ff60e359ceced95b20cb9db8c25cd59dbc
> src/tests/containerizer/composing_containerizer_tests.cpp 7c22f162b128c3fdf8d4b20cac73fdf442449d79
> src/tests/containerizer/docker_containerizer_tests.cpp 630bb2e352dd55ecb401730c84f823e0a1f2d310
> src/tests/containerizer/io_switchboard_tests.cpp f217d02bba2d1372392ad4da521940d27e4f69d4
> src/tests/containerizer/mesos_containerizer_tests.cpp 0729464a7a9b290c8634536e58909f9b38b58a9c
> src/tests/containerizer/mock_containerizer.hpp 01c617a55899a7125ca1dc80091aef5603419ee8
>
>
> Diff: https://reviews.apache.org/r/64647/diff/1/
>
>
> Testing
> -------
>
> make check (fedora 25)
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 64647: Updated tests related to containerizer
refactoring.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64647/#review194331
-----------------------------------------------------------
PASS: Mesos patch 64647 was successfully built and tested.
Reviews applied: `['64646', '64647']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64647
- Mesos Reviewbot Windows
On Dec. 15, 2017, 11:41 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64647/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2017, 11:41 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Gilbert Song, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch is needed due to changes in Containerizer interface,
> where `wait()`, `destroy()` and `kill()` methods return the same
> ContainerTermination type.
>
>
> Diffs
> -----
>
> src/tests/containerizer.hpp d6a69d6327018065453f8a6cb275d921d10c9198
> src/tests/containerizer.cpp 13a290ff60e359ceced95b20cb9db8c25cd59dbc
> src/tests/containerizer/composing_containerizer_tests.cpp 7c22f162b128c3fdf8d4b20cac73fdf442449d79
> src/tests/containerizer/docker_containerizer_tests.cpp 630bb2e352dd55ecb401730c84f823e0a1f2d310
> src/tests/containerizer/io_switchboard_tests.cpp f217d02bba2d1372392ad4da521940d27e4f69d4
> src/tests/containerizer/mesos_containerizer_tests.cpp 0729464a7a9b290c8634536e58909f9b38b58a9c
> src/tests/containerizer/mock_containerizer.hpp 01c617a55899a7125ca1dc80091aef5603419ee8
>
>
> Diff: https://reviews.apache.org/r/64647/diff/3/
>
>
> Testing
> -------
>
> make check (fedora 25)
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>