You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Madhan Neethiraj <ma...@apache.org> on 2020/08/01 06:11:02 UTC
Re: Review Request 72646: ATLAS-3876 : Relationship Search API not
showing correct approximateCount
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72646/#review221445
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java
Lines 1523 (patched)
<https://reviews.apache.org/r/72646/#comment310458>
This handles edge attributes of string type. Consider handling other datatypes as well in a subsequent patch.
An implementaiton similar to vertex-attribute predicate #226 - #271, which uses VertexAttributePredicateGenerator; perhaps, introducing EdgeAttributePredicateGenerator will be useful.
- Madhan Neethiraj
On July 31, 2020, 12:43 p.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72646/
> -----------------------------------------------------------
>
> (Updated July 31, 2020, 12:43 p.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3876
> https://issues.apache.org/jira/browse/ATLAS-3876
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Issue:**
> Relationship api doesn't provide approximate count of the related entities in the response.
>
> **Workaround:**
> Get the total count of related given entity , irrespective of the offset/limit.
> Added 'getApproximateCount' as queryParam in Rest api.
>
>
> Also this patch includes **improvement in the time taken to fetch related entities** .
> Average time taken for the Api to search relationship entities having **5000 end vertices** with limit **500**:
> Before : 9seconds
> After applying this patch : 3seconds
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc47
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee4589f
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 86572598a
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 4b9564295
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 863a00350
> repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 5069d78c8
> webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java cdeb912a4
>
>
> Diff: https://reviews.apache.org/r/72646/diff/4/
>
>
> Testing
> -------
>
> Manually tested
> Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2011 (Failed in Impala build)
>
>
> Thanks,
>
> Pinal Shah
>
>