You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/11 00:05:49 UTC
[GitHub] [incubator-superset] ktmud opened a new issue #11651: [Nav] Menu item margins in Settings menu looks kind of random
ktmud opened a new issue #11651:
URL: https://github.com/apache/incubator-superset/issues/11651
## Screenshot
<img src="https://user-images.githubusercontent.com/335541/98748336-48d18f00-236e-11eb-884f-bc734f4cf152.png" width="200">
## Description
1. There should be more space around dividers
2. There should be space between the bottom and the last menu item
## Design input
[describe any input/collaboration you'd like from designers, and
tag accordingly. For design review, add the
label `design:review`. If this includes a design proposal,
include the label `design:suggest`]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #11651: [Nav] Menu item margins in Settings menu looks kind of random
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #11651:
URL: https://github.com/apache/incubator-superset/issues/11651#issuecomment-725042550
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.64. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc closed issue #11651: [Nav] Menu item height in Settings menu looks kind of random
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #11651:
URL: https://github.com/apache/incubator-superset/issues/11651
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje edited a comment on issue #11651: [Nav] Menu item height in Settings menu looks kind of random
Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on issue #11651:
URL: https://github.com/apache/incubator-superset/issues/11651#issuecomment-726661148
@ktmud Do you think that looks better? I decreased margin for item group title and increased margin for the last element of item group.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on issue #11651: [Nav] Menu item height in Settings menu looks kind of random
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #11651:
URL: https://github.com/apache/incubator-superset/issues/11651#issuecomment-726661148
@ktmud Do you think that looks better? I decreased margin for item group title and increased margin for the last element of item group.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #11651: [Nav] Menu item height in Settings menu looks kind of random
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #11651:
URL: https://github.com/apache/incubator-superset/issues/11651#issuecomment-726895194
Looks good! Thanks for taking on this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org