You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/22 19:24:02 UTC
[GitHub] [arrow] pitrou opened a new pull request, #14704: DRAFT: [C++] Avoid running complex constructors at library load
pitrou opened a new pull request, #14704:
URL: https://github.com/apache/arrow/pull/14704
Initialization order of module globals is undefined.
In a particular case, the IO thread pool would first be instantiated, registering an at-fork handler. Then, only after, the at-fork handlers would be initialized, losing the handler registered just before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14704: DRAFT: [C++] Avoid running complex constructors at library load
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14704:
URL: https://github.com/apache/arrow/pull/14704#issuecomment-1324144704
Revision: 89398df51ddf51af829dcf91a962a29cc228acf4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-bc3b5dd7b6](https://github.com/ursacomputing/crossbow/branches/all?query=actions-bc3b5dd7b6)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/tree/actions-bc3b5dd7b6-github-test-alpine-linux-cpp)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/3526470388/jobs/5914431873)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3526466770/jobs/5914424235)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/9649860210)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3526470903/jobs/5914432911)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3526468753/jobs/5914428454)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/3526468300/jobs/5914427494)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3526467174/jobs/5914425012)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/3526473313/jobs/5914438057)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3526469277/jobs/5914429383)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3526467737/jobs/5914426224)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/3526471622/jobs/5914434383)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/3526467958/jobs/5914426770)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3526470072/jobs/5914431180)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/3526471304/jobs/5914433567)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/3526466388/jobs/5914423549)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/3526469602/jobs/5914430108)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3526472536/jobs/5914436376)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #14704: ARROW-18383: [C++] Avoid global variables for thread pools and at-fork handlers
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14704:
URL: https://github.com/apache/arrow/pull/14704#issuecomment-1327222678
Benchmark runs are scheduled for baseline = 1121bbcf2ee6b7252a7bcd7f82dba8cbab343cb0 and contender = b1f65ea44bf080c9d47d4caa9a259a23c5af8564. b1f65ea44bf080c9d47d4caa9a259a23c5af8564 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b6c166ad9a9b4ec1ba9f595cc14b9dc8...3891bf0a1f634168a0cfe94aaad3685f/)
[Finished :arrow_down:0.13% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/9818ebe6748f43058ec071d55462d810...0db41d8ada3349688c5ffb90922ec2bb/)
[Failed] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c591af89b75b4eeca6a9ac2fcdee479f...ae3b5858951548bd91da30fd29dc48fc/)
[Finished :arrow_down:0.38% :arrow_up:0.07%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/7dee995a39464d7c8ff9b3ccf9fb9558...f7143b54afee4f2d8201ce7fbc5056d4/)
Buildkite builds:
[Finished] [`b1f65ea4` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1919)
[Finished] [`b1f65ea4` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1941)
[Finished] [`b1f65ea4` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1911)
[Finished] [`b1f65ea4` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1933)
[Finished] [`1121bbcf` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1918)
[Finished] [`1121bbcf` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1940)
[Failed] [`1121bbcf` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1910)
[Finished] [`1121bbcf` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1932)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #14704: DRAFT: [C++] Avoid running complex constructors at library load
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #14704:
URL: https://github.com/apache/arrow/pull/14704#issuecomment-1324167192
I checked my little to R process forking reprex from #14250 (`mclapply()`) against this Arrow build and it works!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14704: ARROW-18383: [C++] Avoid global variables for thread pools and at-fork handlers
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14704:
URL: https://github.com/apache/arrow/pull/14704#issuecomment-1324319950
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14704: DRAFT: [C++] Avoid running complex constructors at library load
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14704:
URL: https://github.com/apache/arrow/pull/14704#issuecomment-1324142119
@paleolimbot This seems to fix the R issues with `mclapply` you discovered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou merged pull request #14704: ARROW-18383: [C++] Avoid global variables for thread pools and at-fork handlers
Posted by GitBox <gi...@apache.org>.
pitrou merged PR #14704:
URL: https://github.com/apache/arrow/pull/14704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14704: DRAFT: [C++] Avoid running complex constructors at library load
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14704:
URL: https://github.com/apache/arrow/pull/14704#issuecomment-1324141053
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14704: ARROW-18383: [C++] Avoid global variables for thread pools and at-fork handlers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14704:
URL: https://github.com/apache/arrow/pull/14704#issuecomment-1324324956
Revision: be52dbc3dc78b9abeb6c310d15f8a0ba71f5bcc3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c54517457f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c54517457f)
|Task|Status|
|----|------|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/tree/actions-c54517457f-github-test-alpine-linux-cpp)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/3527592648/jobs/5916825335)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3527594452/jobs/5916829397)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/9653033930)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3527593701/jobs/5916827899)|
|test-debian-10-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3527591208/jobs/5916822413)|
|test-debian-10-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/3527588273/jobs/5916816425)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/3527590769/jobs/5916821629)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/3527590081/jobs/5916820096)|
|test-fedora-35-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3527592947/jobs/5916826165)|
|test-ubuntu-18.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3527589145/jobs/5916818035)|
|test-ubuntu-18.04-cpp-release|[](https://github.com/ursacomputing/crossbow/actions/runs/3527589733/jobs/5916819236)|
|test-ubuntu-18.04-cpp-static|[](https://github.com/ursacomputing/crossbow/actions/runs/3527589476/jobs/5916818811)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3527591605/jobs/5916823100)|
|test-ubuntu-20.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/3527592055/jobs/5916824064)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/3527593301/jobs/5916826990)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/3527594762/jobs/5916830106)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/3527592415/jobs/5916824787)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #14704: DRAFT: [C++] Avoid running complex constructors at library load
Posted by GitBox <gi...@apache.org>.
pitrou commented on PR #14704:
URL: https://github.com/apache/arrow/pull/14704#issuecomment-1324141394
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14704: ARROW-18383: [C++] Avoid global variables for thread pools and at-fork handlers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14704:
URL: https://github.com/apache/arrow/pull/14704#issuecomment-1324319892
https://issues.apache.org/jira/browse/ARROW-18383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #14704: ARROW-18383: [C++] Avoid global variables for thread pools and at-fork handlers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14704:
URL: https://github.com/apache/arrow/pull/14704#issuecomment-1324319947
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org