You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/03/26 04:05:31 UTC

[GitHub] [orc] wgtmac commented on pull request #669: ORC-773: BinaryColumnWriter does not update Bloom filter

wgtmac commented on pull request #669:
URL: https://github.com/apache/orc/pull/669#issuecomment-807920247


   Thanks for pinning me @pgaref !   The change is pretty clean. Thanks @noirello for contributing!
   
   I haven't implemented this in the C++ BinaryColumnWriter because the created BloomFilter is not used on the reader side: https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java#L741 . I am not sure if there is any valid case where literals of binary type appear in the predicate. If that is valid, we should also include the fix on the reader side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org