[jira] Commented: (FELIX-2176) Upgrade maven-bundle-plugin to up to date bnd

["Guillaume Nodet (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843988#action_12843988 ] 

Guillaume Nodet commented on FELIX-2176:
----------------------------------------

I'm trying to understand how some commented code affects the generated manifest.
For example the PackageVersionAnalyzer is now commented, so it may affect  FELIX-1501, but I can't even reproduce that one.

> Upgrade maven-bundle-plugin to up to date bnd
> ---------------------------------------------
>
>                 Key: FELIX-2176
>                 URL: https://issues.apache.org/jira/browse/FELIX-2176
>             Project: Felix
>          Issue Type: Bug
>          Components: Maven Bundle Plugin
>    Affects Versions: maven-bundle-plugin-2.0.1
>            Reporter: David Jencks
>             Fix For: maven-bundle-plugin-2.1.0
>
>         Attachments: FELIX-2176.diff
>
>
> Peter doesn't seem to release bnd to public repos, but does have an accessible private repo.  The bundle plugin can copy bnd into itself so users don't have to have peter's secret stash configured in their nexus repo manager.
> Patch does this and upgrades to latest bnd.  I can't see any reason to keep the copied Builder source -- plugin passes tests and appears to work without it -- so I removed it.  You'll need to run
> svn rm    src/main/java/aQute/lib/osgi/Builder.java
> Also the code in   src/main/java/org/apache/felix/bundleplugin/PackageVersionAnalyzer.java _really_ doesn't compile any more and I suspect the functionality has moved into bnd.  However I can't actually tell what its trying to do; I commented it out.  If this functionality is actually in bnd then removing the class would be a good idea.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.