You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2023/08/10 15:40:20 UTC
[GitHub] [spark] andygrove opened a new pull request, #42433: [WIP][SPARK-43063][SQL][FOLLOWUP] Add a space between -> and value in codegen when first value is null
andygrove opened a new pull request, #42433:
URL: https://github.com/apache/spark/pull/42433
As noted by @cloud-fan [here](https://github.com/apache/spark/pull/41432#discussion_r1242593592), https://github.com/apache/spark/pull/41432 fixed a formatting issue when casting map to string but did not fix it in the codegen case.
The fix is a one-liner, but I am not sure how to add a unit test for this and could use some guidance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] andygrove commented on pull request #42433: [WIP][SPARK-43063][SQL][FOLLOWUP] Add a space between -> and value in codegen when first value is null
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #42433:
URL: https://github.com/apache/spark/pull/42433#issuecomment-1673534099
This isn't the correct fix. Will reopen once working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] andygrove closed pull request #42433: [WIP][SPARK-43063][SQL][FOLLOWUP] Add a space between -> and value in codegen when first value is null
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed pull request #42433: [WIP][SPARK-43063][SQL][FOLLOWUP] Add a space between -> and value in codegen when first value is null
URL: https://github.com/apache/spark/pull/42433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] andygrove commented on pull request #42433: [WIP][SPARK-43063][SQL][FOLLOWUP] Add a space between -> and value in codegen when first value is null
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #42433:
URL: https://github.com/apache/spark/pull/42433#issuecomment-1673705849
reoponed as https://github.com/apache/spark/pull/42434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org