You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "dockerzhang (via GitHub)" <gi...@apache.org> on 2023/06/01 09:28:01 UTC
[GitHub] [inlong] dockerzhang commented on a diff in pull request #8133: [INLONG-8132][DataProxy] Fix Golang SDK typo errors in readme.md and …
dockerzhang commented on code in PR #8133:
URL: https://github.com/apache/inlong/pull/8133#discussion_r1212863219
##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/README.md:
##########
@@ -72,22 +84,20 @@ func (f mapFlag) Set(value string) error {
func main() {
addCols = make(map[string]string)
- flag.StringVar(&set, "set", "SH_IEG", "dataproxy set")
- flag.StringVar(&url, "url", dataproxy.DefaultURL, "dataproxy URL")
- flag.StringVar(&groupID, "group-id", "b_ieg_tglogv3_test", "dataproxy group ID")
- flag.StringVar(&streamID, "stream-id", "GameSvrState", "dataproxy stream ID")
- flag.StringVar(&payload, "payload", "GameSvrState|GameSvrId-Test|2023-01-11 10:08:30|127.0.0.1|1", "message payload")
+ flag.StringVar(&url, "url", "http://127.0.0.1:8083/inlong/manager/openapi/dataproxy/getIpList", "DataProxy Manager URL")
Review Comment:
DataProxy Manager URL
->
the Manager URL
##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/README.md:
##########
@@ -22,9 +22,23 @@ dataproxy-sdk-golang is the golang version of InLong DataProxy client SDK.
### example
-refer: cli/main.go
-
``` go
+//
Review Comment:
License header is not needed.
##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/README.md:
##########
@@ -72,22 +84,20 @@ func (f mapFlag) Set(value string) error {
func main() {
addCols = make(map[string]string)
- flag.StringVar(&set, "set", "SH_IEG", "dataproxy set")
- flag.StringVar(&url, "url", dataproxy.DefaultURL, "dataproxy URL")
- flag.StringVar(&groupID, "group-id", "b_ieg_tglogv3_test", "dataproxy group ID")
- flag.StringVar(&streamID, "stream-id", "GameSvrState", "dataproxy stream ID")
- flag.StringVar(&payload, "payload", "GameSvrState|GameSvrId-Test|2023-01-11 10:08:30|127.0.0.1|1", "message payload")
+ flag.StringVar(&url, "url", "http://127.0.0.1:8083/inlong/manager/openapi/dataproxy/getIpList", "DataProxy Manager URL")
+ flag.StringVar(&groupID, "group-id", "test_pusar_group", "DataProxy group ID")
Review Comment:
DataProxy group ID
->
Group ID
##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/dataproxy/options.go:
##########
@@ -33,16 +33,15 @@ const (
)
var (
- // DefaultURL is the default URL of the DataProxy service registry from where a discoverer can get DataProxy endpoints
+ // DefaultURL is the default URL of the DataProxy Manager from where a discoverer can get DataProxy endpoints
DefaultURL = "http://127.0.0.1:8083/inlong/manager/openapi/dataproxy/getIpList"
localIP, _ = util.GetFirstPrivateIP()
)
// Options is the DataProxy go client configs
type Options struct {
- Set string // the set name of the server
GroupID string // InLong group ID
- URL string // URL where the discoverer to get the endpoint list of the server
+ URL string // Manager URL from where the discoverer to get the endpoint list of a DataProxy cluster
Review Comment:
The Manager URL for discovering the DataProxy cluster
##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/README.md:
##########
@@ -72,22 +84,20 @@ func (f mapFlag) Set(value string) error {
func main() {
addCols = make(map[string]string)
- flag.StringVar(&set, "set", "SH_IEG", "dataproxy set")
- flag.StringVar(&url, "url", dataproxy.DefaultURL, "dataproxy URL")
- flag.StringVar(&groupID, "group-id", "b_ieg_tglogv3_test", "dataproxy group ID")
- flag.StringVar(&streamID, "stream-id", "GameSvrState", "dataproxy stream ID")
- flag.StringVar(&payload, "payload", "GameSvrState|GameSvrId-Test|2023-01-11 10:08:30|127.0.0.1|1", "message payload")
+ flag.StringVar(&url, "url", "http://127.0.0.1:8083/inlong/manager/openapi/dataproxy/getIpList", "DataProxy Manager URL")
+ flag.StringVar(&groupID, "group-id", "test_pusar_group", "DataProxy group ID")
+ flag.StringVar(&streamID, "stream-id", "test_pusar_stream", "DataProxy stream ID")
Review Comment:
DataProxy stream ID
->
Stream ID
##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/dataproxy/options.go:
##########
@@ -33,16 +33,15 @@ const (
)
var (
- // DefaultURL is the default URL of the DataProxy service registry from where a discoverer can get DataProxy endpoints
+ // DefaultURL is the default URL of the DataProxy Manager from where a discoverer can get DataProxy endpoints
Review Comment:
The Manager URL for discovering the DataProxy cluster
##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/README.md:
##########
@@ -136,14 +146,13 @@ func wait() {
### Options
-refer: dataproxy/options.go
+refer: [options.go](dataproxy/options.go)
``` go
// Options is the DataProxy go client configs
type Options struct {
- Set string // the set name of the server
GroupID string // InLong group ID
- URL string // URL where the discoverer to get the endpoint list of the server
+ URL string // Manager URL from where the discoverer to get the endpoint list of a DataProxy cluster
Review Comment:
The Manager URL for discovering the DataProxy cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org