You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/02/15 08:47:12 UTC

[GitHub] [ignite] ptupitsyn commented on a change in pull request #8795: IGNITE-14169 .NET: BinaryBasicNameMapperForJava introduced

ptupitsyn commented on a change in pull request #8795:
URL: https://github.com/apache/ignite/pull/8795#discussion_r576024237



##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Binary/BinaryBasicNameMapper.cs
##########
@@ -48,7 +48,7 @@ public class BinaryBasicNameMapper : IBinaryNameMapper
         /// <summary>
         /// Gets the type name.
         /// </summary>
-        public string GetTypeName(string name)
+        public virtual string GetTypeName(string name)

Review comment:
       @nizhikov please see the [dev list](http://apache-ignite-developers.2346864.n4.nabble.com/NET-naming-convention-RegisterSameJavaType-mode-td51386.html) - making those methods `virtual` does not seem to be a good idea.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org