You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/29 06:13:23 UTC

[GitHub] [nifi] yannizhou05 opened a new pull request, #6342: Update TestPrometheusRecordSink.java

yannizhou05 opened a new pull request, #6342:
URL: https://github.com/apache/nifi/pull/6342

   The test of "testSendData" in TestPrometheusRecordSink.java is flaky because of HashMaps. The orders of elements in the HashMaps are not the same every time being called. In this case, LinkedHashMap is applied to replace HashMaps in order to ensure the orders are not changing. Also, the MapRecord cannot keep the same orders of row1 and row2 as well. To deal with this situation, two possible combinations of row1 and row2 are applied in the test cases to avoid possible failures due to orders. 
   
   It matters to fix this flaky test as it may causes potential issues due to the uncertainty of orders from Maps rather than the program itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nifi] yannizhou05 closed pull request #6342: Update TestPrometheusRecordSink.java

Posted by GitBox <gi...@apache.org>.
yannizhou05 closed pull request #6342: Update TestPrometheusRecordSink.java
URL: https://github.com/apache/nifi/pull/6342


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org