You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/04 17:17:08 UTC

[GitHub] [flink] StephanEwen opened a new pull request #16715: [FLINK-23629][FLINK-23630][tests] Some fixes to EventTimeWindowCheckpointingITCase

StephanEwen opened a new pull request #16715:
URL: https://github.com/apache/flink/pull/16715


   ## What is the purpose of the change
   
   Fixes `EventTimeWindowCheckpointingITCase` and `LocalRecoveryITCase` to run on Windows and speeds up  `EventTimeWindowCheckpointingITCase` by removing unnecessary cases.
   
   ## Brief Changelog
   
     - [FLINK-23629][tests] Remove redundant file-async and mem-async test runs from `EventTimeWindowCheckpointingITCase`
   
       Because all snapshots are async, the MEM and MEM_ASYNC, as well as FILE and FILE_ASYNC are now the same. This removes unnecessary cases to save testing time.
   
     - [FLINK-23630][tests] Make `EventTimeWindowCheckpointingITCase`and `LocalRecoveryITCase` run on Windows.
   
   This fixes the creation of Paths to be properly platform independent.
   
   ## Verifying this change
   
   This PR fixes tests, no additional tests are added.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16715: [FLINK-23629][FLINK-23630][tests] Some fixes to EventTimeWindowCheckpointingITCase

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16715:
URL: https://github.com/apache/flink/pull/16715#issuecomment-892842320


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit b94138583ab0990374f76ac4be659f0bcafb6d0d (Wed Aug 04 17:33:34 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16715: [FLINK-23629][FLINK-23630][tests] Some fixes to EventTimeWindowCheckpointingITCase

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16715:
URL: https://github.com/apache/flink/pull/16715#issuecomment-892856175


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b94138583ab0990374f76ac4be659f0bcafb6d0d",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21550",
       "triggerID" : "b94138583ab0990374f76ac4be659f0bcafb6d0d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b94138583ab0990374f76ac4be659f0bcafb6d0d Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21550) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16715: [FLINK-23629][FLINK-23630][tests] Some fixes to EventTimeWindowCheckpointingITCase

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16715:
URL: https://github.com/apache/flink/pull/16715#issuecomment-892856175


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b94138583ab0990374f76ac4be659f0bcafb6d0d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b94138583ab0990374f76ac4be659f0bcafb6d0d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b94138583ab0990374f76ac4be659f0bcafb6d0d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16715: [FLINK-23629][FLINK-23630][tests] Some fixes to EventTimeWindowCheckpointingITCase

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16715:
URL: https://github.com/apache/flink/pull/16715#issuecomment-892856175


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b94138583ab0990374f76ac4be659f0bcafb6d0d",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21550",
       "triggerID" : "b94138583ab0990374f76ac4be659f0bcafb6d0d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b94138583ab0990374f76ac4be659f0bcafb6d0d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=21550) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #16715: [FLINK-23629][FLINK-23630][tests] Some fixes to EventTimeWindowCheckpointingITCase

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16715:
URL: https://github.com/apache/flink/pull/16715#issuecomment-892842320






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #16715: [FLINK-23629][FLINK-23630][tests] Some fixes to EventTimeWindowCheckpointingITCase

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #16715:
URL: https://github.com/apache/flink/pull/16715#issuecomment-892832073


   @zentol you might like this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #16715: [FLINK-23629][FLINK-23630][tests] Some fixes to EventTimeWindowCheckpointingITCase

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #16715:
URL: https://github.com/apache/flink/pull/16715#issuecomment-892832073


   @zentol you might like this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #16715: [FLINK-23629][FLINK-23630][tests] Some fixes to EventTimeWindowCheckpointingITCase

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #16715:
URL: https://github.com/apache/flink/pull/16715#issuecomment-893860722


   Because these are very simple test cleanups that don't change test coverage or any production code, I would merge this PR in the next days, unless there are objections...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #16715: [FLINK-23629][FLINK-23630][tests] Some fixes to EventTimeWindowCheckpointingITCase

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16715:
URL: https://github.com/apache/flink/pull/16715#issuecomment-892856175






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen closed pull request #16715: [FLINK-23629][FLINK-23630][tests] Some fixes to EventTimeWindowCheckpointingITCase

Posted by GitBox <gi...@apache.org>.
StephanEwen closed pull request #16715:
URL: https://github.com/apache/flink/pull/16715


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] StephanEwen commented on pull request #16715: [FLINK-23629][FLINK-23630][tests] Some fixes to EventTimeWindowCheckpointingITCase

Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #16715:
URL: https://github.com/apache/flink/pull/16715#issuecomment-900196170


   Manually merged...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org