You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by Francesco Chicchiriccò <il...@apache.org> on 2021/04/20 13:38:15 UTC
Errors after recent commits
Hi there,
with latest 3.1.3-SNAPSHOT artifacts I am getting errors while building Syncope.
In particular, we have a Maven module [1] which runs openjpa-maven-plugin:enhance [2] as part of the build, and several modules (like [3][4][5] and others) which are depending on [1], adding more entities and also running openjpa-maven-plugin:enhance
All this used to work fine until this morning (and still works fine with OpenJPA 3.1.2 on other Syncope branches); now [1] is still working fine, but building other modules give errors like as
[ERROR] /home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8] org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not abstract and does not override abstract method pcSetDetachedState(java.lang.Object) in org.apache.openjpa.enhance.PersistenceCapable
Could you please shed some light? Thanks!
Regards.
[1] https://github.com/apache/syncope/tree/master/core/persistence-jpa
[2] https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
[3] https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
[4] https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
[5] https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa
--
Francesco Chicchiriccò
Tirasa - Open Source Excellence
http://www.tirasa.net/
Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/
Re: Errors after recent commits
Posted by Francesco Chicchiriccò <il...@apache.org>.
On 22/04/21 19:38, Romain Manni-Bucau wrote:
> Im not sure the gain to have it marked synthetic since other cases will be
> problematic anyway with our proxies so I guess we can leave it this way.
+1
Regards.
> Le jeu. 22 avr. 2021 à 19:07, Mark Struberg <st...@yahoo.de.invalid> a
> écrit :
>
>> Hi!
>>
>> Thanks for catching this!
>>
>> Does this mean we should rather close 2800 as won't fix?
>>
>> LieGrue,
>> strub
>>
>>> Am 21.04.2021 um 15:43 schrieb Romain Manni-Bucau <rmannibucau@gmail.com
>>> :
>>>
>>> Oh would make sense since it is 2 compile cycles so cant really be
>>> synthetic.
>>>
>>> Le mer. 21 avr. 2021 à 13:49, Francesco Chicchiriccò <
>> ilgrosso@apache.org>
>>> a écrit :
>>>
>>>> I think that the issue is occurring when:
>>>>
>>>> 1. a parent entity is enhanced in a module
>>>> 2. a child entity is enhanced in another module
>>>>
>>>> In my case, the error was occurring only for child entities in a
>> different
>>>> module.
>>>>
>>>> Regards.
>>>>
>>>> On 21/04/21 13:46, Romain Manni-Bucau wrote:
>>>>> Hi,
>>>>>
>>>>> I think it is ok to revert when it breaks and reapply with the fix.
>>>>> I tested on our opentrader application where there is a hierarchy with
>>>> Ask
>>>>> entity and the method seems well generated with Mark's commit so I
>> guess
>>>> we
>>>>> need to refine the actual issue.
>>>>>
>>>>> Romain Manni-Bucau
>>>>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>>>>> <https://rmannibucau.metawerx.net/> | Old Blog
>>>>> <http://rmannibucau.wordpress.com> | Github <
>>>> https://github.com/rmannibucau> |
>>>>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
>>>>> <
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>>>>>
>>>>>
>>>>> Le mer. 21 avr. 2021 à 12:18, Francesco Chicchiriccò <
>>>> ilgrosso@apache.org>
>>>>> a écrit :
>>>>>
>>>>>> Hi again,
>>>>>> I went ahead, revert the commit and re-opened OPENJPA-2800.
>>>>>>
>>>>>> I am not sure to fully understand what is the actual reason for
>> failure,
>>>>>> though...
>>>>>>
>>>>>> Regards.
>>>>>>
>>>>>> On 21/04/21 11:29, Francesco Chicchiriccò wrote:
>>>>>>> Update: I've found the actual issues is that the pcSetDetachedState()
>>>>>> method is not generated in the parent class AbstractProvidedKeyEntity;
>>>> as
>>>>>> you can see from
>> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470#file-abstractprovidedkeyentity-java-L243-L245
>>>>>>> in fact, the method was still generated on Monday, hence child class
>>>>>> JPACamelRoute was fine.
>>>>>>> Regards.
>>>>>>>
>>>>>>> On 21/04/21 11:06, Francesco Chicchiriccò wrote:
>>>>>>>> Hi,
>>>>>>>> from the last successful build that was deployed to repository.a.o
>> by
>>>>>> Jenkins (the day before yesterday, Monday 19th):
>> https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar
>>>>>>>> I did decompile a sample entity class:
>>>>>>>>
>>>>>>>> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470
>>>>>>>>
>>>>>>>> where, as you can see, the method
>>>>>>>>
>>>>>>>> pcSetDetachedState(java.lang.Object) from
>>>>>> org.apache.openjpa.enhance.PersistenceCapable
>>>>>>>> is not implemented: hence, the Maven build error reported below is
>>>>>> effectively correct, even though this was not happening until Monday
>>>> 19th.
>>>>>>>> If I revert locally the last commit by Mark:
>>>>>>>>
>>>>>>>>
>> https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df
>>>>>>>> all is back working again.
>>>>>>>>
>>>>>>>> Is it ok if I go ahead and revert that commit? Meanwhile, we can
>> look
>>>>>> for a proper solution.
>>>>>>>> WDYT?
>>>>>>>>
>>>>>>>> Regards.
>>>>>>>>
>>>>>>>> On 20/04/21 16:02, Romain Manni-Bucau wrote:
>>>>>>>>> Hi Francesco,
>>>>>>>>>
>>>>>>>>> Did you try to decompile previous and current version (with jd-gui
>>>> for
>>>>>>>>> example) to see the diff?
>>>>>>>>> Normally Mark only changed synthetic flag on fields, nothing else
>>>>>> should
>>>>>>>>> have changed AFAIK.
>>>>>>>>>
>>>>>>>>> Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò <
>>>>>> ilgrosso@apache.org>
>>>>>>>>> a écrit :
>>>>>>>>>
>>>>>>>>>> Hi there,
>>>>>>>>>> with latest 3.1.3-SNAPSHOT artifacts I am getting errors while
>>>>>> building
>>>>>>>>>> Syncope.
>>>>>>>>>>
>>>>>>>>>> In particular, we have a Maven module [1] which runs
>>>>>>>>>> openjpa-maven-plugin:enhance [2] as part of the build, and several
>>>>>> modules
>>>>>>>>>> (like [3][4][5] and others) which are depending on [1], adding
>> more
>>>>>>>>>> entities and also running openjpa-maven-plugin:enhance
>>>>>>>>>>
>>>>>>>>>> All this used to work fine until this morning (and still works
>> fine
>>>>>> with
>>>>>>>>>> OpenJPA 3.1.2 on other Syncope branches); now [1] is still working
>>>>>> fine,
>>>>>>>>>> but building other modules give errors like as
>>>>>>>>>>
>>>>>>>>>> [ERROR]
>>>>>>>>>>
>> /home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
>>>>>>>>>> org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is
>> not
>>>>>>>>>> abstract and does not override abstract method
>>>>>>>>>> pcSetDetachedState(java.lang.Object) in
>>>>>>>>>> org.apache.openjpa.enhance.PersistenceCapable
>>>>>>>>>>
>>>>>>>>>> Could you please shed some light? Thanks!
>>>>>>>>>> Regards.
>>>>>>>>>>
>>>>>>>>>> [1]
>>>>>> https://github.com/apache/syncope/tree/master/core/persistence-jpa
>>>>>>>>>> [2]
>>>>>>>>>>
>> https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
>>>>>>>>>> [3]
>>>>>>>>>>
>> https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
>>>>>>>>>> [4]
>>>>>>>>>>
>> https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
>>>>>>>>>> [5]
>>>>>>>>>>
>> https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa
--
Francesco Chicchiriccò
Tirasa - Open Source Excellence
http://www.tirasa.net/
Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/
Re: Errors after recent commits
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Im not sure the gain to have it marked synthetic since other cases will be
problematic anyway with our proxies so I guess we can leave it this way.
Le jeu. 22 avr. 2021 à 19:07, Mark Struberg <st...@yahoo.de.invalid> a
écrit :
> Hi!
>
> Thanks for catching this!
>
> Does this mean we should rather close 2800 as won't fix?
>
> LieGrue,
> strub
>
> > Am 21.04.2021 um 15:43 schrieb Romain Manni-Bucau <rmannibucau@gmail.com
> >:
> >
> > Oh would make sense since it is 2 compile cycles so cant really be
> > synthetic.
> >
> > Le mer. 21 avr. 2021 à 13:49, Francesco Chicchiriccò <
> ilgrosso@apache.org>
> > a écrit :
> >
> >> I think that the issue is occurring when:
> >>
> >> 1. a parent entity is enhanced in a module
> >> 2. a child entity is enhanced in another module
> >>
> >> In my case, the error was occurring only for child entities in a
> different
> >> module.
> >>
> >> Regards.
> >>
> >> On 21/04/21 13:46, Romain Manni-Bucau wrote:
> >>> Hi,
> >>>
> >>> I think it is ok to revert when it breaks and reapply with the fix.
> >>> I tested on our opentrader application where there is a hierarchy with
> >> Ask
> >>> entity and the method seems well generated with Mark's commit so I
> guess
> >> we
> >>> need to refine the actual issue.
> >>>
> >>> Romain Manni-Bucau
> >>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> >>> <https://rmannibucau.metawerx.net/> | Old Blog
> >>> <http://rmannibucau.wordpress.com> | Github <
> >> https://github.com/rmannibucau> |
> >>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> >>> <
> >>
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >>>
> >>>
> >>>
> >>> Le mer. 21 avr. 2021 à 12:18, Francesco Chicchiriccò <
> >> ilgrosso@apache.org>
> >>> a écrit :
> >>>
> >>>> Hi again,
> >>>> I went ahead, revert the commit and re-opened OPENJPA-2800.
> >>>>
> >>>> I am not sure to fully understand what is the actual reason for
> failure,
> >>>> though...
> >>>>
> >>>> Regards.
> >>>>
> >>>> On 21/04/21 11:29, Francesco Chicchiriccò wrote:
> >>>>> Update: I've found the actual issues is that the pcSetDetachedState()
> >>>> method is not generated in the parent class AbstractProvidedKeyEntity;
> >> as
> >>>> you can see from
> >>>>>
> >>>>
> >>
> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470#file-abstractprovidedkeyentity-java-L243-L245
> >>>>> in fact, the method was still generated on Monday, hence child class
> >>>> JPACamelRoute was fine.
> >>>>> Regards.
> >>>>>
> >>>>> On 21/04/21 11:06, Francesco Chicchiriccò wrote:
> >>>>>> Hi,
> >>>>>> from the last successful build that was deployed to repository.a.o
> by
> >>>> Jenkins (the day before yesterday, Monday 19th):
> >>>>>>
> >>>>
> >>
> https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar
> >>>>>> I did decompile a sample entity class:
> >>>>>>
> >>>>>> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470
> >>>>>>
> >>>>>> where, as you can see, the method
> >>>>>>
> >>>>>> pcSetDetachedState(java.lang.Object) from
> >>>> org.apache.openjpa.enhance.PersistenceCapable
> >>>>>> is not implemented: hence, the Maven build error reported below is
> >>>> effectively correct, even though this was not happening until Monday
> >> 19th.
> >>>>>> If I revert locally the last commit by Mark:
> >>>>>>
> >>>>>>
> >>>>
> >>
> https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df
> >>>>>> all is back working again.
> >>>>>>
> >>>>>> Is it ok if I go ahead and revert that commit? Meanwhile, we can
> look
> >>>> for a proper solution.
> >>>>>> WDYT?
> >>>>>>
> >>>>>> Regards.
> >>>>>>
> >>>>>> On 20/04/21 16:02, Romain Manni-Bucau wrote:
> >>>>>>> Hi Francesco,
> >>>>>>>
> >>>>>>> Did you try to decompile previous and current version (with jd-gui
> >> for
> >>>>>>> example) to see the diff?
> >>>>>>> Normally Mark only changed synthetic flag on fields, nothing else
> >>>> should
> >>>>>>> have changed AFAIK.
> >>>>>>>
> >>>>>>> Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò <
> >>>> ilgrosso@apache.org>
> >>>>>>> a écrit :
> >>>>>>>
> >>>>>>>> Hi there,
> >>>>>>>> with latest 3.1.3-SNAPSHOT artifacts I am getting errors while
> >>>> building
> >>>>>>>> Syncope.
> >>>>>>>>
> >>>>>>>> In particular, we have a Maven module [1] which runs
> >>>>>>>> openjpa-maven-plugin:enhance [2] as part of the build, and several
> >>>> modules
> >>>>>>>> (like [3][4][5] and others) which are depending on [1], adding
> more
> >>>>>>>> entities and also running openjpa-maven-plugin:enhance
> >>>>>>>>
> >>>>>>>> All this used to work fine until this morning (and still works
> fine
> >>>> with
> >>>>>>>> OpenJPA 3.1.2 on other Syncope branches); now [1] is still working
> >>>> fine,
> >>>>>>>> but building other modules give errors like as
> >>>>>>>>
> >>>>>>>> [ERROR]
> >>>>>>>>
> >>>>
> >>
> /home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
> >>>>>>>> org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is
> not
> >>>>>>>> abstract and does not override abstract method
> >>>>>>>> pcSetDetachedState(java.lang.Object) in
> >>>>>>>> org.apache.openjpa.enhance.PersistenceCapable
> >>>>>>>>
> >>>>>>>> Could you please shed some light? Thanks!
> >>>>>>>> Regards.
> >>>>>>>>
> >>>>>>>> [1]
> >>>> https://github.com/apache/syncope/tree/master/core/persistence-jpa
> >>>>>>>> [2]
> >>>>>>>>
> >>>>
> >>
> https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
> >>>>>>>> [3]
> >>>>>>>>
> >>>>
> https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
> >>>>>>>> [4]
> >>>>>>>>
> >>>>
> https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
> >>>>>>>> [5]
> >>>>>>>>
> >>>>
> >>
> https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa
> >>>>
> >>>> --
> >>>> Francesco Chicchiriccò
> >>>>
> >>>> Tirasa - Open Source Excellence
> >>>> http://www.tirasa.net/
> >>>>
> >>>> Member at The Apache Software Foundation
> >>>> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> >>>> http://home.apache.org/~ilgrosso/
> >>>>
> >>>>
> >>
> >> --
> >> Francesco Chicchiriccò
> >>
> >> Tirasa - Open Source Excellence
> >> http://www.tirasa.net/
> >>
> >> Member at The Apache Software Foundation
> >> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> >> http://home.apache.org/~ilgrosso/
> >>
> >>
>
>
Re: Errors after recent commits
Posted by Mark Struberg <st...@yahoo.de.INVALID>.
Hi!
Thanks for catching this!
Does this mean we should rather close 2800 as won't fix?
LieGrue,
strub
> Am 21.04.2021 um 15:43 schrieb Romain Manni-Bucau <rm...@gmail.com>:
>
> Oh would make sense since it is 2 compile cycles so cant really be
> synthetic.
>
> Le mer. 21 avr. 2021 à 13:49, Francesco Chicchiriccò <il...@apache.org>
> a écrit :
>
>> I think that the issue is occurring when:
>>
>> 1. a parent entity is enhanced in a module
>> 2. a child entity is enhanced in another module
>>
>> In my case, the error was occurring only for child entities in a different
>> module.
>>
>> Regards.
>>
>> On 21/04/21 13:46, Romain Manni-Bucau wrote:
>>> Hi,
>>>
>>> I think it is ok to revert when it breaks and reapply with the fix.
>>> I tested on our opentrader application where there is a hierarchy with
>> Ask
>>> entity and the method seems well generated with Mark's commit so I guess
>> we
>>> need to refine the actual issue.
>>>
>>> Romain Manni-Bucau
>>> @rmannibucau <https://twitter.com/rmannibucau> | Blog
>>> <https://rmannibucau.metawerx.net/> | Old Blog
>>> <http://rmannibucau.wordpress.com> | Github <
>> https://github.com/rmannibucau> |
>>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
>>> <
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>>>
>>>
>>>
>>> Le mer. 21 avr. 2021 à 12:18, Francesco Chicchiriccò <
>> ilgrosso@apache.org>
>>> a écrit :
>>>
>>>> Hi again,
>>>> I went ahead, revert the commit and re-opened OPENJPA-2800.
>>>>
>>>> I am not sure to fully understand what is the actual reason for failure,
>>>> though...
>>>>
>>>> Regards.
>>>>
>>>> On 21/04/21 11:29, Francesco Chicchiriccò wrote:
>>>>> Update: I've found the actual issues is that the pcSetDetachedState()
>>>> method is not generated in the parent class AbstractProvidedKeyEntity;
>> as
>>>> you can see from
>>>>>
>>>>
>> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470#file-abstractprovidedkeyentity-java-L243-L245
>>>>> in fact, the method was still generated on Monday, hence child class
>>>> JPACamelRoute was fine.
>>>>> Regards.
>>>>>
>>>>> On 21/04/21 11:06, Francesco Chicchiriccò wrote:
>>>>>> Hi,
>>>>>> from the last successful build that was deployed to repository.a.o by
>>>> Jenkins (the day before yesterday, Monday 19th):
>>>>>>
>>>>
>> https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar
>>>>>> I did decompile a sample entity class:
>>>>>>
>>>>>> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470
>>>>>>
>>>>>> where, as you can see, the method
>>>>>>
>>>>>> pcSetDetachedState(java.lang.Object) from
>>>> org.apache.openjpa.enhance.PersistenceCapable
>>>>>> is not implemented: hence, the Maven build error reported below is
>>>> effectively correct, even though this was not happening until Monday
>> 19th.
>>>>>> If I revert locally the last commit by Mark:
>>>>>>
>>>>>>
>>>>
>> https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df
>>>>>> all is back working again.
>>>>>>
>>>>>> Is it ok if I go ahead and revert that commit? Meanwhile, we can look
>>>> for a proper solution.
>>>>>> WDYT?
>>>>>>
>>>>>> Regards.
>>>>>>
>>>>>> On 20/04/21 16:02, Romain Manni-Bucau wrote:
>>>>>>> Hi Francesco,
>>>>>>>
>>>>>>> Did you try to decompile previous and current version (with jd-gui
>> for
>>>>>>> example) to see the diff?
>>>>>>> Normally Mark only changed synthetic flag on fields, nothing else
>>>> should
>>>>>>> have changed AFAIK.
>>>>>>>
>>>>>>> Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò <
>>>> ilgrosso@apache.org>
>>>>>>> a écrit :
>>>>>>>
>>>>>>>> Hi there,
>>>>>>>> with latest 3.1.3-SNAPSHOT artifacts I am getting errors while
>>>> building
>>>>>>>> Syncope.
>>>>>>>>
>>>>>>>> In particular, we have a Maven module [1] which runs
>>>>>>>> openjpa-maven-plugin:enhance [2] as part of the build, and several
>>>> modules
>>>>>>>> (like [3][4][5] and others) which are depending on [1], adding more
>>>>>>>> entities and also running openjpa-maven-plugin:enhance
>>>>>>>>
>>>>>>>> All this used to work fine until this morning (and still works fine
>>>> with
>>>>>>>> OpenJPA 3.1.2 on other Syncope branches); now [1] is still working
>>>> fine,
>>>>>>>> but building other modules give errors like as
>>>>>>>>
>>>>>>>> [ERROR]
>>>>>>>>
>>>>
>> /home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
>>>>>>>> org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not
>>>>>>>> abstract and does not override abstract method
>>>>>>>> pcSetDetachedState(java.lang.Object) in
>>>>>>>> org.apache.openjpa.enhance.PersistenceCapable
>>>>>>>>
>>>>>>>> Could you please shed some light? Thanks!
>>>>>>>> Regards.
>>>>>>>>
>>>>>>>> [1]
>>>> https://github.com/apache/syncope/tree/master/core/persistence-jpa
>>>>>>>> [2]
>>>>>>>>
>>>>
>> https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
>>>>>>>> [3]
>>>>>>>>
>>>> https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
>>>>>>>> [4]
>>>>>>>>
>>>> https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
>>>>>>>> [5]
>>>>>>>>
>>>>
>> https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa
>>>>
>>>> --
>>>> Francesco Chicchiriccò
>>>>
>>>> Tirasa - Open Source Excellence
>>>> http://www.tirasa.net/
>>>>
>>>> Member at The Apache Software Foundation
>>>> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
>>>> http://home.apache.org/~ilgrosso/
>>>>
>>>>
>>
>> --
>> Francesco Chicchiriccò
>>
>> Tirasa - Open Source Excellence
>> http://www.tirasa.net/
>>
>> Member at The Apache Software Foundation
>> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
>> http://home.apache.org/~ilgrosso/
>>
>>
Re: Errors after recent commits
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Oh would make sense since it is 2 compile cycles so cant really be
synthetic.
Le mer. 21 avr. 2021 à 13:49, Francesco Chicchiriccò <il...@apache.org>
a écrit :
> I think that the issue is occurring when:
>
> 1. a parent entity is enhanced in a module
> 2. a child entity is enhanced in another module
>
> In my case, the error was occurring only for child entities in a different
> module.
>
> Regards.
>
> On 21/04/21 13:46, Romain Manni-Bucau wrote:
> > Hi,
> >
> > I think it is ok to revert when it breaks and reapply with the fix.
> > I tested on our opentrader application where there is a hierarchy with
> Ask
> > entity and the method seems well generated with Mark's commit so I guess
> we
> > need to refine the actual issue.
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> | Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
> >
> >
> > Le mer. 21 avr. 2021 à 12:18, Francesco Chicchiriccò <
> ilgrosso@apache.org>
> > a écrit :
> >
> >> Hi again,
> >> I went ahead, revert the commit and re-opened OPENJPA-2800.
> >>
> >> I am not sure to fully understand what is the actual reason for failure,
> >> though...
> >>
> >> Regards.
> >>
> >> On 21/04/21 11:29, Francesco Chicchiriccò wrote:
> >>> Update: I've found the actual issues is that the pcSetDetachedState()
> >> method is not generated in the parent class AbstractProvidedKeyEntity;
> as
> >> you can see from
> >>>
> >>
> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470#file-abstractprovidedkeyentity-java-L243-L245
> >>> in fact, the method was still generated on Monday, hence child class
> >> JPACamelRoute was fine.
> >>> Regards.
> >>>
> >>> On 21/04/21 11:06, Francesco Chicchiriccò wrote:
> >>>> Hi,
> >>>> from the last successful build that was deployed to repository.a.o by
> >> Jenkins (the day before yesterday, Monday 19th):
> >>>>
> >>
> https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar
> >>>> I did decompile a sample entity class:
> >>>>
> >>>> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470
> >>>>
> >>>> where, as you can see, the method
> >>>>
> >>>> pcSetDetachedState(java.lang.Object) from
> >> org.apache.openjpa.enhance.PersistenceCapable
> >>>> is not implemented: hence, the Maven build error reported below is
> >> effectively correct, even though this was not happening until Monday
> 19th.
> >>>> If I revert locally the last commit by Mark:
> >>>>
> >>>>
> >>
> https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df
> >>>> all is back working again.
> >>>>
> >>>> Is it ok if I go ahead and revert that commit? Meanwhile, we can look
> >> for a proper solution.
> >>>> WDYT?
> >>>>
> >>>> Regards.
> >>>>
> >>>> On 20/04/21 16:02, Romain Manni-Bucau wrote:
> >>>>> Hi Francesco,
> >>>>>
> >>>>> Did you try to decompile previous and current version (with jd-gui
> for
> >>>>> example) to see the diff?
> >>>>> Normally Mark only changed synthetic flag on fields, nothing else
> >> should
> >>>>> have changed AFAIK.
> >>>>>
> >>>>> Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò <
> >> ilgrosso@apache.org>
> >>>>> a écrit :
> >>>>>
> >>>>>> Hi there,
> >>>>>> with latest 3.1.3-SNAPSHOT artifacts I am getting errors while
> >> building
> >>>>>> Syncope.
> >>>>>>
> >>>>>> In particular, we have a Maven module [1] which runs
> >>>>>> openjpa-maven-plugin:enhance [2] as part of the build, and several
> >> modules
> >>>>>> (like [3][4][5] and others) which are depending on [1], adding more
> >>>>>> entities and also running openjpa-maven-plugin:enhance
> >>>>>>
> >>>>>> All this used to work fine until this morning (and still works fine
> >> with
> >>>>>> OpenJPA 3.1.2 on other Syncope branches); now [1] is still working
> >> fine,
> >>>>>> but building other modules give errors like as
> >>>>>>
> >>>>>> [ERROR]
> >>>>>>
> >>
> /home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
> >>>>>> org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not
> >>>>>> abstract and does not override abstract method
> >>>>>> pcSetDetachedState(java.lang.Object) in
> >>>>>> org.apache.openjpa.enhance.PersistenceCapable
> >>>>>>
> >>>>>> Could you please shed some light? Thanks!
> >>>>>> Regards.
> >>>>>>
> >>>>>> [1]
> >> https://github.com/apache/syncope/tree/master/core/persistence-jpa
> >>>>>> [2]
> >>>>>>
> >>
> https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
> >>>>>> [3]
> >>>>>>
> >> https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
> >>>>>> [4]
> >>>>>>
> >> https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
> >>>>>> [5]
> >>>>>>
> >>
> https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa
> >>
> >> --
> >> Francesco Chicchiriccò
> >>
> >> Tirasa - Open Source Excellence
> >> http://www.tirasa.net/
> >>
> >> Member at The Apache Software Foundation
> >> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> >> http://home.apache.org/~ilgrosso/
> >>
> >>
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>
>
Re: Errors after recent commits
Posted by Francesco Chicchiriccò <il...@apache.org>.
I think that the issue is occurring when:
1. a parent entity is enhanced in a module
2. a child entity is enhanced in another module
In my case, the error was occurring only for child entities in a different module.
Regards.
On 21/04/21 13:46, Romain Manni-Bucau wrote:
> Hi,
>
> I think it is ok to revert when it breaks and reapply with the fix.
> I tested on our opentrader application where there is a hierarchy with Ask
> entity and the method seems well generated with Mark's commit so I guess we
> need to refine the actual issue.
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> | Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <https://www.packtpub.com/application-development/java-ee-8-high-performance>
>
>
> Le mer. 21 avr. 2021 à 12:18, Francesco Chicchiriccò <il...@apache.org>
> a écrit :
>
>> Hi again,
>> I went ahead, revert the commit and re-opened OPENJPA-2800.
>>
>> I am not sure to fully understand what is the actual reason for failure,
>> though...
>>
>> Regards.
>>
>> On 21/04/21 11:29, Francesco Chicchiriccò wrote:
>>> Update: I've found the actual issues is that the pcSetDetachedState()
>> method is not generated in the parent class AbstractProvidedKeyEntity; as
>> you can see from
>>>
>> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470#file-abstractprovidedkeyentity-java-L243-L245
>>> in fact, the method was still generated on Monday, hence child class
>> JPACamelRoute was fine.
>>> Regards.
>>>
>>> On 21/04/21 11:06, Francesco Chicchiriccò wrote:
>>>> Hi,
>>>> from the last successful build that was deployed to repository.a.o by
>> Jenkins (the day before yesterday, Monday 19th):
>>>>
>> https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar
>>>> I did decompile a sample entity class:
>>>>
>>>> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470
>>>>
>>>> where, as you can see, the method
>>>>
>>>> pcSetDetachedState(java.lang.Object) from
>> org.apache.openjpa.enhance.PersistenceCapable
>>>> is not implemented: hence, the Maven build error reported below is
>> effectively correct, even though this was not happening until Monday 19th.
>>>> If I revert locally the last commit by Mark:
>>>>
>>>>
>> https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df
>>>> all is back working again.
>>>>
>>>> Is it ok if I go ahead and revert that commit? Meanwhile, we can look
>> for a proper solution.
>>>> WDYT?
>>>>
>>>> Regards.
>>>>
>>>> On 20/04/21 16:02, Romain Manni-Bucau wrote:
>>>>> Hi Francesco,
>>>>>
>>>>> Did you try to decompile previous and current version (with jd-gui for
>>>>> example) to see the diff?
>>>>> Normally Mark only changed synthetic flag on fields, nothing else
>> should
>>>>> have changed AFAIK.
>>>>>
>>>>> Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò <
>> ilgrosso@apache.org>
>>>>> a écrit :
>>>>>
>>>>>> Hi there,
>>>>>> with latest 3.1.3-SNAPSHOT artifacts I am getting errors while
>> building
>>>>>> Syncope.
>>>>>>
>>>>>> In particular, we have a Maven module [1] which runs
>>>>>> openjpa-maven-plugin:enhance [2] as part of the build, and several
>> modules
>>>>>> (like [3][4][5] and others) which are depending on [1], adding more
>>>>>> entities and also running openjpa-maven-plugin:enhance
>>>>>>
>>>>>> All this used to work fine until this morning (and still works fine
>> with
>>>>>> OpenJPA 3.1.2 on other Syncope branches); now [1] is still working
>> fine,
>>>>>> but building other modules give errors like as
>>>>>>
>>>>>> [ERROR]
>>>>>>
>> /home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
>>>>>> org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not
>>>>>> abstract and does not override abstract method
>>>>>> pcSetDetachedState(java.lang.Object) in
>>>>>> org.apache.openjpa.enhance.PersistenceCapable
>>>>>>
>>>>>> Could you please shed some light? Thanks!
>>>>>> Regards.
>>>>>>
>>>>>> [1]
>> https://github.com/apache/syncope/tree/master/core/persistence-jpa
>>>>>> [2]
>>>>>>
>> https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
>>>>>> [3]
>>>>>>
>> https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
>>>>>> [4]
>>>>>>
>> https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
>>>>>> [5]
>>>>>>
>> https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa
>>
>> --
>> Francesco Chicchiriccò
>>
>> Tirasa - Open Source Excellence
>> http://www.tirasa.net/
>>
>> Member at The Apache Software Foundation
>> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
>> http://home.apache.org/~ilgrosso/
>>
>>
--
Francesco Chicchiriccò
Tirasa - Open Source Excellence
http://www.tirasa.net/
Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/
Re: Errors after recent commits
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi,
I think it is ok to revert when it breaks and reapply with the fix.
I tested on our opentrader application where there is a hierarchy with Ask
entity and the method seems well generated with Mark's commit so I guess we
need to refine the actual issue.
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le mer. 21 avr. 2021 à 12:18, Francesco Chicchiriccò <il...@apache.org>
a écrit :
> Hi again,
> I went ahead, revert the commit and re-opened OPENJPA-2800.
>
> I am not sure to fully understand what is the actual reason for failure,
> though...
>
> Regards.
>
> On 21/04/21 11:29, Francesco Chicchiriccò wrote:
> > Update: I've found the actual issues is that the pcSetDetachedState()
> method is not generated in the parent class AbstractProvidedKeyEntity; as
> you can see from
> >
> >
> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470#file-abstractprovidedkeyentity-java-L243-L245
> >
> > in fact, the method was still generated on Monday, hence child class
> JPACamelRoute was fine.
> >
> > Regards.
> >
> > On 21/04/21 11:06, Francesco Chicchiriccò wrote:
> >> Hi,
> >> from the last successful build that was deployed to repository.a.o by
> Jenkins (the day before yesterday, Monday 19th):
> >>
> >>
> https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar
> >>
> >> I did decompile a sample entity class:
> >>
> >> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470
> >>
> >> where, as you can see, the method
> >>
> >> pcSetDetachedState(java.lang.Object) from
> org.apache.openjpa.enhance.PersistenceCapable
> >>
> >> is not implemented: hence, the Maven build error reported below is
> effectively correct, even though this was not happening until Monday 19th.
> >>
> >> If I revert locally the last commit by Mark:
> >>
> >>
> https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df
> >>
> >> all is back working again.
> >>
> >> Is it ok if I go ahead and revert that commit? Meanwhile, we can look
> for a proper solution.
> >> WDYT?
> >>
> >> Regards.
> >>
> >> On 20/04/21 16:02, Romain Manni-Bucau wrote:
> >>> Hi Francesco,
> >>>
> >>> Did you try to decompile previous and current version (with jd-gui for
> >>> example) to see the diff?
> >>> Normally Mark only changed synthetic flag on fields, nothing else
> should
> >>> have changed AFAIK.
> >>>
> >>> Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò <
> ilgrosso@apache.org>
> >>> a écrit :
> >>>
> >>>> Hi there,
> >>>> with latest 3.1.3-SNAPSHOT artifacts I am getting errors while
> building
> >>>> Syncope.
> >>>>
> >>>> In particular, we have a Maven module [1] which runs
> >>>> openjpa-maven-plugin:enhance [2] as part of the build, and several
> modules
> >>>> (like [3][4][5] and others) which are depending on [1], adding more
> >>>> entities and also running openjpa-maven-plugin:enhance
> >>>>
> >>>> All this used to work fine until this morning (and still works fine
> with
> >>>> OpenJPA 3.1.2 on other Syncope branches); now [1] is still working
> fine,
> >>>> but building other modules give errors like as
> >>>>
> >>>> [ERROR]
> >>>>
> /home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
> >>>> org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not
> >>>> abstract and does not override abstract method
> >>>> pcSetDetachedState(java.lang.Object) in
> >>>> org.apache.openjpa.enhance.PersistenceCapable
> >>>>
> >>>> Could you please shed some light? Thanks!
> >>>> Regards.
> >>>>
> >>>> [1]
> https://github.com/apache/syncope/tree/master/core/persistence-jpa
> >>>> [2]
> >>>>
> https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
> >>>> [3]
> >>>>
> https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
> >>>> [4]
> >>>>
> https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
> >>>> [5]
> >>>>
> https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>
>
Re: Errors after recent commits
Posted by Francesco Chicchiriccò <il...@apache.org>.
Hi again,
I went ahead, revert the commit and re-opened OPENJPA-2800.
I am not sure to fully understand what is the actual reason for failure, though...
Regards.
On 21/04/21 11:29, Francesco Chicchiriccò wrote:
> Update: I've found the actual issues is that the pcSetDetachedState() method is not generated in the parent class AbstractProvidedKeyEntity; as you can see from
>
> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470#file-abstractprovidedkeyentity-java-L243-L245
>
> in fact, the method was still generated on Monday, hence child class JPACamelRoute was fine.
>
> Regards.
>
> On 21/04/21 11:06, Francesco Chicchiriccò wrote:
>> Hi,
>> from the last successful build that was deployed to repository.a.o by Jenkins (the day before yesterday, Monday 19th):
>>
>> https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar
>>
>> I did decompile a sample entity class:
>>
>> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470
>>
>> where, as you can see, the method
>>
>> pcSetDetachedState(java.lang.Object) from org.apache.openjpa.enhance.PersistenceCapable
>>
>> is not implemented: hence, the Maven build error reported below is effectively correct, even though this was not happening until Monday 19th.
>>
>> If I revert locally the last commit by Mark:
>>
>> https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df
>>
>> all is back working again.
>>
>> Is it ok if I go ahead and revert that commit? Meanwhile, we can look for a proper solution.
>> WDYT?
>>
>> Regards.
>>
>> On 20/04/21 16:02, Romain Manni-Bucau wrote:
>>> Hi Francesco,
>>>
>>> Did you try to decompile previous and current version (with jd-gui for
>>> example) to see the diff?
>>> Normally Mark only changed synthetic flag on fields, nothing else should
>>> have changed AFAIK.
>>>
>>> Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò <il...@apache.org>
>>> a écrit :
>>>
>>>> Hi there,
>>>> with latest 3.1.3-SNAPSHOT artifacts I am getting errors while building
>>>> Syncope.
>>>>
>>>> In particular, we have a Maven module [1] which runs
>>>> openjpa-maven-plugin:enhance [2] as part of the build, and several modules
>>>> (like [3][4][5] and others) which are depending on [1], adding more
>>>> entities and also running openjpa-maven-plugin:enhance
>>>>
>>>> All this used to work fine until this morning (and still works fine with
>>>> OpenJPA 3.1.2 on other Syncope branches); now [1] is still working fine,
>>>> but building other modules give errors like as
>>>>
>>>> [ERROR]
>>>> /home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
>>>> org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not
>>>> abstract and does not override abstract method
>>>> pcSetDetachedState(java.lang.Object) in
>>>> org.apache.openjpa.enhance.PersistenceCapable
>>>>
>>>> Could you please shed some light? Thanks!
>>>> Regards.
>>>>
>>>> [1] https://github.com/apache/syncope/tree/master/core/persistence-jpa
>>>> [2]
>>>> https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
>>>> [3]
>>>> https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
>>>> [4]
>>>> https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
>>>> [5]
>>>> https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa
--
Francesco Chicchiriccò
Tirasa - Open Source Excellence
http://www.tirasa.net/
Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/
Re: Errors after recent commits
Posted by Francesco Chicchiriccò <il...@apache.org>.
Update: I've found the actual issues is that the pcSetDetachedState() method is not generated in the parent class AbstractProvidedKeyEntity; as you can see from
https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470#file-abstractprovidedkeyentity-java-L243-L245
in fact, the method was still generated on Monday, hence child class JPACamelRoute was fine.
Regards.
On 21/04/21 11:06, Francesco Chicchiriccò wrote:
> Hi,
> from the last successful build that was deployed to repository.a.o by Jenkins (the day before yesterday, Monday 19th):
>
> https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar
>
> I did decompile a sample entity class:
>
> https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470
>
> where, as you can see, the method
>
> pcSetDetachedState(java.lang.Object) from org.apache.openjpa.enhance.PersistenceCapable
>
> is not implemented: hence, the Maven build error reported below is effectively correct, even though this was not happening until Monday 19th.
>
> If I revert locally the last commit by Mark:
>
> https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df
>
> all is back working again.
>
> Is it ok if I go ahead and revert that commit? Meanwhile, we can look for a proper solution.
> WDYT?
>
> Regards.
>
> On 20/04/21 16:02, Romain Manni-Bucau wrote:
>> Hi Francesco,
>>
>> Did you try to decompile previous and current version (with jd-gui for
>> example) to see the diff?
>> Normally Mark only changed synthetic flag on fields, nothing else should
>> have changed AFAIK.
>>
>> Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò <il...@apache.org>
>> a écrit :
>>
>>> Hi there,
>>> with latest 3.1.3-SNAPSHOT artifacts I am getting errors while building
>>> Syncope.
>>>
>>> In particular, we have a Maven module [1] which runs
>>> openjpa-maven-plugin:enhance [2] as part of the build, and several modules
>>> (like [3][4][5] and others) which are depending on [1], adding more
>>> entities and also running openjpa-maven-plugin:enhance
>>>
>>> All this used to work fine until this morning (and still works fine with
>>> OpenJPA 3.1.2 on other Syncope branches); now [1] is still working fine,
>>> but building other modules give errors like as
>>>
>>> [ERROR]
>>> /home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
>>> org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not
>>> abstract and does not override abstract method
>>> pcSetDetachedState(java.lang.Object) in
>>> org.apache.openjpa.enhance.PersistenceCapable
>>>
>>> Could you please shed some light? Thanks!
>>> Regards.
>>>
>>> [1] https://github.com/apache/syncope/tree/master/core/persistence-jpa
>>> [2]
>>> https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
>>> [3]
>>> https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
>>> [4]
>>> https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
>>> [5]
>>> https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa
--
Francesco Chicchiriccò
Tirasa - Open Source Excellence
http://www.tirasa.net/
Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/
Re: Errors after recent commits
Posted by Francesco Chicchiriccò <il...@apache.org>.
Hi,
from the last successful build that was deployed to repository.a.o by Jenkins (the day before yesterday, Monday 19th):
https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-3.0.0-20210419.073820-1024.jar
I did decompile a sample entity class:
https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470
where, as you can see, the method
pcSetDetachedState(java.lang.Object) from org.apache.openjpa.enhance.PersistenceCapable
is not implemented: hence, the Maven build error reported below is effectively correct, even though this was not happening until Monday 19th.
If I revert locally the last commit by Mark:
https://github.com/apache/openjpa/commit/5b67ce51801cb646d772dadd03a623312603a0df
all is back working again.
Is it ok if I go ahead and revert that commit? Meanwhile, we can look for a proper solution.
WDYT?
Regards.
On 20/04/21 16:02, Romain Manni-Bucau wrote:
> Hi Francesco,
>
> Did you try to decompile previous and current version (with jd-gui for
> example) to see the diff?
> Normally Mark only changed synthetic flag on fields, nothing else should
> have changed AFAIK.
>
> Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò <il...@apache.org>
> a écrit :
>
>> Hi there,
>> with latest 3.1.3-SNAPSHOT artifacts I am getting errors while building
>> Syncope.
>>
>> In particular, we have a Maven module [1] which runs
>> openjpa-maven-plugin:enhance [2] as part of the build, and several modules
>> (like [3][4][5] and others) which are depending on [1], adding more
>> entities and also running openjpa-maven-plugin:enhance
>>
>> All this used to work fine until this morning (and still works fine with
>> OpenJPA 3.1.2 on other Syncope branches); now [1] is still working fine,
>> but building other modules give errors like as
>>
>> [ERROR]
>> /home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
>> org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not
>> abstract and does not override abstract method
>> pcSetDetachedState(java.lang.Object) in
>> org.apache.openjpa.enhance.PersistenceCapable
>>
>> Could you please shed some light? Thanks!
>> Regards.
>>
>> [1] https://github.com/apache/syncope/tree/master/core/persistence-jpa
>> [2]
>> https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
>> [3]
>> https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
>> [4]
>> https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
>> [5]
>> https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa
--
Francesco Chicchiriccò
Tirasa - Open Source Excellence
http://www.tirasa.net/
Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/
Re: Errors after recent commits
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi Francesco,
Did you try to decompile previous and current version (with jd-gui for
example) to see the diff?
Normally Mark only changed synthetic flag on fields, nothing else should
have changed AFAIK.
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le mar. 20 avr. 2021 à 15:38, Francesco Chicchiriccò <il...@apache.org>
a écrit :
> Hi there,
> with latest 3.1.3-SNAPSHOT artifacts I am getting errors while building
> Syncope.
>
> In particular, we have a Maven module [1] which runs
> openjpa-maven-plugin:enhance [2] as part of the build, and several modules
> (like [3][4][5] and others) which are depending on [1], adding more
> entities and also running openjpa-maven-plugin:enhance
>
> All this used to work fine until this morning (and still works fine with
> OpenJPA 3.1.2 on other Syncope branches); now [1] is still working fine,
> but building other modules give errors like as
>
> [ERROR]
> /home/ilgrosso/work/syncope/syncope/ext/camel/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/JPACamelRoute.java:[32,8]
> org.apache.syncope.core.persistence.jpa.entity.JPACamelRoute is not
> abstract and does not override abstract method
> pcSetDetachedState(java.lang.Object) in
> org.apache.openjpa.enhance.PersistenceCapable
>
> Could you please shed some light? Thanks!
> Regards.
>
> [1] https://github.com/apache/syncope/tree/master/core/persistence-jpa
> [2]
> https://github.com/apache/syncope/blob/master/core/persistence-jpa/pom.xml#L145-L176
> [3]
> https://github.com/apache/syncope/tree/master/core/persistence-jpa-json
> [4]
> https://github.com/apache/syncope/tree/master/ext/camel/persistence-jpa
> [5]
> https://github.com/apache/syncope/tree/master/ext/self-keymaster/persistence-jpa
>
> --
> Francesco Chicchiriccò
>
> Tirasa - Open Source Excellence
> http://www.tirasa.net/
>
> Member at The Apache Software Foundation
> Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
> http://home.apache.org/~ilgrosso/
>
>