You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ab...@apache.org on 2025/02/01 23:46:13 UTC
(pinot) 01/02: Fix NPE caused by MultiStageQueryThrottler (#14805)
This is an automated email from the ASF dual-hosted git repository.
abhioncbr pushed a commit to branch release-1.3.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit e8e10f9462c32b807b21d9c76b911b4db2e88d45
Author: Jialiang Li <jl...@linkedin.com>
AuthorDate: Mon Jan 13 18:00:29 2025 -0800
Fix NPE caused by MultiStageQueryThrottler (#14805)
---
.../org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
index 2aab062730..fa40afb2db 100644
--- a/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
+++ b/pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
@@ -406,7 +406,9 @@ public abstract class BaseBrokerStarter implements ServiceStartable {
clusterConfigChangeHandler.init(_spectatorHelixManager);
}
_clusterConfigChangeHandlers.add(_queryQuotaManager);
- _clusterConfigChangeHandlers.add(_multiStageQueryThrottler);
+ if (_multiStageQueryThrottler != null) {
+ _clusterConfigChangeHandlers.add(_multiStageQueryThrottler);
+ }
for (ClusterChangeHandler idealStateChangeHandler : _idealStateChangeHandlers) {
idealStateChangeHandler.init(_spectatorHelixManager);
}
@@ -416,7 +418,9 @@ public abstract class BaseBrokerStarter implements ServiceStartable {
}
_externalViewChangeHandlers.add(_routingManager);
_externalViewChangeHandlers.add(_queryQuotaManager);
- _externalViewChangeHandlers.add(_multiStageQueryThrottler);
+ if (_multiStageQueryThrottler != null) {
+ _externalViewChangeHandlers.add(_multiStageQueryThrottler);
+ }
for (ClusterChangeHandler instanceConfigChangeHandler : _instanceConfigChangeHandlers) {
instanceConfigChangeHandler.init(_spectatorHelixManager);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org