[GitHub] mistercrunch closed pull request #4133: BugFix(#3658)

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #4133: BugFix(#3658)
URL: https://github.com/apache/incubator-superset/pull/4133
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/connectors/sqla/views.py b/superset/connectors/sqla/views.py
index 12f9d6d555..591fcc1475 100644
--- a/superset/connectors/sqla/views.py
+++ b/superset/connectors/sqla/views.py
@@ -238,7 +238,9 @@ def pre_add(self, table):
                     get_datasource_exist_error_mgs(table.full_name))
 
         # Fail before adding if the table can't be found
-        if not table.database.has_table(table):
+        try:
+            table.get_sqla_table_object()
+        except Exception:
             raise Exception(_(
                 'Table [{}] could not be found, '
                 'please double check your '


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services