[GitHub] [arrow-datafusion] jorgecarleitao commented on a change in pull request #370: Return Vec from PredicateBuilder rather than an `Fn`

[GitBox <gi...@apache.org>]

jorgecarleitao commented on a change in pull request #370:
URL: https://github.com/apache/arrow-datafusion/pull/370#discussion_r637092118



##########
File path: datafusion/src/physical_optimizer/pruning.rs
##########
@@ -85,24 +90,24 @@ impl PruningPredicateBuilder {
         })
     }
 
-    /// Generate a predicate function used to filter based on
-    /// statistics
+    /// For each set of statistics, evalates the predicate in this
+    /// builder and returns a `bool` with the following meaning for a
+    /// container with those statistics:
+    ///
+    /// `true`: The container MAY contain rows that match the predicate
     ///
-    /// This function takes a slice of statistics as parameter, so
-    /// that DataFusion's physical expressions can be executed once
-    /// against a single RecordBatch, containing statistics arrays, on
-    /// which the physical predicate expression is executed to
-    /// generate a row group filter array.
+    /// `false`: The container definitely does NOT contain rows that match the predicate

Review comment:
       ```suggestion
       /// `false`: The container MUST NOT contain rows that match the predicate
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org