[GitHub] [hudi] YuweiXiao commented on a diff in pull request #5912: [MINOR] fix parquet max file constraint for flink bulk insert

[GitBox <gi...@apache.org>]

YuweiXiao commented on code in PR #5912:
URL: https://github.com/apache/hudi/pull/5912#discussion_r905797066


##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataParquetWriter.java:
##########
@@ -49,8 +49,7 @@ public HoodieRowDataParquetWriter(Path file, HoodieRowDataParquetConfig parquetC
     this.file = HoodieWrapperFileSystem.convertToHoodiePath(file, parquetConfig.getHadoopConf());
     this.fs = (HoodieWrapperFileSystem) this.file.getFileSystem(FSUtils.registerFileSystem(file,
         parquetConfig.getHadoopConf()));
-    this.maxFileSize = parquetConfig.getMaxFileSize()
-        + Math.round(parquetConfig.getMaxFileSize() * parquetConfig.getCompressionRatio());
+    this.maxFileSize = Math.round(parquetConfig.getMaxFileSize() * parquetConfig.getCompressionRatio());
     this.writeSupport = parquetConfig.getWriteSupport();

Review Comment:
   Hi Danny, I was referring to `HoodieAppendHandle`. I rechecked the code and found I understand it wrong. I'll close the PR, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org