You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/10 14:01:45 UTC

[GitHub] [superset] amitmiran137 commented on pull request #17344: refactor: QueryContext and QueryObject by decoupling and making it testable

amitmiran137 commented on pull request #17344:
URL: https://github.com/apache/superset/pull/17344#issuecomment-965212267


   > > It relies on the current test cases since no logic was added
   > 
   > Note that this is super risky because we don't have 100% unit test coverage.
   
   I agree , but on the other hand if we want to move towards better coverage we need to start refactoring and do separation of concerns 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org