[GitHub] [lucene] jpountz commented on a diff in pull request #12105: Rename vector float classes and methods

["jpountz (via GitHub)" <gi...@apache.org>]

jpountz commented on code in PR #12105:
URL: https://github.com/apache/lucene/pull/12105#discussion_r1084959329


##########
lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsReader.java:
##########
@@ -48,8 +50,20 @@ protected KnnVectorsReader() {}
    * Returns the {@link VectorValues} for the given {@code field}. The behavior is undefined if the
    * given field doesn't have KNN vectors enabled on its {@link FieldInfo}. The return value is
    * never {@code null}.
+   *
+   * @deprecated use {@link #getFloatVectorValues(String)} instead
+   */
+  @Deprecated
+  public VectorValues getVectorValues(String field) throws IOException {
+    return new FilterVectorValues(getFloatVectorValues(field)) {};
+  }

Review Comment:
   I consider all codec APIs experimental by nature, let's only have this bw layer one layer above, on `LeafReader`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org