[GitHub] [iceberg] stevenzwu commented on a change in pull request #1793: Flink: Support streaming reader.

[GitBox <gi...@apache.org>]

stevenzwu commented on a change in pull request #1793:
URL: https://github.com/apache/iceberg/pull/1793#discussion_r552910845



##########
File path: flink/src/main/java/org/apache/iceberg/flink/source/FlinkSource.java
##########
@@ -91,7 +89,7 @@ public Builder env(StreamExecutionEnvironment newEnv) {
     }
 
     public Builder filters(List<Expression> filters) {

Review comment:
       I have been wondering if really need to duplicate every ScanContext/Builder API in the FlinkSource. Should we just let FlinkSource builder take the ScanContext, which is constructed separately before the FlinkSource?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org