You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/08 07:20:20 UTC
[GitHub] [incubator-mxnet] zixuanweeei opened a new pull request #17996:
[MKLDNN] Support projection feature of LSTM
zixuanweeei opened a new pull request #17996: [MKLDNN] Support projection feature of LSTM
URL: https://github.com/apache/incubator-mxnet/pull/17996
## Description ##
As title.
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x ] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [x] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] Sopport projection feature using DNNL(oneDNN).
- [x] Add unit test for projection feature
- [x] Add env MXNE_USE_WEIGHT_CACHE to control the initializition behavior
## Comments ##
- Please note that MKLDNN is upgraded to v1.4-rc.
- Only support Forward pass. Backward pass has not been integrated yet.
@ciyongch @TaoLv @pengzhao-intel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #17996:
[MKLDNN] Support projection feature of LSTM
Posted by GitBox <gi...@apache.org>.
pengzhao-intel commented on issue #17996: [MKLDNN] Support projection feature of LSTM
URL: https://github.com/apache/incubator-mxnet/pull/17996#issuecomment-612547066
@zixuanweeei please help resolve the conflict :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] zixuanweeei commented on issue #17996: [MKLDNN]
Support projection feature of LSTM
Posted by GitBox <gi...@apache.org>.
zixuanweeei commented on issue #17996: [MKLDNN] Support projection feature of LSTM
URL: https://github.com/apache/incubator-mxnet/pull/17996#issuecomment-612541922
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #17996:
[MKLDNN] Support projection feature of LSTM
Posted by GitBox <gi...@apache.org>.
pengzhao-intel commented on issue #17996: [MKLDNN] Support projection feature of LSTM
URL: https://github.com/apache/incubator-mxnet/pull/17996#issuecomment-611359237
> Perhaps we need to upgrade dnnl to its v1.3 release (#17972) at first. #17872 could then be fixed, and backported to MXNet-1.7 with dnnl v1.3. This PR can be finally merged into master. @ciyongch @TaoLv @pengzhao-intel
Got it and will wait for a while.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] pengzhao-intel merged pull request #17996:
[MKLDNN] Support projection feature of LSTM
Posted by GitBox <gi...@apache.org>.
pengzhao-intel merged pull request #17996: [MKLDNN] Support projection feature of LSTM
URL: https://github.com/apache/incubator-mxnet/pull/17996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17996: [MKLDNN]
Support projection feature of LSTM
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17996: [MKLDNN] Support projection feature of LSTM
URL: https://github.com/apache/incubator-mxnet/pull/17996#issuecomment-612541930
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] zixuanweeei commented on issue #17996: [MKLDNN]
Support projection feature of LSTM
Posted by GitBox <gi...@apache.org>.
zixuanweeei commented on issue #17996: [MKLDNN] Support projection feature of LSTM
URL: https://github.com/apache/incubator-mxnet/pull/17996#issuecomment-612541863
@mxnet-bot run [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] zixuanweeei commented on issue #17996: [MKLDNN]
Support projection feature of LSTM
Posted by GitBox <gi...@apache.org>.
zixuanweeei commented on issue #17996: [MKLDNN] Support projection feature of LSTM
URL: https://github.com/apache/incubator-mxnet/pull/17996#issuecomment-610909849
> LGTM and I will merge this PR when CI passed.
Maybe we need to wait for #17972. @TaoLv Any comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17996: [MKLDNN]
Support projection feature of LSTM
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17996: [MKLDNN] Support projection feature of LSTM
URL: https://github.com/apache/incubator-mxnet/pull/17996#issuecomment-612541869
Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] zixuanweeei commented on issue #17996: [MKLDNN]
Support projection feature of LSTM
Posted by GitBox <gi...@apache.org>.
zixuanweeei commented on issue #17996: [MKLDNN] Support projection feature of LSTM
URL: https://github.com/apache/incubator-mxnet/pull/17996#issuecomment-610921948
Perhaps we need to upgrade dnnl to its v1.3 release (#17972) at first. #17872 could then be fixed, and backported to MXNet-1.7 with dnnl v1.3. This PR can be finally merged into master. @ciyongch @TaoLv @pengzhao-intel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] zixuanweeei commented on issue #17996: [MKLDNN]
Support projection feature of LSTM
Posted by GitBox <gi...@apache.org>.
zixuanweeei commented on issue #17996: [MKLDNN] Support projection feature of LSTM
URL: https://github.com/apache/incubator-mxnet/pull/17996#issuecomment-612568425
Please note that mkldnn submodule is pinned to its v1.4-rc version in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #17996:
[MKLDNN] Support projection feature of LSTM
Posted by GitBox <gi...@apache.org>.
pengzhao-intel commented on issue #17996: [MKLDNN] Support projection feature of LSTM
URL: https://github.com/apache/incubator-mxnet/pull/17996#issuecomment-612571249
> Please note that mkldnn submodule is pinned to its v1.4-rc version in this PR.
Thanks for the reminder. I think it's fine with 1.4-rc and we can update to 1.4 later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17996: [MKLDNN]
Support projection feature of LSTM
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17996: [MKLDNN] Support projection feature of LSTM
URL: https://github.com/apache/incubator-mxnet/pull/17996#issuecomment-610794944
Hey @zixuanweeei , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, miscellaneous, centos-cpu, clang, windows-gpu, unix-cpu, edge, website, centos-gpu, windows-cpu, sanity]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services