You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/25 21:55:20 UTC
[GitHub] srowen commented on issue #23890: [SPARK-26986][ML] Add JAXB
reference impl to build for Java 9+
srowen commented on issue #23890: [SPARK-26986][ML] Add JAXB reference impl to build for Java 9+
URL: https://github.com/apache/spark/pull/23890#issuecomment-467199382
I think it would be nice to trim down the new dependencies, yes. Like you I'm not sure which ones are needed for the 'write-only' use case, but this change is limited in scope to MLlib now and so would be reasonable to keep it narrow. If you have suggestions -- is there a better JAXB impl -- would be glad to hear them. That said, these deps aren't big or weird, so it's not a big deal to keep the dependency simple and not try to mess with exclusions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org