You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/09 15:40:06 UTC

[GitHub] [beam] TheNeuralBit edited a comment on pull request #14971: [BEAM-12297] Add methods to PubsubIO for reading DynamicMessage

TheNeuralBit edited a comment on pull request #14971:
URL: https://github.com/apache/beam/pull/14971#issuecomment-857811062


   Cool, thanks @zhoufek!
   
   > CC @TheNeuralBit since we recently discussed the issue of PubsubIO requiring a Java class and how we would improve that requirement for portability.
   
   Note we already have [ProtoDynamicMessageSchema](https://github.com/apache/beam/blob/master/sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoDynamicMessageSchema.java) which can make a `SchemaCoder<DynamicMesage>` given a proto descriptor. That combined with this PR could be a good avenue for making the pubsub TableProvider configurable via a proto descriptor rather than a proto class name. (CC: @apilloud @robinyqiu)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org