[jira] [Commented] (FLINK-8214) Do not use mockito for collecting results in StreamMockEnvironment

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315970#comment-16315970 ] 

ASF GitHub Bot commented on FLINK-8214:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/5254

    [FLINK-8214][streaming-tests] Collect results into proper mock in StreamMockEnvironment

    ## What is the purpose of the change
    
    Collect results into proper mock in `StreamMockEnvironment`. This PR is based on #5253.
    
    Please note: this is @pnowojski's commit taken out of #5105 which I have reviewed separately, so from my side, we're good to go.
    
    ## Brief change log
    
    - collect results into proper mock in `StreamMockEnvironment`
    
    ## Verifying this change
    
    This change is already covered by existing tests, since a test (tool) itself is changed.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **not applicable**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-8214

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5254.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5254
    
----
commit 82e3fa72af108c92a179ea441bf67e8b2e494d23
Author: Zhijiang <wa...@...>
Date:   2017-08-10T05:29:13Z

    [FLINK-7406][network] Implement Netty receiver incoming pipeline for credit-based

commit 7c364f84df0969cc135c5a9835681c9d2d8e678a
Author: Zhijiang <wa...@...>
Date:   2017-09-28T15:39:26Z

    [FLINK-7416][network] Implement Netty receiver outgoing pipeline for credit-based

commit cfe85ced9a4c5bbc342e527d8b59e17ecf1cdad6
Author: Piotr Nowojski <pi...@...>
Date:   2017-12-18T14:26:20Z

    [hotfix][network] Drop redundant this reference usages

commit 1c015dd3eebe7171606fa1d90045733eac2c6b75
Author: Piotr Nowojski <pi...@...>
Date:   2017-12-01T10:14:06Z

    [FLINK-8208][network-tests] Reduce mockito usage in RecordWriterTest

commit 8101dc8f422a815bead8cedf92bd6a361d27ec44
Author: Piotr Nowojski <pi...@...>
Date:   2017-12-04T14:08:12Z

    [hotfix][network-tests] Simplify TestPooledBufferProvider

commit bdcce927bd0b15739fa7be3da6f5f656fbb36790
Author: Piotr Nowojski <pi...@...>
Date:   2017-12-04T14:13:06Z

    [FLINK-8209][network-tests] Make LocalBufferPoolDestroyTest less implementation dependent

commit dc5427696476d898da6ece19c7e05f6063ed98ae
Author: Piotr Nowojski <pi...@...>
Date:   2017-12-04T14:13:57Z

    [FLINK-8207][network-tests] Unify TestInfiniteBufferProvider and TestPooledBufferProvider

commit 9e55e2c2f1bad338825e9847cbfe64a2de5b6172
Author: Piotr Nowojski <pi...@...>
Date:   2017-12-05T08:36:55Z

    [FLINK-8210][network-tests] Collect results into proper mock in MockEnvironment

commit b3752d2b113ed6e4aa9d78cd0aaf3115cfe7776a
Author: Piotr Nowojski <pi...@...>
Date:   2017-12-05T08:42:19Z

    [hotfix][runtime] Remove unused methods

commit 52bd79408433821d5ca1c79e1afd09e046ed6e2b
Author: Piotr Nowojski <pi...@...>
Date:   2017-12-06T15:02:26Z

    [FLINK-8214][streaming-tests] Collect results into proper mock in StreamMockEnvironment

----


> Do not use mockito for collecting results in StreamMockEnvironment
> ------------------------------------------------------------------
>
>                 Key: FLINK-8214
>                 URL: https://issues.apache.org/jira/browse/FLINK-8214
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)