You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sedona.apache.org by "petern48 (via GitHub)" <gi...@apache.org> on 2025/07/16 21:57:40 UTC
[PR] [GH-2112] Geopandas.GeoSeries: Implement `to_wkt` and `to_wkb` [sedona]
petern48 opened a new pull request, #2113:
URL: https://github.com/apache/sedona/pull/2113
## Did you read the Contributor Guide?
- Yes, I have read the [Contributor Rules](https://sedona.apache.org/latest/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest/community/develop/)
## Is this PR related to a ticket?
- Yes, and the PR name follows the format `[GH-XXX] my subject`. Closes #2112
## What changes were proposed in this PR?
Implemented to_wkt and to_wkb
## How was this patch tested?
Added tests
## Did this PR include necessary documentation updates?
- Yes, I have updated the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GH-2112] Geopandas.GeoSeries: Implement `to_wkt` and `to_wkb` [sedona]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #2113:
URL: https://github.com/apache/sedona/pull/2113#discussion_r2213641297
##########
python/tests/geopandas/test_geoseries.py:
##########
@@ -331,10 +332,73 @@ def test_to_json(self):
pass
def test_to_wkb(self):
- pass
+ if parse_version(shapely.__version__) < parse_version("2.0.0"):
+ return
Review Comment:
[nitpick] Returning silently in a test can hide skipped cases without reporting. Use `pytest.skip("reason")` to clearly mark tests as skipped when the shapely version is below the required threshold.
```suggestion
pytest.skip("Shapely version must be 2.0.0 or higher for this test.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GH-2112] Geopandas.GeoSeries: Implement `to_wkt` and `to_wkb` [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #2113:
URL: https://github.com/apache/sedona/pull/2113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org