[jira] [Commented] (PHOENIX-3413) Ineffective null check in LiteralExpression#newConstant()

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-3413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15855425#comment-15855425 ] 

Hadoop QA commented on PHOENIX-3413:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12851302/PHOENIX-3413.3.patch
  against master branch at commit 3519b3b549ac05a2ec0713ba94077cf4c6c2fe20.
  ATTACHMENT ID: 12851302

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 43 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 2 release audit warnings (more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/755//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/755//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/755//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/755//console

This message is automatically generated.

> Ineffective null check in LiteralExpression#newConstant()
> ---------------------------------------------------------
>
>                 Key: PHOENIX-3413
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3413
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.9.1
>            Reporter: Ted Yu
>            Assignee: Kevin Liew
>            Priority: Minor
>             Fix For: 4.10.0
>
>         Attachments: PHOENIX-3413.2.patch, PHOENIX-3413.3.patch, PHOENIX-3413.patch
>
>
> {code}
>         if (maxLength == null) {
>             maxLength = type == null || !type.isFixedWidth() ? null : type.getMaxLength(value);
>         }
> {code}
> The null check for type is ineffective - type is de-referenced in various places prior to the above check.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)