You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by devheroo <gi...@git.apache.org> on 2016/04/20 21:19:00 UTC
[GitHub] lucenenet pull request: replace InstanceNotFoundException to allow...
GitHub user devheroo opened a pull request:
https://github.com/apache/lucenenet/pull/167
replace InstanceNotFoundException to allow building on Mono
It will be great to keep LuceneNet cross platform and compatible with Mono.
This is just a simple fix to make the build pass on Mono\Linux.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/devheroo/lucenenet master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/167.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #167
----
commit 4674916f148d61843f293175613f0b83c66cbe2e
Author: devheroo <de...@yandex.com>
Date: 2016-04-20T19:09:09Z
replace InstanceNotFoundException with the base Exception class to allow building on Mono and Linux
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: replace InstanceNotFoundException to allow...
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on a diff in the pull request:
https://github.com/apache/lucenenet/pull/167#discussion_r60710792
--- Diff: src/Lucene.Net.Facet/Taxonomy/WriterCache/CollisionMap.cs ---
@@ -261,7 +261,7 @@ public Entry Next()
Entry e = this.next_Renamed;
if (e == null)
{
- throw new InstanceNotFoundException();
+ throw new Exception("InstanceNotFoundException");
--- End diff --
Use `InvalidOperationException` or whatever Exception .NET IEnumerator throws on `Next` that fails
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: replace InstanceNotFoundException to allow...
Posted by devheroo <gi...@git.apache.org>.
Github user devheroo commented on the pull request:
https://github.com/apache/lucenenet/pull/167#issuecomment-213473241
Thanks for the tip , I made the change regarding the InvalidOperationException and also I had to rename a file path inside Lucene.Net.Codecs.Tests.csproj because files names are case sensitive in Linux and build wont pass without making this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: replace InstanceNotFoundException to allow...
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/167#issuecomment-213343394
Thanks! I've made a comment on the Exception type used
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: replace InstanceNotFoundException to allow...
Posted by devheroo <gi...@git.apache.org>.
Github user devheroo commented on the pull request:
https://github.com/apache/lucenenet/pull/167#issuecomment-213888353
Thanks, that make sense, I will follow your suggestion next time :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: replace InstanceNotFoundException to allow...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucenenet/pull/167
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: replace InstanceNotFoundException to allow...
Posted by devheroo <gi...@git.apache.org>.
GitHub user devheroo reopened a pull request:
https://github.com/apache/lucenenet/pull/167
replace InstanceNotFoundException to allow building on Mono
It will be great to keep LuceneNet cross platform and compatible with Mono.
This is just a simple fix to make the build pass on Mono\Linux.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/devheroo/lucenenet master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucenenet/pull/167.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #167
----
commit 4674916f148d61843f293175613f0b83c66cbe2e
Author: devheroo <de...@yandex.com>
Date: 2016-04-20T19:09:09Z
replace InstanceNotFoundException with the base Exception class to allow building on Mono and Linux
commit 9a606772d106735d1a008fa986bc4c37bc6db0cb
Author: devheroo <de...@yandex.com>
Date: 2016-04-22T15:18:02Z
fix build on mono/linux where files names are case senstive
commit e0e42f464cc9644f71d06bfcada8a3e9bfab4394
Author: devheroo <de...@yandex.com>
Date: 2016-04-22T15:20:35Z
use InvalidOperationException as suggest by Itamar to pass build on mono
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: replace InstanceNotFoundException to allow...
Posted by devheroo <gi...@git.apache.org>.
Github user devheroo closed the pull request at:
https://github.com/apache/lucenenet/pull/167
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] lucenenet pull request: replace InstanceNotFoundException to allow...
Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the pull request:
https://github.com/apache/lucenenet/pull/167#issuecomment-213849508
Thanks, merged. On your next PR, please work on a branch, it is an ill practice in git to merge from someone else's master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---