You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/25 19:59:13 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8648:
Prettify the frontend code
codecov-io edited a comment on issue #8648: Prettify the frontend code
URL: https://github.com/apache/incubator-superset/pull/8648#issuecomment-558316666
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8648?src=pr&el=h1) Report
> Merging [#8648](https://codecov.io/gh/apache/incubator-superset/pull/8648?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/acf0753504095a5c0e320b049370aaf6f04e5a4f?src=pr&el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `56.61%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8648?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8648 +/- ##
==========================================
- Coverage 65.76% 65.57% -0.19%
==========================================
Files 482 482
Lines 23824 24073 +249
Branches 2594 2764 +170
==========================================
+ Hits 15667 15787 +120
- Misses 7984 8106 +122
- Partials 173 180 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8648?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/explore/components/controls/SpatialControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8648/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvU3BhdGlhbENvbnRyb2wuanN4) | `6.66% <ø> (ø)` | :arrow_up: |
| [...src/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8648/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvTWV0cmljc0NvbnRyb2wuanN4) | `81.43% <ø> (+1.3%)` | :arrow_up: |
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8648/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvVml6VHlwZUNvbnRyb2wuanN4) | `76.92% <ø> (-1.93%)` | :arrow_down: |
| [.../assets/src/dashboard/containers/DashboardGrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8648/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9EYXNoYm9hcmRHcmlkLmpzeA==) | `100% <ø> (ø)` | :arrow_up: |
| [...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8648/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvU2VsZWN0QXN5bmNDb250cm9sLmpzeA==) | `29.41% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8648/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvQXBwLmpzeA==) | `0% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/components/Menu/MenuObject.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8648/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL01lbnUvTWVudU9iamVjdC5qc3g=) | `20% <ø> (ø)` | :arrow_up: |
| [...rc/explore/components/controls/TextAreaControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8648/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvVGV4dEFyZWFDb250cm9sLmpzeA==) | `86.95% <ø> (ø)` | :arrow_up: |
| [.../assets/src/explore/components/AggregateOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8648/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvQWdncmVnYXRlT3B0aW9uLmpzeA==) | `100% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8648/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydENvbnRhaW5lci5qc3g=) | `0% <ø> (ø)` | :arrow_up: |
| ... and [188 more](https://codecov.io/gh/apache/incubator-superset/pull/8648/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8648?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8648?src=pr&el=footer). Last update [acf0753...3b0d442](https://codecov.io/gh/apache/incubator-superset/pull/8648?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org