You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Thomas Wöckinger (Jira)" <ji...@apache.org> on 2019/09/14 08:00:00 UTC

[jira] [Commented] (SOLR-13739) Managed resource observers have to be added only once

    [ https://issues.apache.org/jira/browse/SOLR-13739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929716#comment-16929716 ] 

Thomas Wöckinger commented on SOLR-13739:
-----------------------------------------

Thanks for fast review and your input!

> Managed resource observers have to be added only once
> -----------------------------------------------------
>
>                 Key: SOLR-13739
>                 URL: https://issues.apache.org/jira/browse/SOLR-13739
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Server
>    Affects Versions: 8.0, 8.1, master (9.0), 8.2, 8.1.1
>            Reporter: Thomas Wöckinger
>            Assignee: David Smiley
>            Priority: Major
>              Labels: easyfix, performance, pull-request-available, ready-to-commit
>             Fix For: 8.3
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> On huge schema modifications, mostly happen due to creation of a new collection, the same observer instance of an ResourceLoaderAware component is added again and again.
> This leads to a runtime behaviour of n²/2 where n is is the number of schema operation multiplied by ResourceLoaderAware components instead of the number of containing ResourceLoaderAware components.
> E.g. If you have 1000 schema operations and 2 ResourceLoaderAware components this leads to 500000 operations instead of 2000.
> Even worse the corresponding resource is registered again and again, which can take some time e.g. ManagedSynonymGraphFilterFactory needs about 5s on each call (depending on the size of synonyms).



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org