You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/11 11:27:06 UTC
[GitHub] [dolphinscheduler] huangchenguang123 opened a new pull request, #9995: [Fix-9990] fix development-environment-setup.md's outdate description
huangchenguang123 opened a new pull request, #9995:
URL: https://github.com/apache/dolphinscheduler/pull/9995
part of #9990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huangchenguang123 commented on a diff in pull request #9995: [Fix-9990] fix development-environment-setup.md's outdate description
Posted by GitBox <gi...@apache.org>.
huangchenguang123 commented on code in PR #9995:
URL: https://github.com/apache/dolphinscheduler/pull/9995#discussion_r873184076
##########
docs/docs/en/development/development-environment-setup.md:
##########
@@ -5,10 +5,9 @@
Before setting up the DolphinScheduler development environment, please make sure you have installed the software as below:
* [Git](https://git-scm.com/downloads): DolphinScheduler version control system
-* [JDK](https://www.oracle.com/technetwork/java/javase/downloads/index.html): DolphinScheduler backend language
+* [JDK](https://www.oracle.com/technetwork/java/javase/downloads/index.html): DolphinScheduler backend language, have to use version after JDK 1.8
* [Maven](http://maven.apache.org/download.cgi): Java Package Management System
-* [Node](https://nodejs.org/en/download): DolphinScheduler frontend
- language
+* [Node12.20.2](https://nodejs.org/en/download): DolphinScheduler frontend
Review Comment:
I have modified the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] huangchenguang123 commented on a diff in pull request #9995: [Fix-9990] fix development-environment-setup.md's outdate description
Posted by GitBox <gi...@apache.org>.
huangchenguang123 commented on code in PR #9995:
URL: https://github.com/apache/dolphinscheduler/pull/9995#discussion_r872939465
##########
docs/docs/en/development/development-environment-setup.md:
##########
@@ -5,10 +5,9 @@
Before setting up the DolphinScheduler development environment, please make sure you have installed the software as below:
* [Git](https://git-scm.com/downloads): DolphinScheduler version control system
-* [JDK](https://www.oracle.com/technetwork/java/javase/downloads/index.html): DolphinScheduler backend language
+* [JDK1.8](https://www.oracle.com/technetwork/java/javase/downloads/index.html): DolphinScheduler backend language
Review Comment:
i wlii fix it.
##########
docs/docs/en/development/development-environment-setup.md:
##########
@@ -52,7 +49,7 @@ Find the class `org.apache.dolphinscheduler.server.StandaloneServer` in Intellij
### Start frontend server
-Install frontend dependencies and run it
+Install frontend dependencies and run it, you can see frontend-development.md
Review Comment:
i wlii fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9995: [Fix-9990] fix development-environment-setup.md's outdate description
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #9995:
URL: https://github.com/apache/dolphinscheduler/pull/9995#discussion_r872516954
##########
docs/docs/en/development/development-environment-setup.md:
##########
@@ -5,10 +5,9 @@
Before setting up the DolphinScheduler development environment, please make sure you have installed the software as below:
* [Git](https://git-scm.com/downloads): DolphinScheduler version control system
-* [JDK](https://www.oracle.com/technetwork/java/javase/downloads/index.html): DolphinScheduler backend language
+* [JDK1.8](https://www.oracle.com/technetwork/java/javase/downloads/index.html): DolphinScheduler backend language
Review Comment:
I prefer using content in the tail of this line, because the link https://www.oracle.com/technetwork/java/javase/downloads/index.html could download all version of jdk, and is not specific to version 1.8. same as `Node`
```suggestion
* [JDK](https://www.oracle.com/technetwork/java/javase/downloads/index.html): DolphinScheduler backend language, have to use version after JDK 1.8
```
##########
docs/docs/en/development/development-environment-setup.md:
##########
@@ -52,7 +49,7 @@ Find the class `org.apache.dolphinscheduler.server.StandaloneServer` in Intellij
### Start frontend server
-Install frontend dependencies and run it
+Install frontend dependencies and run it, you can see frontend-development.md
Review Comment:
I think we should add content after running front end command(in L59)
```md
> Note: You can see more detail about the frontend setting in [frontend development](./frontend-development.md)
```
##########
docs/docs/en/development/development-environment-setup.md:
##########
@@ -52,7 +49,7 @@ Find the class `org.apache.dolphinscheduler.server.StandaloneServer` in Intellij
### Start frontend server
-Install frontend dependencies and run it
+Install frontend dependencies and run it, you can see frontend-development.md
Review Comment:
```suggestion
Install frontend dependencies and run it
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #9995: [Fix-9990] fix development-environment-setup.md's outdate description
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #9995:
URL: https://github.com/apache/dolphinscheduler/pull/9995#discussion_r873164756
##########
docs/docs/en/development/development-environment-setup.md:
##########
@@ -5,10 +5,9 @@
Before setting up the DolphinScheduler development environment, please make sure you have installed the software as below:
* [Git](https://git-scm.com/downloads): DolphinScheduler version control system
-* [JDK](https://www.oracle.com/technetwork/java/javase/downloads/index.html): DolphinScheduler backend language
+* [JDK](https://www.oracle.com/technetwork/java/javase/downloads/index.html): DolphinScheduler backend language, have to use version after JDK 1.8
* [Maven](http://maven.apache.org/download.cgi): Java Package Management System
-* [Node](https://nodejs.org/en/download): DolphinScheduler frontend
- language
+* [Node12.20.2](https://nodejs.org/en/download): DolphinScheduler frontend
Review Comment:
You should change `Node` as you do to JDK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #9995: [Fix-9990] fix development-environment-setup.md's outdate description
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #9995:
URL: https://github.com/apache/dolphinscheduler/pull/9995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org