You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2020/02/26 09:37:03 UTC
[GitHub] [wicket] reiern70 commented on a change in pull request #409:
[WICKET-6750] allow to abort currently executing AJAX request
reiern70 commented on a change in pull request #409: [WICKET-6750] allow to abort currently executing AJAX request
URL: https://github.com/apache/wicket/pull/409#discussion_r384373648
##########
File path: wicket-core/src/main/java/org/apache/wicket/ajax/res/js/wicket-ajax-jquery.js
##########
@@ -547,13 +576,29 @@
*/
ajax: function (attrs) {
this._initializeDefaults(attrs);
-
var res = Wicket.channelManager.schedule(attrs.ch, Wicket.bind(function () {
this.doAjax(attrs);
}, this));
return res !== null ? res: true;
},
+ /**
+ * Aborts current AJAX request, if any is running, for default channel.
+ * WARNING! Mind that this does not implies and server immediately will know about
Review comment:
> This does not imply that the server will immediately know about that? Is it what you're trying to tell?
>
> I think this comment needs rewording.
What I mean is "there is not reliable way to tell the server stop what I asked you to do". In case of upload stream will be broken and upload halted with a server side exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services