(spark-connect-rust) branch master updated: [SPARK-59110][FOLLOWUP] Fix Rust test call sites for variadic concat_ws/format_string

[gu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

HyukjinKwon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark-connect-rust.git


The following commit(s) were added to refs/heads/master by this push:
     new cf4b1fb  [SPARK-59110][FOLLOWUP] Fix Rust test call sites for variadic concat_ws/format_string
cf4b1fb is described below

commit cf4b1fb0d31e8dc20cf96345073b81b28a16e3f4
Author: Hyukjin Kwon <hy...@databricks.com>
AuthorDate: Sat Aug 29 22:13:59 2026 +0900

    [SPARK-59110][FOLLOWUP] Fix Rust test call sites for variadic concat_ws/format_string
    
    Making concat_ws/format_string variadic changed their signature from a single
    Column to an iterator, breaking two unit-test call sites and two functions_golden
    call sites that passed a single Column (`cargo build --all-targets` / the "Rust
    build and test" CI job failed to compile). Pass a one-element array so the built
    expression is unchanged.
    
    Co-authored-by: Isaac <no...@databricks.com>
---
 crates/spark-connect/src/functions.rs          | 4 ++--
 crates/spark-connect/tests/functions_golden.rs | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/crates/spark-connect/src/functions.rs b/crates/spark-connect/src/functions.rs
index cb3dae8..6da75b7 100644
--- a/crates/spark-connect/src/functions.rs
+++ b/crates/spark-connect/src/functions.rs
@@ -4879,7 +4879,7 @@ mod tests {
             collation(c1.clone()),
             collect_list(c1.clone()),
             collect_set(c1.clone()),
-            concat_ws(c1.clone()),
+            concat_ws([c1.clone()]),
             cos(c1.clone()),
             cosh(c1.clone()),
             cot(c1.clone()),
@@ -4911,7 +4911,7 @@ mod tests {
             first_value(c1.clone()),
             flatten(c1.clone()),
             floor(c1.clone()),
-            format_string(c1.clone()),
+            format_string([c1.clone()]),
             grouping(c1.clone()),
             hex(c1.clone()),
             hll_sketch_agg(c1.clone()),
diff --git a/crates/spark-connect/tests/functions_golden.rs b/crates/spark-connect/tests/functions_golden.rs
index 9b9405e..e0c1348 100644
--- a/crates/spark-connect/tests/functions_golden.rs
+++ b/crates/spark-connect/tests/functions_golden.rs
@@ -200,7 +200,7 @@ fn all_golden_function_cases_pass() {
         ("collect_set", collect_set(a())),
         ("column", column("x")),
         ("concat", concat(Vec::<Column>::new())),
-        ("concat_ws", concat_ws(a())),
+        ("concat_ws", concat_ws([a()])),
         ("contains", contains(a(), b())),
         ("conv", conv(a(), b(), c())),
         ("convert_timezone", convert_timezone(a(), b(), c())),
@@ -269,7 +269,7 @@ fn all_golden_function_cases_pass() {
         ("flatten", flatten(a())),
         ("floor", floor(a())),
         ("format_number", format_number(a(), b())),
-        ("format_string", format_string(a())),
+        ("format_string", format_string([a()])),
         ("from_csv", from_csv(a(), b())),
         ("from_json", from_json(a(), b())),
         ("from_unixtime", from_unixtime(a())),


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org