[GitHub] [skywalking-website] wu-sheng commented on a change in pull request #215: Integrate project documentations into the website

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #215:
URL: https://github.com/apache/skywalking-website/pull/215#discussion_r574912153



##########
File path: data/docs.yml
##########
@@ -6,11 +6,18 @@
       description: The documentation including core concepts, protocols, Java agent, OAP backend, and UI
       user: apache
       repo: skywalking
+      gitUrl: https://github.com/apache/skywalking.git
       docs:
         - version: v8.4.0
-          link: https://github.com/apache/skywalking/tree/v8.4.0/docs
+          link: /docs/main/v8.4.0/readme/
+          commitId: bf8574b07f01dcff681994e5fec599fe2bb7887b
+          localPath: /content/docs/main/v8.4.0
+          sidebarConfigFile: main_8_4_0
         - version: v8.3.0
-          link: https://github.com/apache/skywalking/tree/8.3.0/docs-hotfix/docs
+          link: /docs/main/v8.3.0/readme/
+          commitId: 7748639cf6be88cd629fb757cc5994b7a9184cd1
+          localPath: /content/docs/main/v8.3.0
+          sidebarConfigFile: main_8_3_0

Review comment:
       We should remove this

##########
File path: data/docs.yml
##########
@@ -35,6 +42,7 @@
       description: SkyWalking Nginx Agent provides the native tracing capability for Nginx powered by Nginx LUA module.
       user: apache
       repo: skywalking-nginx-lua
+      gitUrl: https://github.com/apache/skywalking-nginx-lua.git

Review comment:
       Why add this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org