You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/15 08:18:49 UTC

[GitHub] [spark] HeartSaVioR commented on pull request #28831: [SPARK-31993][SQL] Don't split code blocks in generated code for 'concat_ws' for mixed string/array types of columns

HeartSaVioR commented on pull request #28831:
URL: https://github.com/apache/spark/pull/28831#issuecomment-643978420


   There might be still a chance to compose these all parts into one and pass to splitExpressionsWithCurrentInputs, but it requires rewrite of code because there're two different "state" variables instead of one. It would be nice if we are OK to leave up the optimization to the separate PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org