You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2021/02/11 09:56:17 UTC

[GitHub] [jackrabbit-oak] dcokan commented on a change in pull request #270: OAK-9351: Optionally log thread dump on lease update failure

dcokan commented on a change in pull request #270:
URL: https://github.com/apache/jackrabbit-oak/pull/270#discussion_r574371022



##########
File path: oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java
##########
@@ -466,6 +471,19 @@ private void registerNodeStore() throws IOException {
                     
                     @Override
                     public void handleLeaseFailure() {

Review comment:
       Hi @mbaedke this is invoked post the datasource is unbound from the DocumentNodeStore. My point is it seems that this handler callback is invoked after the clean up already started. What if we would invoke it in `ClusterNodeInfo.performLeaseCheck` when it notices the slowness?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org