You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/08 13:00:32 UTC
[GitHub] [pulsar] sijia-w opened a new pull request #9530: [DOCS] - Update the topic-level policies
sijia-w opened a new pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530
Fixes #8899
Update the description of the newly added topic-level policies in #2688.
This pr fixes https://github.com/apache/pulsar/pull/9161, the branch of which was deleted incorrectly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
sijia-w commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r572731982
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2267,35 +2230,28 @@ Options
|`-l`, `--ledgerId`|The ledger id |0|
|`-e`, `--entryId`|The entry id |0|
-### `get-backlog-quotas`
-Get the backlog quota policies for a topic.
+### `enable-deduplication`
+Enable a deduplication policy for a topic.
Usage
```bash
-$ pulsar-admin topics get-backlog-quotas tenant/namespace/topic
+$ pulsar-admin topics enable-deduplication tenant/namespace/topic
```
-### `set-backlog-quota`
-Set a backlog quota policy for a topic.
-
-Usage
-```bash
-$ pulsar-admin topics set-backlog-quota tenant/namespace/topic options
-=======
-### `get-deduplication`
-Get a deduplication policy for a topic.
+### `disable-deduplication`
Review comment:
@315157973 Just wanna double confirm
all these commands are deprecated, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
315157973 commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r581927132
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2369,20 +2348,279 @@ Remove the message TTL for a topic.
Usage
```bash
-$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
-=======
+$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
+```
+
+Options
+|Flag|Description|Default|
|---|---|---|
|`--enable`, `-e`|Enable message deduplication on the specified topic.|false|
|`--disable`, `-d`|Disable message deduplication on the specified topic.|false|
+### `get-deduplication`
+Get a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-deduplication tenant/namespace/topic
+```
+
+### `set-deduplication`
+Set a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-deduplication tenant/namespace/topic options
Review comment:
Do we now support tenant-level policies? Seems not merged yet.
https://github.com/apache/pulsar/wiki/PIP-51%3A-Tenant-policy-support
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
sijia-w commented on pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#issuecomment-785802409
@315157973 @Huanli-Meng Please approve if there is nothing to update further. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
315157973 commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r573380210
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2267,35 +2230,28 @@ Options
|`-l`, `--ledgerId`|The ledger id |0|
|`-e`, `--entryId`|The entry id |0|
-### `get-backlog-quotas`
-Get the backlog quota policies for a topic.
+### `enable-deduplication`
+Enable a deduplication policy for a topic.
Usage
```bash
-$ pulsar-admin topics get-backlog-quotas tenant/namespace/topic
+$ pulsar-admin topics enable-deduplication tenant/namespace/topic
```
-### `set-backlog-quota`
-Set a backlog quota policy for a topic.
-
-Usage
-```bash
-$ pulsar-admin topics set-backlog-quota tenant/namespace/topic options
-=======
-### `get-deduplication`
-Get a deduplication policy for a topic.
+### `disable-deduplication`
Review comment:
Based the code on the master branch, in the issue mentioned by @Jennifer88huang , the command names of topic-level and namespace-level have been unified, https://github.com/apache/pulsar/issues/9205
E.g:
The topic level `get-maxProducers` has been changed to `get-max-producers`, and `get-maxProducers` is marked as deprecated.
The deprecated command will not be deleted immediately, it can still be used, but it will no longer be displayed when user enters `--help`, and may be deleted at some point in the future.
Since the code is in the master branch, one thing that needs to be confirmed is whether this PR will be cherry-picked to 2.7.x and the document should correspond to it @codelipenghui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r582702092
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2369,20 +2348,279 @@ Remove the message TTL for a topic.
Usage
```bash
-$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
-=======
+$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
+```
+
+Options
+|Flag|Description|Default|
|---|---|---|
|`--enable`, `-e`|Enable message deduplication on the specified topic.|false|
|`--disable`, `-d`|Disable message deduplication on the specified topic.|false|
+### `get-deduplication`
+Get a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-deduplication tenant/namespace/topic
+```
+
+### `set-deduplication`
+Set a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-deduplication tenant/namespace/topic options
+```
+
### `remove-deduplication`
-Remove a deduplication policy from a topic.
+Remove a deduplication policy for a topic.
Usage
```bash
$ pulsar-admin topics remove-deduplication tenant/namespace/topic
```
+### `get-retention`
+Get the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-retention tenant/namespace/topic
+```
+
+### `set-retention`
+Set the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-retention tenant/namespace/topic options
+```
+
+### `remove-retention`
+Remove the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-retention tenant/namespace/topic
+```
+
+### `get-dispatch-rate`
+Get the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-dispatch-rate tenant/namespace/topic
+```
+
+### `set-dispatch-rate`
+Set the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-dispatch-rate tenant/namespace/topic options
+```
+
+### `remove-dispatch-rate`
+Remove the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-dispatch-rate tenant/namespace/topic
+```
+
+### `get-max-unacked-messages-per-subscription`
+Get the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-max-unacked-messages-per-subscription tenant/namespace/topic
+```
+
+### `set-max-unacked-messages-per-subscription`
+Set the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-max-unacked-messages-per-subscription tenant/namespace/topic options
+```
+
+### `remove-max-unacked-messages-per-subscription`
+Remove the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-max-unacked-messages-per-subscription tenant/namespace/topic
+```
+
+### `get-max-unacked-messages-per-consumer`
+Get the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-max-unacked-messages-per-consumer tenant/namespace/topic
+```
+
+### `set-max-unacked-messages-per-consumer`
+Set the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-max-unacked-messages-per-consumer tenant/namespace/topic options
+```
+
+### `remove-max-unacked-messages-per-consumer`
+Remove the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-max-unacked-messages-per-consumer tenant/namespace/topic
+```
+
+### `get-delayed-delivery`
+Get the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-delayed-delivery tenant/namespace/topic
+```
+
+### `set-delayed-delivery`
+Set the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-delayed-delivery tenant/namespace/topic options
+```
+
+### `remove-delayed-delivery`
+Remove the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-delayed-delivery tenant/namespace/topic
+```
+
+### `get-max-producers`
+Get the maximum number of Producers for a topic.
Review comment:
```suggestion
Get the maximum number of producers for a topic.
```
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2369,20 +2348,279 @@ Remove the message TTL for a topic.
Usage
```bash
-$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
-=======
+$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
+```
+
+Options
+|Flag|Description|Default|
|---|---|---|
|`--enable`, `-e`|Enable message deduplication on the specified topic.|false|
|`--disable`, `-d`|Disable message deduplication on the specified topic.|false|
+### `get-deduplication`
+Get a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-deduplication tenant/namespace/topic
+```
+
+### `set-deduplication`
+Set a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-deduplication tenant/namespace/topic options
+```
+
### `remove-deduplication`
-Remove a deduplication policy from a topic.
+Remove a deduplication policy for a topic.
Usage
```bash
$ pulsar-admin topics remove-deduplication tenant/namespace/topic
```
+### `get-retention`
+Get the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-retention tenant/namespace/topic
+```
+
+### `set-retention`
+Set the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-retention tenant/namespace/topic options
+```
+
+### `remove-retention`
+Remove the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-retention tenant/namespace/topic
+```
+
+### `get-dispatch-rate`
+Get the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-dispatch-rate tenant/namespace/topic
+```
+
+### `set-dispatch-rate`
+Set the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-dispatch-rate tenant/namespace/topic options
+```
+
+### `remove-dispatch-rate`
+Remove the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-dispatch-rate tenant/namespace/topic
+```
+
+### `get-max-unacked-messages-per-subscription`
+Get the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-max-unacked-messages-per-subscription tenant/namespace/topic
+```
+
+### `set-max-unacked-messages-per-subscription`
+Set the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-max-unacked-messages-per-subscription tenant/namespace/topic options
+```
+
+### `remove-max-unacked-messages-per-subscription`
+Remove the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-max-unacked-messages-per-subscription tenant/namespace/topic
+```
+
+### `get-max-unacked-messages-per-consumer`
+Get the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-max-unacked-messages-per-consumer tenant/namespace/topic
+```
+
+### `set-max-unacked-messages-per-consumer`
+Set the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-max-unacked-messages-per-consumer tenant/namespace/topic options
+```
+
+### `remove-max-unacked-messages-per-consumer`
+Remove the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-max-unacked-messages-per-consumer tenant/namespace/topic
+```
+
+### `get-delayed-delivery`
+Get the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-delayed-delivery tenant/namespace/topic
+```
+
+### `set-delayed-delivery`
+Set the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-delayed-delivery tenant/namespace/topic options
+```
+
+### `remove-delayed-delivery`
+Remove the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-delayed-delivery tenant/namespace/topic
+```
+
+### `get-max-producers`
+Get the maximum number of Producers for a topic.
Review comment:
same for the following.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#issuecomment-784253439
@zymap thank you for your reminder.
@sijia-w it seems that there are sth not quite correct with the latest update. Maybe we can sync on it when you're available. @315157973 you can also check the PR content. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
sijia-w commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r582070827
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2369,20 +2348,279 @@ Remove the message TTL for a topic.
Usage
```bash
-$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
-=======
+$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
+```
+
+Options
+|Flag|Description|Default|
|---|---|---|
|`--enable`, `-e`|Enable message deduplication on the specified topic.|false|
|`--disable`, `-d`|Disable message deduplication on the specified topic.|false|
+### `get-deduplication`
+Get a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-deduplication tenant/namespace/topic
+```
+
+### `set-deduplication`
+Set a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-deduplication tenant/namespace/topic options
+```
+
### `remove-deduplication`
-Remove a deduplication policy from a topic.
+Remove a deduplication policy for a topic.
Usage
```bash
$ pulsar-admin topics remove-deduplication tenant/namespace/topic
```
+### `get-retention`
+Get the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-retention tenant/namespace/topic
+```
+
+### `set-retention`
+Set the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-retention tenant/namespace/topic options
Review comment:
There are no examples for the commands on the namespace level. So probably it's unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
sijia-w commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r582070199
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2369,20 +2348,279 @@ Remove the message TTL for a topic.
Usage
```bash
-$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
-=======
+$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
+```
+
+Options
+|Flag|Description|Default|
|---|---|---|
|`--enable`, `-e`|Enable message deduplication on the specified topic.|false|
|`--disable`, `-d`|Disable message deduplication on the specified topic.|false|
+### `get-deduplication`
+Get a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-deduplication tenant/namespace/topic
+```
+
+### `set-deduplication`
+Set a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-deduplication tenant/namespace/topic options
+```
+
### `remove-deduplication`
-Remove a deduplication policy from a topic.
+Remove a deduplication policy for a topic.
Usage
```bash
$ pulsar-admin topics remove-deduplication tenant/namespace/topic
```
+### `get-retention`
+Get the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-retention tenant/namespace/topic
+```
+
+### `set-retention`
+Set the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-retention tenant/namespace/topic options
+```
+
+### `remove-retention`
+Remove the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-retention tenant/namespace/topic
+```
+
+### `get-dispatch-rate`
+Get the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-dispatch-rate tenant/namespace/topic
+```
+
+### `set-dispatch-rate`
+Set the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-dispatch-rate tenant/namespace/topic options
+```
+
+### `remove-dispatch-rate`
+Remove the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-dispatch-rate tenant/namespace/topic
+```
+
+### `get-max-unacked-messages-per-subscription`
+Get the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-max-unacked-messages-per-subscription tenant/namespace/topic
+```
+
+### `set-max-unacked-messages-per-subscription`
+Set the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-max-unacked-messages-per-subscription tenant/namespace/topic options
+```
+
+### `remove-max-unacked-messages-per-subscription`
+Remove the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-max-unacked-messages-per-subscription tenant/namespace/topic
+```
+
+### `get-max-unacked-messages-per-consumer`
+Get the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-max-unacked-messages-per-consumer tenant/namespace/topic
+```
+
+### `set-max-unacked-messages-per-consumer`
+Set the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-max-unacked-messages-per-consumer tenant/namespace/topic options
+```
+
+### `remove-max-unacked-messages-per-consumer`
+Remove the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-max-unacked-messages-per-consumer tenant/namespace/topic
+```
+
+### `get-delayed-delivery`
+Get the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-delayed-delivery tenant/namespace/topic
+```
+
+### `set-delayed-delivery`
+Set the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-delayed-delivery tenant/namespace/topic options
+```
+
+### `remove-delayed-delivery`
+Remove the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-delayed-delivery tenant/namespace/topic
+```
+
+### `get-max-producers`
+Get the maximum number of Producers for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-maxProducers tenant/namespace/topic
Review comment:
The command `get-maxProducers` is deprecated. See the screenshot above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r573425652
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2267,35 +2230,28 @@ Options
|`-l`, `--ledgerId`|The ledger id |0|
|`-e`, `--entryId`|The entry id |0|
-### `get-backlog-quotas`
-Get the backlog quota policies for a topic.
+### `enable-deduplication`
+Enable a deduplication policy for a topic.
Usage
```bash
-$ pulsar-admin topics get-backlog-quotas tenant/namespace/topic
+$ pulsar-admin topics enable-deduplication tenant/namespace/topic
```
-### `set-backlog-quota`
-Set a backlog quota policy for a topic.
-
-Usage
-```bash
-$ pulsar-admin topics set-backlog-quota tenant/namespace/topic options
-=======
-### `get-deduplication`
-Get a deduplication policy for a topic.
+### `disable-deduplication`
Review comment:
yes, I agree, I think we should apply the changes to 2.7.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap merged pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
zymap merged pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
sijia-w commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r572887161
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2267,35 +2230,28 @@ Options
|`-l`, `--ledgerId`|The ledger id |0|
|`-e`, `--entryId`|The entry id |0|
-### `get-backlog-quotas`
-Get the backlog quota policies for a topic.
+### `enable-deduplication`
+Enable a deduplication policy for a topic.
Usage
```bash
-$ pulsar-admin topics get-backlog-quotas tenant/namespace/topic
+$ pulsar-admin topics enable-deduplication tenant/namespace/topic
```
-### `set-backlog-quota`
-Set a backlog quota policy for a topic.
-
-Usage
-```bash
-$ pulsar-admin topics set-backlog-quota tenant/namespace/topic options
-=======
-### `get-deduplication`
-Get a deduplication policy for a topic.
+### `disable-deduplication`
Review comment:
I am confused about the following commands (see https://github.com/apache/pulsar/pull/9108)
Are `get-max-unacked-messages-on-subscription` and `get-max-unacked-messages-per-subscription` removed too? Or the second one is still in use?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
315157973 commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r572092410
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -1170,7 +1170,7 @@ $ pulsar-admin namespaces set-message-ttl tenant/namespace options
Options
|Flag|Description|Default|
|----|---|---|
-|`-ttl`, `--messageTTL`|Message TTL in seconds. When the value is set to `0`, TTL is disabled. TTL is disabled by default. |0|
+|`-ttl`, `--messageTTL`|Message TTL in seconds|3600s|
Review comment:
It seems that there are many places to confirm according to the code. The default value here should be 0 (disabled),because the default values of topic and namespace-level are both null (not set)
we can see the broker-level default value in broker.conf (ttlDurationDefaultInSeconds)
namespace-level default value in `pulsar/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/Policies.java`
topic-level default in `pulsar/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TopicPolicies.java`
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2267,35 +2230,28 @@ Options
|`-l`, `--ledgerId`|The ledger id |0|
|`-e`, `--entryId`|The entry id |0|
-### `get-backlog-quotas`
-Get the backlog quota policies for a topic.
+### `enable-deduplication`
+Enable a deduplication policy for a topic.
Usage
```bash
-$ pulsar-admin topics get-backlog-quotas tenant/namespace/topic
+$ pulsar-admin topics enable-deduplication tenant/namespace/topic
```
-### `set-backlog-quota`
-Set a backlog quota policy for a topic.
-
-Usage
-```bash
-$ pulsar-admin topics set-backlog-quota tenant/namespace/topic options
-=======
-### `get-deduplication`
-Get a deduplication policy for a topic.
+### `disable-deduplication`
Review comment:
Same here
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2267,35 +2230,28 @@ Options
|`-l`, `--ledgerId`|The ledger id |0|
|`-e`, `--entryId`|The entry id |0|
-### `get-backlog-quotas`
-Get the backlog quota policies for a topic.
+### `enable-deduplication`
+Enable a deduplication policy for a topic.
Review comment:
In order to make topic-level and namespace-level consistent, these commands have been deprecated. See CmdTopics#CmdTopics for details.
The deprecated commands are in CmdTopics#initDeprecatedCommands
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
sijia-w commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r582070199
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2369,20 +2348,279 @@ Remove the message TTL for a topic.
Usage
```bash
-$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
-=======
+$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
+```
+
+Options
+|Flag|Description|Default|
|---|---|---|
|`--enable`, `-e`|Enable message deduplication on the specified topic.|false|
|`--disable`, `-d`|Disable message deduplication on the specified topic.|false|
+### `get-deduplication`
+Get a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-deduplication tenant/namespace/topic
+```
+
+### `set-deduplication`
+Set a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-deduplication tenant/namespace/topic options
+```
+
### `remove-deduplication`
-Remove a deduplication policy from a topic.
+Remove a deduplication policy for a topic.
Usage
```bash
$ pulsar-admin topics remove-deduplication tenant/namespace/topic
```
+### `get-retention`
+Get the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-retention tenant/namespace/topic
+```
+
+### `set-retention`
+Set the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-retention tenant/namespace/topic options
+```
+
+### `remove-retention`
+Remove the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-retention tenant/namespace/topic
+```
+
+### `get-dispatch-rate`
+Get the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-dispatch-rate tenant/namespace/topic
+```
+
+### `set-dispatch-rate`
+Set the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-dispatch-rate tenant/namespace/topic options
+```
+
+### `remove-dispatch-rate`
+Remove the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-dispatch-rate tenant/namespace/topic
+```
+
+### `get-max-unacked-messages-per-subscription`
+Get the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-max-unacked-messages-per-subscription tenant/namespace/topic
+```
+
+### `set-max-unacked-messages-per-subscription`
+Set the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-max-unacked-messages-per-subscription tenant/namespace/topic options
+```
+
+### `remove-max-unacked-messages-per-subscription`
+Remove the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-max-unacked-messages-per-subscription tenant/namespace/topic
+```
+
+### `get-max-unacked-messages-per-consumer`
+Get the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-max-unacked-messages-per-consumer tenant/namespace/topic
+```
+
+### `set-max-unacked-messages-per-consumer`
+Set the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-max-unacked-messages-per-consumer tenant/namespace/topic options
+```
+
+### `remove-max-unacked-messages-per-consumer`
+Remove the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-max-unacked-messages-per-consumer tenant/namespace/topic
+```
+
+### `get-delayed-delivery`
+Get the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-delayed-delivery tenant/namespace/topic
+```
+
+### `set-delayed-delivery`
+Set the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-delayed-delivery tenant/namespace/topic options
+```
+
+### `remove-delayed-delivery`
+Remove the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-delayed-delivery tenant/namespace/topic
+```
+
+### `get-max-producers`
+Get the maximum number of Producers for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-maxProducers tenant/namespace/topic
Review comment:
The command `get-maxProducers` is deprecated. See the screenshot above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijia-w commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
sijia-w commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r572787329
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2267,35 +2230,28 @@ Options
|`-l`, `--ledgerId`|The ledger id |0|
|`-e`, `--entryId`|The entry id |0|
-### `get-backlog-quotas`
-Get the backlog quota policies for a topic.
+### `enable-deduplication`
+Enable a deduplication policy for a topic.
Usage
```bash
-$ pulsar-admin topics get-backlog-quotas tenant/namespace/topic
+$ pulsar-admin topics enable-deduplication tenant/namespace/topic
```
-### `set-backlog-quota`
-Set a backlog quota policy for a topic.
-
-Usage
-```bash
-$ pulsar-admin topics set-backlog-quota tenant/namespace/topic options
-=======
-### `get-deduplication`
-Get a deduplication policy for a topic.
+### `disable-deduplication`
Review comment:
@315157973 @Jennifer88huang I just checked this java file, and I found all added commands in this pr are deprecated. Can you both help double confirm?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#issuecomment-791817019
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
315157973 commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r572874505
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2267,35 +2230,28 @@ Options
|`-l`, `--ledgerId`|The ledger id |0|
|`-e`, `--entryId`|The entry id |0|
-### `get-backlog-quotas`
-Get the backlog quota policies for a topic.
+### `enable-deduplication`
+Enable a deduplication policy for a topic.
Usage
```bash
-$ pulsar-admin topics get-backlog-quotas tenant/namespace/topic
+$ pulsar-admin topics enable-deduplication tenant/namespace/topic
```
-### `set-backlog-quota`
-Set a backlog quota policy for a topic.
-
-Usage
-```bash
-$ pulsar-admin topics set-backlog-quota tenant/namespace/topic options
-=======
-### `get-deduplication`
-Get a deduplication policy for a topic.
+### `disable-deduplication`
Review comment:
The deprecated command is in this method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r581934492
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2369,20 +2348,279 @@ Remove the message TTL for a topic.
Usage
```bash
-$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
-=======
+$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
+```
+
+Options
+|Flag|Description|Default|
|---|---|---|
|`--enable`, `-e`|Enable message deduplication on the specified topic.|false|
|`--disable`, `-d`|Disable message deduplication on the specified topic.|false|
+### `get-deduplication`
+Get a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-deduplication tenant/namespace/topic
+```
+
+### `set-deduplication`
+Set a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-deduplication tenant/namespace/topic options
+```
+
### `remove-deduplication`
-Remove a deduplication policy from a topic.
+Remove a deduplication policy for a topic.
Usage
```bash
$ pulsar-admin topics remove-deduplication tenant/namespace/topic
```
+### `get-retention`
+Get the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-retention tenant/namespace/topic
+```
+
+### `set-retention`
+Set the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-retention tenant/namespace/topic options
Review comment:
shall we describe the available options?
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2369,20 +2348,279 @@ Remove the message TTL for a topic.
Usage
```bash
-$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
-=======
+$ pulsar-admin topics remove-message-ttl tenant/namespace/topic
+```
+
+Options
+|Flag|Description|Default|
|---|---|---|
|`--enable`, `-e`|Enable message deduplication on the specified topic.|false|
|`--disable`, `-d`|Disable message deduplication on the specified topic.|false|
+### `get-deduplication`
+Get a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-deduplication tenant/namespace/topic
+```
+
+### `set-deduplication`
+Set a deduplication policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-deduplication tenant/namespace/topic options
+```
+
### `remove-deduplication`
-Remove a deduplication policy from a topic.
+Remove a deduplication policy for a topic.
Usage
```bash
$ pulsar-admin topics remove-deduplication tenant/namespace/topic
```
+### `get-retention`
+Get the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-retention tenant/namespace/topic
+```
+
+### `set-retention`
+Set the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-retention tenant/namespace/topic options
+```
+
+### `remove-retention`
+Remove the retention policy that is applied to a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-retention tenant/namespace/topic
+```
+
+### `get-dispatch-rate`
+Get the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-dispatch-rate tenant/namespace/topic
+```
+
+### `set-dispatch-rate`
+Set the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-dispatch-rate tenant/namespace/topic options
+```
+
+### `remove-dispatch-rate`
+Remove the message dispatch rate for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-dispatch-rate tenant/namespace/topic
+```
+
+### `get-max-unacked-messages-per-subscription`
+Get the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-max-unacked-messages-per-subscription tenant/namespace/topic
+```
+
+### `set-max-unacked-messages-per-subscription`
+Set the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-max-unacked-messages-per-subscription tenant/namespace/topic options
+```
+
+### `remove-max-unacked-messages-per-subscription`
+Remove the maximum number of unacked messages per subscription for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-max-unacked-messages-per-subscription tenant/namespace/topic
+```
+
+### `get-max-unacked-messages-per-consumer`
+Get the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-max-unacked-messages-per-consumer tenant/namespace/topic
+```
+
+### `set-max-unacked-messages-per-consumer`
+Set the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-max-unacked-messages-per-consumer tenant/namespace/topic options
+```
+
+### `remove-max-unacked-messages-per-consumer`
+Remove the maximum number of unacked messages per consumer for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-max-unacked-messages-per-consumer tenant/namespace/topic
+```
+
+### `get-delayed-delivery`
+Get the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-delayed-delivery tenant/namespace/topic
+```
+
+### `set-delayed-delivery`
+Set the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics set-delayed-delivery tenant/namespace/topic options
+```
+
+### `remove-delayed-delivery`
+Remove the delayed delivery policy for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics remove-delayed-delivery tenant/namespace/topic
+```
+
+### `get-max-producers`
+Get the maximum number of Producers for a topic.
+
+Usage
+```bash
+$ pulsar-admin topics get-maxProducers tenant/namespace/topic
Review comment:
the title should be consistent with the command: get-maxProducers, same comments for the following.
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2267,6 +2259,14 @@ Options
|`-l`, `--ledgerId`|The ledger id |0|
|`-e`, `--entryId`|The entry id |0|
+### `last-message-id`
+Get the last commit message id of topic.
Review comment:
```suggestion
Get the last commit message ID of the topic.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#issuecomment-784197891
@sijia-w Please rebase your code, we have fixed the CI problem at master.
@Jennifer88huang Please take another look at this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] 315157973 commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
315157973 commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r572740924
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -2267,35 +2230,28 @@ Options
|`-l`, `--ledgerId`|The ledger id |0|
|`-e`, `--entryId`|The entry id |0|
-### `get-backlog-quotas`
-Get the backlog quota policies for a topic.
+### `enable-deduplication`
+Enable a deduplication policy for a topic.
Usage
```bash
-$ pulsar-admin topics get-backlog-quotas tenant/namespace/topic
+$ pulsar-admin topics enable-deduplication tenant/namespace/topic
```
-### `set-backlog-quota`
-Set a backlog quota policy for a topic.
-
-Usage
-```bash
-$ pulsar-admin topics set-backlog-quota tenant/namespace/topic options
-=======
-### `get-deduplication`
-Get a deduplication policy for a topic.
+### `disable-deduplication`
Review comment:
The deprecated commands are in `initDeprecatedCommands` method of `CmdTopics.java`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on a change in pull request #9530: [DOCS] - Update the topic-level policies
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on a change in pull request #9530:
URL: https://github.com/apache/pulsar/pull/9530#discussion_r573422364
##########
File path: site2/docs/reference-pulsar-admin.md
##########
@@ -1170,7 +1170,7 @@ $ pulsar-admin namespaces set-message-ttl tenant/namespace options
Options
|Flag|Description|Default|
|----|---|---|
-|`-ttl`, `--messageTTL`|Message TTL in seconds. When the value is set to `0`, TTL is disabled. TTL is disabled by default. |0|
+|`-ttl`, `--messageTTL`|Message TTL in seconds|3600s|
Review comment:
The default values and description have been fixed in https://github.com/apache/pulsar/pull/9395
So I sincerely suggest that we rebase the master first and then make edits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org