[jira] [Work logged] (BEAM-14166) Improvements to RowWithGetter

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-14166?focusedWorklogId=769325&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769325 ]

ASF GitHub Bot logged work on BEAM-14166:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/May/22 21:46
            Start Date: 11/May/22 21:46
    Worklog Time Spent: 10m 
      Work Description: TheNeuralBit commented on PR #17172:
URL: https://github.com/apache/beam/pull/17172#issuecomment-1124323978

   Run SQL PostCommit




Issue Time Tracking
-------------------

    Worklog Id:     (was: 769325)
    Time Spent: 2.5h  (was: 2h 20m)

> Improvements to RowWithGetter
> -----------------------------
>
>                 Key: BEAM-14166
>                 URL: https://issues.apache.org/jira/browse/BEAM-14166
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Moritz Mack
>            Assignee: Moritz Mack
>            Priority: P2
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Various improvements to getValue(fieldIdx) in RowWithGetters mentioned [here|[https://github.com/apache/beam/pull/16947#discussion_r833602836]:]
>  * Minimize memory overhead of cache using either a index lookup (array) or a single hash map if number of fields exceeds the initial hashmap capacity
>  * The cache should be checked before calling a getter to avoid any potentially unnecessary conversion in the getter itself.
>  * [Nested rows|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java#L111] should be cached, otherwise the cache of such nested rows can't be leveraged.
>  * Handling of collections / maps / iterables can be significantly improved by simply skipping the transform in all cases where {{getValue}} for members is the [identity transform|https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java#L142]. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)