You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/12/14 07:31:17 UTC
[GitHub] [geode] jvarenina opened a new pull request #5844: GEODE-7802: Add disclaimer for OQL queries in UG
jvarenina opened a new pull request #5844:
URL: https://github.com/apache/geode/pull/5844
Disclaimer: OQL queries are not pre-validated for nonexistent attributes
and methods
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 merged pull request #5844: GEODE-7802: Add disclaimer for OQL queries in UG
Posted by GitBox <gi...@apache.org>.
davebarnes97 merged pull request #5844:
URL: https://github.com/apache/geode/pull/5844
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #5844: GEODE-7802: Add disclaimer for OQL queries in UG
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #5844:
URL: https://github.com/apache/geode/pull/5844#discussion_r542973121
##########
File path: geode-docs/developing/querying_basics/restrictions_and_unsupported_features.html.md.erb
##########
@@ -30,6 +30,6 @@ At a high level, <%=vars.product_name%> does not support the following querying
- You cannot create an index on fields using Set/List types (Collection types) that are not comparable. The OQL index implementation expects fields to be Comparable. To workaround this, you can create a custom Collection type that implements Comparable.
- ORDER BY is only supported with DISTINCT queries.
-
+- OQL queries aren't pre-validated for references to nonexistent methods and attributes.
Review comment:
I will propose a rewrite tomorrow that incorporates @agingade's verbiage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #5844: GEODE-7802: Add disclaimer for OQL queries in UG
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #5844:
URL: https://github.com/apache/geode/pull/5844#discussion_r543781122
##########
File path: geode-docs/developing/querying_basics/restrictions_and_unsupported_features.html.md.erb
##########
@@ -30,6 +30,6 @@ At a high level, <%=vars.product_name%> does not support the following querying
- You cannot create an index on fields using Set/List types (Collection types) that are not comparable. The OQL index implementation expects fields to be Comparable. To workaround this, you can create a custom Collection type that implements Comparable.
- ORDER BY is only supported with DISTINCT queries.
-
+- OQL queries aren't pre-validated for references to nonexistent methods and attributes.
Review comment:
[My suggested revision, adding some of Anil's explanation from the JIRA comments for context, and expanding contractions to whole words for better translation/localization. @agingade please review]
In the Geode model, attributes and methods are resolved at runtime during query execution. This means that OQL queries are not pre-validated for references to nonexistent methods and attributes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #5844: GEODE-7802: Add disclaimer for OQL queries in UG
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #5844:
URL: https://github.com/apache/geode/pull/5844#discussion_r543781122
##########
File path: geode-docs/developing/querying_basics/restrictions_and_unsupported_features.html.md.erb
##########
@@ -30,6 +30,6 @@ At a high level, <%=vars.product_name%> does not support the following querying
- You cannot create an index on fields using Set/List types (Collection types) that are not comparable. The OQL index implementation expects fields to be Comparable. To workaround this, you can create a custom Collection type that implements Comparable.
- ORDER BY is only supported with DISTINCT queries.
-
+- OQL queries aren't pre-validated for references to nonexistent methods and attributes.
Review comment:
[My suggested revision, adding some of Anil's explanation from the JIRA comments for context, and expanding contractions to whole words for better translation/localization]
In the Geode model, attributes and methods are resolved at runtime during query execution. This means that OQL queries are not pre-validated for references to nonexistent methods and attributes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jvarenina commented on a change in pull request #5844: GEODE-7802: Add disclaimer for OQL queries in UG
Posted by GitBox <gi...@apache.org>.
jvarenina commented on a change in pull request #5844:
URL: https://github.com/apache/geode/pull/5844#discussion_r546686059
##########
File path: geode-docs/developing/querying_basics/restrictions_and_unsupported_features.html.md.erb
##########
@@ -30,6 +30,6 @@ At a high level, <%=vars.product_name%> does not support the following querying
- You cannot create an index on fields using Set/List types (Collection types) that are not comparable. The OQL index implementation expects fields to be Comparable. To workaround this, you can create a custom Collection type that implements Comparable.
- ORDER BY is only supported with DISTINCT queries.
-
+- OQL queries aren't pre-validated for references to nonexistent methods and attributes.
Review comment:
Thank you both for comments and proposals. I have updated PR based on the @davebarnes97 proposal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #5844: GEODE-7802: Add disclaimer for OQL queries in UG
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #5844:
URL: https://github.com/apache/geode/pull/5844#discussion_r542973121
##########
File path: geode-docs/developing/querying_basics/restrictions_and_unsupported_features.html.md.erb
##########
@@ -30,6 +30,6 @@ At a high level, <%=vars.product_name%> does not support the following querying
- You cannot create an index on fields using Set/List types (Collection types) that are not comparable. The OQL index implementation expects fields to be Comparable. To workaround this, you can create a custom Collection type that implements Comparable.
- ORDER BY is only supported with DISTINCT queries.
-
+- OQL queries aren't pre-validated for references to nonexistent methods and attributes.
Review comment:
I will propose a rewrite tomorrow that uses @agingade's verbiage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] agingade commented on a change in pull request #5844: GEODE-7802: Add disclaimer for OQL queries in UG
Posted by GitBox <gi...@apache.org>.
agingade commented on a change in pull request #5844:
URL: https://github.com/apache/geode/pull/5844#discussion_r542493639
##########
File path: geode-docs/developing/querying_basics/restrictions_and_unsupported_features.html.md.erb
##########
@@ -30,6 +30,6 @@ At a high level, <%=vars.product_name%> does not support the following querying
- You cannot create an index on fields using Set/List types (Collection types) that are not comparable. The OQL index implementation expects fields to be Comparable. To workaround this, you can create a custom Collection type that implements Comparable.
- ORDER BY is only supported with DISTINCT queries.
-
+- OQL queries aren't pre-validated for references to nonexistent methods and attributes.
Review comment:
I have commented on the ticket with my thoughts.
What could be added here is, saying OQL query engine determines the field or methods on the given object (region keys and values) during query execution time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] davebarnes97 commented on a change in pull request #5844: GEODE-7802: Add disclaimer for OQL queries in UG
Posted by GitBox <gi...@apache.org>.
davebarnes97 commented on a change in pull request #5844:
URL: https://github.com/apache/geode/pull/5844#discussion_r542973121
##########
File path: geode-docs/developing/querying_basics/restrictions_and_unsupported_features.html.md.erb
##########
@@ -30,6 +30,6 @@ At a high level, <%=vars.product_name%> does not support the following querying
- You cannot create an index on fields using Set/List types (Collection types) that are not comparable. The OQL index implementation expects fields to be Comparable. To workaround this, you can create a custom Collection type that implements Comparable.
- ORDER BY is only supported with DISTINCT queries.
-
+- OQL queries aren't pre-validated for references to nonexistent methods and attributes.
Review comment:
I will propose a rewrite tomorrow that incorporates @agingade's verbiage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org