You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Steven Gill <st...@gmail.com> on 2013/12/10 19:37:47 UTC
3.3.0 Release
Lets start the final round of tagging today!
https://issues.apache.org/jira/browse/CB-5538
Re: 3.3.0 Release
Posted by Shazron <sh...@gmail.com>.
Thanks for looking at iOS James
3.3 iOS is essentially 3.2 since most of the work has gone into plugins.
I will be tagging 3.3 iOS final soon.
On Thu, Dec 12, 2013 at 5:34 AM, David Barth <da...@canonical.com>wrote:
> Le 11/12/2013 23:49, Steven Gill a écrit :
>
> The master branch on CLI now depends on the correct plugman. That problem
>> should be good.
>>
>> I will review the two pull requests and merge in if they look good.
>>
> And there is a 3rd one to make it run more reliably:
> https://github.com/Zaspire/cordova-ubuntu/commit/
> faff5d6f1d710426181ea966bf88214ff076d91f
>
>
>> I am not sure about the CLI not honoring the dependencies expressed in
>> package.json. I don't think the CLI has any logic to do that. I think it
>> should be handled in a platform level script. Maybe force npm install
>> before the create command runs? Maybe create an init script like
>> blackberry10 has and run that while running check reqs? Others might have
>> better suggestions for this one.
>>
> Carlos clarified things. The pull requests above are going in the same
> direction, ie ensuring the installation of dependencies by the platform
> scripts themselves.
>
>
>
>> Other platforms ran into the permission issue you mentioned. I think
>> https://issues.apache.org/jira/browse/CB-3812 should have fixed it. Maybe
>> others can chime in with some suggestions here too.
>>
> Yes, I couldn't re-install support for android in a test example either.
> This will help.
>
> David
>
Re: 3.3.0 Release
Posted by Steven Gill <st...@gmail.com>.
The docs will also be going out today :).
I will review your pull requests after lunch and catch you on IRC.
On Thu, Dec 12, 2013 at 12:19 PM, David Barth <da...@canonical.com>wrote:
> Le 12/12/2013 14:34, David Barth a écrit :
>
>
>>> Other platforms ran into the permission issue you mentioned. I think
>>> https://issues.apache.org/jira/browse/CB-3812 should have fixed it.
>>> Maybe
>>> others can chime in with some suggestions here too.
>>>
>> Yes, I couldn't re-install support for android in a test example either.
>> This will help.
>>
>
> Switching to shelljs@2.0.6 fixes the issue
>
> So, from a runtime perspective, we're just a few pull request from a +1
> here for Ubuntu.
> https://github.com/apache/cordova-ubuntu/pull/4
>
> I'll send 2 more pull requests for the doc. Not sure if that is tagged the
> same day.
>
> David
>
Re: 3.3.0 Release
Posted by David Barth <da...@canonical.com>.
Le 12/12/2013 14:34, David Barth a écrit :
>>
>> Other platforms ran into the permission issue you mentioned. I think
>> https://issues.apache.org/jira/browse/CB-3812 should have fixed it.
>> Maybe
>> others can chime in with some suggestions here too.
> Yes, I couldn't re-install support for android in a test example
> either. This will help.
Switching to shelljs@2.0.6 fixes the issue
So, from a runtime perspective, we're just a few pull request from a +1
here for Ubuntu.
https://github.com/apache/cordova-ubuntu/pull/4
I'll send 2 more pull requests for the doc. Not sure if that is tagged
the same day.
David
Re: 3.3.0 Release
Posted by David Barth <da...@canonical.com>.
Le 11/12/2013 23:49, Steven Gill a écrit :
> The master branch on CLI now depends on the correct plugman. That problem
> should be good.
>
> I will review the two pull requests and merge in if they look good.
And there is a 3rd one to make it run more reliably:
https://github.com/Zaspire/cordova-ubuntu/commit/faff5d6f1d710426181ea966bf88214ff076d91f
>
> I am not sure about the CLI not honoring the dependencies expressed in
> package.json. I don't think the CLI has any logic to do that. I think it
> should be handled in a platform level script. Maybe force npm install
> before the create command runs? Maybe create an init script like
> blackberry10 has and run that while running check reqs? Others might have
> better suggestions for this one.
Carlos clarified things. The pull requests above are going in the same
direction, ie ensuring the installation of dependencies by the platform
scripts themselves.
>
> Other platforms ran into the permission issue you mentioned. I think
> https://issues.apache.org/jira/browse/CB-3812 should have fixed it. Maybe
> others can chime in with some suggestions here too.
Yes, I couldn't re-install support for android in a test example either.
This will help.
David
Re: 3.3.0 Release
Posted by David Barth <da...@canonical.com>.
Le 12/12/2013 03:21, Carlos Santana a écrit :
> CLI design contract is to just run platforms/<platfomid>/bin/create nothing
> about running npm install on platform repo files.
>
> If your platform scripts have dependencies platform is responsible to
> satisfy its dependencies.
>
> BlackBerry and Android have dependencies on npm modules, both handle
> differently
>
> Android include npm dependencies in the repo
> https://github.com/apache/cordova-android/tree/master/bin/node_modules
>
> BlackBerry runs npm install to install on demand as part of create script
> https://github.com/apache/cordova-blackberry/blob/master/blackberry10/bin/create#L38
>
> hope this clarifies
Thanks Carlos, it does.
David
Re: 3.3.0 Release
Posted by Carlos Santana <cs...@gmail.com>.
CLI design contract is to just run platforms/<platfomid>/bin/create nothing
about running npm install on platform repo files.
If your platform scripts have dependencies platform is responsible to
satisfy its dependencies.
BlackBerry and Android have dependencies on npm modules, both handle
differently
Android include npm dependencies in the repo
https://github.com/apache/cordova-android/tree/master/bin/node_modules
BlackBerry runs npm install to install on demand as part of create script
https://github.com/apache/cordova-blackberry/blob/master/blackberry10/bin/create#L38
hope this clarifies
On Wed, Dec 11, 2013 at 5:49 PM, Steven Gill <st...@gmail.com> wrote:
> The master branch on CLI now depends on the correct plugman. That problem
> should be good.
>
> I will review the two pull requests and merge in if they look good.
>
> I am not sure about the CLI not honoring the dependencies expressed in
> package.json. I don't think the CLI has any logic to do that. I think it
> should be handled in a platform level script. Maybe force npm install
> before the create command runs? Maybe create an init script like
> blackberry10 has and run that while running check reqs? Others might have
> better suggestions for this one.
>
> Other platforms ran into the permission issue you mentioned. I think
> https://issues.apache.org/jira/browse/CB-3812 should have fixed it. Maybe
> others can chime in with some suggestions here too.
>
>
>
>
> On Wed, Dec 11, 2013 at 10:44 AM, David Barth <david.barth@canonical.com
> >wrote:
>
> > Le 11/12/2013 16:39, David Barth a écrit :
> >
> > Le 10/12/2013 19:37, Steven Gill a écrit :
> >>
> >>> Lets start the final round of tagging today!
> >>> https://issues.apache.org/jira/browse/CB-5538
> >>>
> >> +1, but we're still chasing down some dependency and chmod +x issues on
> >> the Ubuntu part. Will update this thread shortly.
> >>
> > Maxim added a workaround in those pull request to ensure that the
> > dependencies for the ubuntu commands are satisfied:
> >
> > https://github.com/apache/cordova-ubuntu/pull/2
> > https://github.com/apache/cordova-ubuntu/pull/1
> >
> > Somehow, cordova-cli is not honoring the dependencies expressed in the
> > package.json file here:
> >
> > https://github.com/apache/cordova-ubuntu/blob/master/bin/package.json
> >
> > maybe they should move one directory above, but I'm not so keen on
> > changing that this late.
> >
> > Please note also that the rc1 cordova-cli in the NPM registry still
> points
> > to an old plugman version that does not support ubuntu.
> >
> > Let me know if i'm missing something here.
> >
> > I'll send an update when the remaining command permission issue is fixed.
> > https://issues.apache.org/jira/browse/CB-5629
> >
> > David
> >
>
--
Carlos Santana
<cs...@gmail.com>
Re: 3.3.0 Release
Posted by Steven Gill <st...@gmail.com>.
The master branch on CLI now depends on the correct plugman. That problem
should be good.
I will review the two pull requests and merge in if they look good.
I am not sure about the CLI not honoring the dependencies expressed in
package.json. I don't think the CLI has any logic to do that. I think it
should be handled in a platform level script. Maybe force npm install
before the create command runs? Maybe create an init script like
blackberry10 has and run that while running check reqs? Others might have
better suggestions for this one.
Other platforms ran into the permission issue you mentioned. I think
https://issues.apache.org/jira/browse/CB-3812 should have fixed it. Maybe
others can chime in with some suggestions here too.
On Wed, Dec 11, 2013 at 10:44 AM, David Barth <da...@canonical.com>wrote:
> Le 11/12/2013 16:39, David Barth a écrit :
>
> Le 10/12/2013 19:37, Steven Gill a écrit :
>>
>>> Lets start the final round of tagging today!
>>> https://issues.apache.org/jira/browse/CB-5538
>>>
>> +1, but we're still chasing down some dependency and chmod +x issues on
>> the Ubuntu part. Will update this thread shortly.
>>
> Maxim added a workaround in those pull request to ensure that the
> dependencies for the ubuntu commands are satisfied:
>
> https://github.com/apache/cordova-ubuntu/pull/2
> https://github.com/apache/cordova-ubuntu/pull/1
>
> Somehow, cordova-cli is not honoring the dependencies expressed in the
> package.json file here:
>
> https://github.com/apache/cordova-ubuntu/blob/master/bin/package.json
>
> maybe they should move one directory above, but I'm not so keen on
> changing that this late.
>
> Please note also that the rc1 cordova-cli in the NPM registry still points
> to an old plugman version that does not support ubuntu.
>
> Let me know if i'm missing something here.
>
> I'll send an update when the remaining command permission issue is fixed.
> https://issues.apache.org/jira/browse/CB-5629
>
> David
>
Re: 3.3.0 Release
Posted by David Barth <da...@canonical.com>.
Le 11/12/2013 16:39, David Barth a écrit :
> Le 10/12/2013 19:37, Steven Gill a écrit :
>> Lets start the final round of tagging today!
>> https://issues.apache.org/jira/browse/CB-5538
> +1, but we're still chasing down some dependency and chmod +x issues
> on the Ubuntu part. Will update this thread shortly.
Maxim added a workaround in those pull request to ensure that the
dependencies for the ubuntu commands are satisfied:
https://github.com/apache/cordova-ubuntu/pull/2
https://github.com/apache/cordova-ubuntu/pull/1
Somehow, cordova-cli is not honoring the dependencies expressed in the
package.json file here:
https://github.com/apache/cordova-ubuntu/blob/master/bin/package.json
maybe they should move one directory above, but I'm not so keen on
changing that this late.
Please note also that the rc1 cordova-cli in the NPM registry still
points to an old plugman version that does not support ubuntu.
Let me know if i'm missing something here.
I'll send an update when the remaining command permission issue is
fixed. https://issues.apache.org/jira/browse/CB-5629
David
Re: 3.3.0 Release
Posted by David Barth <da...@canonical.com>.
Le 10/12/2013 19:37, Steven Gill a écrit :
> Lets start the final round of tagging today!
> https://issues.apache.org/jira/browse/CB-5538
+1, but we're still chasing down some dependency and chmod +x issues on
the Ubuntu part. Will update this thread shortly.
David
Re: 3.3.0 Release
Posted by James Jong <wj...@gmail.com>.
+1 FYI, I have been testing Cordova with iOS 7.1 beta. No new issues with it.
-James Jong
On Dec 10, 2013, at 1:40 PM, Joe Bowser <bo...@gmail.com> wrote:
> SGTM!
>
> On Tue, Dec 10, 2013 at 10:37 AM, Steven Gill <st...@gmail.com> wrote:
>> Lets start the final round of tagging today!
>> https://issues.apache.org/jira/browse/CB-5538
Re: 3.3.0 Release
Posted by Joe Bowser <bo...@gmail.com>.
SGTM!
On Tue, Dec 10, 2013 at 10:37 AM, Steven Gill <st...@gmail.com> wrote:
> Lets start the final round of tagging today!
> https://issues.apache.org/jira/browse/CB-5538